| Message ID | 20220928000517.228382-2-bryan.odonoghue@linaro.org |
|---|---|
| State | Accepted |
| Commit | 763ab98687404d924b6612f7c9c8430333d31229 |
| Headers | show |
| Series | [v6,1/1] dt-bindings: mfd: qcom,spmi-pmic: Drop PWM reg dependency | expand |
On Wed, 28 Sep 2022, Bryan O'Donoghue wrote: > The PWM node is not a separate device and is expected to be part of parent > SPMI PMIC node, thus it obtains the address space from the parent. One IO > address in "reg" is also not correct description because LPG block maps to > several regions. > > Fixes: 3f5117be9584 ("dt-bindings: mfd: convert to yaml Qualcomm SPMI PMIC") > Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) Applied, thanks. NB: This applied with conflicts. I fixed them up, but they might be incorrect. Please ensure you review them, either in the MFD tree, or when they appear in -next.
diff --git a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml index 65cbc6dee545e..2a5bafe0660a0 100644 --- a/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml +++ b/Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml @@ -92,6 +92,10 @@ properties: type: object $ref: /schemas/regulator/regulator.yaml# + pwm: + type: object + $ref: /schemas/leds/leds-qcom-lpg.yaml# + patternProperties: "^adc@[0-9a-f]+$": type: object @@ -117,10 +121,6 @@ patternProperties: type: object $ref: /schemas/power/reset/qcom,pon.yaml# - "pwm@[0-9a-f]+$": - type: object - $ref: /schemas/leds/leds-qcom-lpg.yaml# - "^rtc@[0-9a-f]+$": type: object $ref: /schemas/rtc/qcom-pm8xxx-rtc.yaml#
The PWM node is not a separate device and is expected to be part of parent SPMI PMIC node, thus it obtains the address space from the parent. One IO address in "reg" is also not correct description because LPG block maps to several regions. Fixes: 3f5117be9584 ("dt-bindings: mfd: convert to yaml Qualcomm SPMI PMIC") Suggested-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- Documentation/devicetree/bindings/mfd/qcom,spmi-pmic.yaml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)