diff mbox series

[3/4] ALSA: usb-audio: Correct the return code from snd_usb_endpoint_set_params()

Message ID 20221009104212.18877-4-tiwai@suse.de
State Accepted
Commit 9355b60e401d825590d37f04ea873c58efe9b7bf
Headers show
Series ALSA: usb-audio: More EP-related fixes | expand

Commit Message

Takashi Iwai Oct. 9, 2022, 10:42 a.m. UTC 
snd_usb_endpoint_set_params() should return zero for a success, but
currently it returns the sample rate.  Correct it.

Fixes: 2be79d586454 ("ALSA: usb-audio: Split endpoint setups for hw_params and prepare (take#2)")
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
 sound/usb/endpoint.c | 2 ++
 1 file changed, 2 insertions(+)
diff mbox series

Patch

diff --git a/sound/usb/endpoint.c b/sound/usb/endpoint.c
index da378e565ef8..44cce6cec9da 100644
--- a/sound/usb/endpoint.c
+++ b/sound/usb/endpoint.c
@@ -1386,6 +1386,8 @@  int snd_usb_endpoint_set_params(struct snd_usb_audio *chip,
 	ep->curframesize = ep->curpacksize / ep->cur_frame_bytes;
 
 	err = update_clock_ref_rate(chip, ep);
+	if (err >= 0)
+		err = 0;
  unlock:
 	mutex_unlock(&chip->mutex);
 	return err;