[10/20] phy: qcom-qmp-ufs: drop unused phy-status config

Message ID	20221012085002.24099-10-johan+linaro@kernel.org
State	Accepted
Commit	c8f5c188156b87c115f27d44004428ede2e262f8
Headers	show Return-Path: <linux-arm-msm-owner@kernel.org> From: Johan Hovold <johan+linaro@kernel.org> To: Vinod Koul <vkoul@kernel.org> Cc: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Kishon Vijay Abraham I <kishon@ti.com>, Dmitry Baryshkov <dmitry.baryshkov@linaro.org>, linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Johan Hovold <johan+linaro@kernel.org> Subject: [PATCH 10/20] phy: qcom-qmp-ufs: drop unused phy-status config Date: Wed, 12 Oct 2022 10:49:52 +0200 Message-Id: <20221012085002.24099-10-johan+linaro@kernel.org> In-Reply-To: <20221012085002.24099-1-johan+linaro@kernel.org> References: <20221012084846.24003-1-johan+linaro@kernel.org> <20221012085002.24099-1-johan+linaro@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	phy: qcom-qmp: further prep fixes and cleanups (set 3) \| expand [00/20] phy: qcom-qmp: further prep fixes and cleanups (set 3) [01/20] phy: qcom-qmp-pcie: fix sc8180x initialisation [02/20] phy: qcom-qmp-pcie: fix ipq8074-gen3 initialisation [03/20] phy: qcom-qmp-pcie: fix ipq6018 initialisation [04/20] phy: qcom-qmp-pcie: clean up status polling [05/20] phy: qcom-qmp-pcie: increase status polling period [06/20] phy: qcom-qmp-pcie-msm8996: clean up ready and status polling [07/20] phy: qcom-qmp-pcie-msm8996: increase status polling period [08/20] phy: qcom-qmp-combo: clean up status polling [09/20] phy: qcom-qmp-combo: increase status polling period [10/20] phy: qcom-qmp-ufs: drop unused phy-status config [11/20] phy: qcom-qmp-ufs: clean up ready polling [12/20] phy: qcom-qmp-ufs: increase ready polling period [13/20] phy: qcom-qmp-usb: clean up status polling [14/20] phy: qcom-qmp-usb: increase status polling period [15/20] phy: qcom-qmp-combo: drop start and pwrdn-ctrl abstraction [16/20] phy: qcom-qmp-pcie: drop start-ctrl abstraction [17/20] phy: qcom-qmp-pcie: add config sanity checks [18/20] phy: qcom-qmp-pcie-msm8996: drop start and pwrdn-ctrl abstraction [19/20] phy: qcom-qmp-ufs: drop start and pwrdn-ctrl abstraction [20/20] phy: qcom-qmp-usb: drop start and pwrdn-ctrl abstraction

Message ID

20221012085002.24099-10-johan+linaro@kernel.org

State

Accepted

Commit

c8f5c188156b87c115f27d44004428ede2e262f8

Headers

From: Johan Hovold <johan+linaro@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
        Bjorn Andersson <andersson@kernel.org>,
        Konrad Dybcio <konrad.dybcio@somainline.org>,
        Kishon Vijay Abraham I <kishon@ti.com>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Johan Hovold <johan+linaro@kernel.org>
Subject: [PATCH 10/20] phy: qcom-qmp-ufs: drop unused phy-status config
Date: Wed, 12 Oct 2022 10:49:52 +0200
Message-Id: <20221012085002.24099-10-johan+linaro@kernel.org>
In-Reply-To: <20221012085002.24099-1-johan+linaro@kernel.org>
References: <20221012084846.24003-1-johan+linaro@kernel.org>
 <20221012085002.24099-1-johan+linaro@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

phy: qcom-qmp: further prep fixes and cleanups (set 3) | expand

Drop the unused phy-status configuration mask which has never been used for UFS PHYs. Signed-off-by: Johan Hovold <johan+linaro@kernel.org> --- drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 9 --------- 1 file changed, 9 deletions(-)

Comments

Dmitry Baryshkov Oct. 12, 2022, 9:14 p.m. UTC | #1

On 12/10/2022 11:49, Johan Hovold wrote:
> Drop the unused phy-status configuration mask which has never been used
> for UFS PHYs.
> 
> Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
> ---
>   drivers/phy/qualcomm/phy-qcom-qmp-ufs.c | 9 ---------
>   1 file changed, 9 deletions(-)

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
index 02931b82132f..1c7d8fc9b94a 100644
--- a/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-ufs.c
@@ -31,8 +31,6 @@ 
 /* QPHY_START_CONTROL bits */
 #define SERDES_START				BIT(0)
 #define PCS_START				BIT(1)
-/* QPHY_PCS_STATUS bit */
-#define PHYSTATUS				BIT(6)
 /* QPHY_PCS_READY_STATUS bit */
 #define PCS_READY				BIT(0)
 
@@ -548,8 +546,6 @@  struct qmp_phy_cfg {
 
 	unsigned int start_ctrl;
 	unsigned int pwrdn_ctrl;
-	/* bit offset of PHYSTATUS in QPHY_PCS_STATUS register */
-	unsigned int phy_status;
 
 	/* true, if PCS block has no separate SW_RESET register */
 	bool no_pcs_sw_reset;
@@ -668,7 +664,6 @@  static const struct qmp_phy_cfg msm8996_ufs_cfg = {
 
 	.start_ctrl		= SERDES_START,
 	.pwrdn_ctrl		= SW_PWRDN,
-	.phy_status		= PHYSTATUS,
 
 	.no_pcs_sw_reset	= true,
 };
@@ -692,7 +687,6 @@  static const struct qmp_phy_cfg sdm845_ufsphy_cfg = {
 
 	.start_ctrl		= SERDES_START,
 	.pwrdn_ctrl		= SW_PWRDN,
-	.phy_status		= PHYSTATUS,
 
 	.no_pcs_sw_reset	= true,
 };
@@ -739,7 +733,6 @@  static const struct qmp_phy_cfg sm8150_ufsphy_cfg = {
 
 	.start_ctrl		= SERDES_START,
 	.pwrdn_ctrl		= SW_PWRDN,
-	.phy_status		= PHYSTATUS,
 };
 
 static const struct qmp_phy_cfg sm8350_ufsphy_cfg = {
@@ -761,7 +754,6 @@  static const struct qmp_phy_cfg sm8350_ufsphy_cfg = {
 
 	.start_ctrl		= SERDES_START,
 	.pwrdn_ctrl		= SW_PWRDN,
-	.phy_status		= PHYSTATUS,
 };
 
 static const struct qmp_phy_cfg sm8450_ufsphy_cfg = {
@@ -783,7 +775,6 @@  static const struct qmp_phy_cfg sm8450_ufsphy_cfg = {
 
 	.start_ctrl		= SERDES_START,
 	.pwrdn_ctrl		= SW_PWRDN,
-	.phy_status		= PHYSTATUS,
 };
 
 static void qmp_ufs_configure_lane(void __iomem *base,

[10/20] phy: qcom-qmp-ufs: drop unused phy-status config

Commit Message

Comments

Patch