| Message ID | 20221013130500.967432-1-peter.maydell@linaro.org |
|---|---|
| State | Accepted |
| Commit | fe8a7390c10c78b806211d7e36727c461d39a17f |
| Headers | show |
| Series | include/hw/scsi/scsi.h: Remove unused scsi_legacy_handle_cmdline() prototype | expand |
On 13/10/2022 15.05, Peter Maydell wrote: > In commit 1454509726719e0933c80 we removed the function > scsi_legacy_handle_cmdline() and all of its callers, but forgot to > delete the prototype from the header function. Delete the prototype > too. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > include/hw/scsi/scsi.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h > index 001103488c2..9ad86b25bb4 100644 > --- a/include/hw/scsi/scsi.h > +++ b/include/hw/scsi/scsi.h > @@ -187,7 +187,6 @@ SCSIDevice *scsi_bus_legacy_add_drive(SCSIBus *bus, BlockBackend *blk, > BlockdevOnError werror, > const char *serial, Error **errp); > void scsi_bus_legacy_handle_cmdline(SCSIBus *bus); > -void scsi_legacy_handle_cmdline(void); > > SCSIRequest *scsi_req_alloc(const SCSIReqOps *reqops, SCSIDevice *d, > uint32_t tag, uint32_t lun, void *hba_private); Reviewed-by: Thomas Huth <thuth@redhat.com>
On 13/10/22 15:05, Peter Maydell wrote: > In commit 1454509726719e0933c80 we removed the function > scsi_legacy_handle_cmdline() and all of its callers, but forgot to > delete the prototype from the header function. Delete the prototype > too. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > include/hw/scsi/scsi.h | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Le 13/10/2022 à 15:05, Peter Maydell a écrit : > In commit 1454509726719e0933c80 we removed the function > scsi_legacy_handle_cmdline() and all of its callers, but forgot to > delete the prototype from the header function. Delete the prototype > too. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > --- > include/hw/scsi/scsi.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h > index 001103488c2..9ad86b25bb4 100644 > --- a/include/hw/scsi/scsi.h > +++ b/include/hw/scsi/scsi.h > @@ -187,7 +187,6 @@ SCSIDevice *scsi_bus_legacy_add_drive(SCSIBus *bus, BlockBackend *blk, > BlockdevOnError werror, > const char *serial, Error **errp); > void scsi_bus_legacy_handle_cmdline(SCSIBus *bus); > -void scsi_legacy_handle_cmdline(void); > > SCSIRequest *scsi_req_alloc(const SCSIReqOps *reqops, SCSIDevice *d, > uint32_t tag, uint32_t lun, void *hba_private); Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/include/hw/scsi/scsi.h b/include/hw/scsi/scsi.h index 001103488c2..9ad86b25bb4 100644 --- a/include/hw/scsi/scsi.h +++ b/include/hw/scsi/scsi.h @@ -187,7 +187,6 @@ SCSIDevice *scsi_bus_legacy_add_drive(SCSIBus *bus, BlockBackend *blk, BlockdevOnError werror, const char *serial, Error **errp); void scsi_bus_legacy_handle_cmdline(SCSIBus *bus); -void scsi_legacy_handle_cmdline(void); SCSIRequest *scsi_req_alloc(const SCSIReqOps *reqops, SCSIDevice *d, uint32_t tag, uint32_t lun, void *hba_private);
In commit 1454509726719e0933c80 we removed the function scsi_legacy_handle_cmdline() and all of its callers, but forgot to delete the prototype from the header function. Delete the prototype too. Signed-off-by: Peter Maydell <peter.maydell@linaro.org> --- include/hw/scsi/scsi.h | 1 - 1 file changed, 1 deletion(-)