| Message ID | 20221015004654.3930122-1-swboyd@chromium.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] soc: qcom: cmd-db: Mark device as having no PM support | expand |
On 15.10.2022 02:46, Stephen Boyd wrote: > This driver purely exposes information from memory to the kernel. Let's > mark it as not having any device PM functionality, so that during > suspend we skip even trying to call a suspend function on this device. > This clears up suspend logs more than anything else, but it also shaves > a few cycles off suspend. > > Cc: Konrad Dybcio <konrad.dybcio@somainline.org> > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@somainline.org> Konrad > drivers/soc/qcom/cmd-db.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c > index 629a7188b576..33856abd560c 100644 > --- a/drivers/soc/qcom/cmd-db.c > +++ b/drivers/soc/qcom/cmd-db.c > @@ -338,6 +338,8 @@ static int cmd_db_dev_probe(struct platform_device *pdev) > > debugfs_create_file("cmd-db", 0400, NULL, NULL, &cmd_db_debugfs_ops); > > + device_set_pm_not_required(&pdev->dev); > + > return 0; > } > > > base-commit: 4fe89d07dcc2804c8b562f6c7896a45643d34b2f
diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c index 629a7188b576..33856abd560c 100644 --- a/drivers/soc/qcom/cmd-db.c +++ b/drivers/soc/qcom/cmd-db.c @@ -338,6 +338,8 @@ static int cmd_db_dev_probe(struct platform_device *pdev) debugfs_create_file("cmd-db", 0400, NULL, NULL, &cmd_db_debugfs_ops); + device_set_pm_not_required(&pdev->dev); + return 0; }
This driver purely exposes information from memory to the kernel. Let's mark it as not having any device PM functionality, so that during suspend we skip even trying to call a suspend function on this device. This clears up suspend logs more than anything else, but it also shaves a few cycles off suspend. Cc: Konrad Dybcio <konrad.dybcio@somainline.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> --- drivers/soc/qcom/cmd-db.c | 2 ++ 1 file changed, 2 insertions(+) base-commit: 4fe89d07dcc2804c8b562f6c7896a45643d34b2f