diff mbox series

ACPI: PCI: Fix device reference counting in acpi_get_pci_dev()

Message ID 12097002.O9o76ZdvQC@kreacher
State New
Headers show
Series ACPI: PCI: Fix device reference counting in acpi_get_pci_dev() | expand

Commit Message

Rafael J. Wysocki Oct. 18, 2022, 5:34 p.m. UTC 
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

Commit 63f534b8bad9 ("ACPI: PCI: Rework acpi_get_pci_dev()") failed
to reference count the device returned by acpi_get_pci_dev() as
expected by its callers which in some cases may cause device objects
to be dropped prematurely.

Add the missing get_device() to acpi_get_pci_dev().

Fixes: 63f534b8bad9 ("ACPI: PCI: Rework acpi_get_pci_dev()")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
 drivers/acpi/pci_root.c |    1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

Index: linux-pm/drivers/acpi/pci_root.c
===================================================================
--- linux-pm.orig/drivers/acpi/pci_root.c
+++ linux-pm/drivers/acpi/pci_root.c
@@ -323,6 +323,7 @@  struct pci_dev *acpi_get_pci_dev(acpi_ha
 
 	list_for_each_entry(pn, &adev->physical_node_list, node) {
 		if (dev_is_pci(pn->dev)) {
+			get_device(pn->dev);
 			pci_dev = to_pci_dev(pn->dev);
 			break;
 		}