| Message ID | 20221017142007.5408-3-mengqi.zhang@mediatek.com |
|---|---|
| State | New |
| Headers | show |
| Series | MediaTek eMMC inline encryption support | expand |
Il 17/10/22 16:20, Mengqi Zhang ha scritto: > Document the binding for crypto clock of the Inline Crypto Engine > of Mediatek SoCs. > > Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com> Looks good, but please fix the typo in the commit title. Regards, Angelo
On 17/10/2022 10:20, Mengqi Zhang wrote: > Document the binding for crypto clock of the Inline Crypto Engine > of Mediatek SoCs. This does not match the patch contents at all. > > Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com> > --- > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++ > 1 file changed, 2 insertions(+) Best regards, Krzysztof
On 18/10/2022 14:29, Krzysztof Kozlowski wrote: > On 17/10/2022 10:20, Mengqi Zhang wrote: >> Document the binding for crypto clock of the Inline Crypto Engine >> of Mediatek SoCs. > > This does not match the patch contents at all. Ah, my bad, I read "crypto block", not clock, so it matches. :) However you are not documenting a binding for it. You are adding optional clock. > >> >> Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com> >> --- >> Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++ >> 1 file changed, 2 insertions(+) > > Best regards, > Krzysztof > Best regards, Krzysztof
On Mon, 17 Oct 2022 at 16:20, Mengqi Zhang <mengqi.zhang@mediatek.com> wrote: > > Document the binding for crypto clock of the Inline Crypto Engine > of Mediatek SoCs. > > Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com> > --- > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > index d8e1e2e9adf2..f93d686e2911 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > @@ -57,6 +57,7 @@ properties: > - description: peripheral bus clock gate (required for MT8192). > - description: AXI bus clock gate (required for MT8192). > - description: AHB bus clock gate (required for MT8192). > + - description: crypto clock used for data encrypt/decrypt (optional). > > clock-names: > minItems: 2 > @@ -69,6 +70,7 @@ properties: > - const: pclk_cg > - const: axi_cg > - const: ahb_cg > + - const: crypto Looks like minItems/maxItems for clocks needs to be updated too. > > interrupts: > description: > -- > 2.25.1 > Kind regards Uffe
On Tue, 2022-10-18 at 11:50 +0200, AngeloGioacchino Del Regno wrote: > Il 17/10/22 16:20, Mengqi Zhang ha scritto: > > Document the binding for crypto clock of the Inline Crypto Engine > > of Mediatek SoCs. > > > > Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com> > > Looks good, but please fix the typo in the commit title. > > Regards, > Angelo > Hi Angelo, I have re-sent my patch base on new code base. https://lore.kernel.org/linux-mmc/20221106033924.9854-3-mengqi.zhang@mediatek.com/ Please help to review. Thanks! Regards, Mengqi
On Wed, 2022-11-02 at 16:13 +0100, Ulf Hansson wrote: > On Mon, 17 Oct 2022 at 16:20, Mengqi Zhang <mengqi.zhang@mediatek.com > > wrote: > > > > Document the binding for crypto clock of the Inline Crypto Engine > > of Mediatek SoCs. > > > > Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com> > > --- > > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > index d8e1e2e9adf2..f93d686e2911 100644 > > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > > @@ -57,6 +57,7 @@ properties: > > - description: peripheral bus clock gate (required for > > MT8192). > > - description: AXI bus clock gate (required for MT8192). > > - description: AHB bus clock gate (required for MT8192). > > + - description: crypto clock used for data encrypt/decrypt > > (optional). > > > > clock-names: > > minItems: 2 > > @@ -69,6 +70,7 @@ properties: > > - const: pclk_cg > > - const: axi_cg > > - const: ahb_cg > > + - const: crypto > > Looks like minItems/maxItems for clocks needs to be updated too. > > > > > interrupts: > > description: > > -- > > 2.25.1 > > > > Kind regards > Uffe Hi Uffe, I just add crypto clock to mt8186/mt8188/mt8195, does not exceed the minItems/maxItems. I have re-sent my patch, https://lore.kernel.org/linux-mmc/20221106033924.9854-3-mengqi.zhang@mediatek.com/ Please help to review it. Thanks! Regards, Mengqi
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml index d8e1e2e9adf2..f93d686e2911 100644 --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml @@ -57,6 +57,7 @@ properties: - description: peripheral bus clock gate (required for MT8192). - description: AXI bus clock gate (required for MT8192). - description: AHB bus clock gate (required for MT8192). + - description: crypto clock used for data encrypt/decrypt (optional). clock-names: minItems: 2 @@ -69,6 +70,7 @@ properties: - const: pclk_cg - const: axi_cg - const: ahb_cg + - const: crypto interrupts: description:
Document the binding for crypto clock of the Inline Crypto Engine of Mediatek SoCs. Signed-off-by: Mengqi Zhang <mengqi.zhang@mediatek.com> --- Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 2 ++ 1 file changed, 2 insertions(+)