diff mbox series

[v3,15/26] MAINTAINERS: add entries for the key build bits

Message ID 20221020115209.1761864-16-alex.bennee@linaro.org
State New
Headers show
Series testing/next (docker, avocado, s390x, MAINTAINERS) | expand

Commit Message

Alex Bennée Oct. 20, 2022, 11:51 a.m. UTC
Changes to the build files are a bit special in that they usually go
through other maintainer trees. However considering the build system
is the root of everything a developer is likely to do we should at
least set it out in MAINTAINERS.

I'm going to nominate Paolo for meson stuff given the conversion was
his passion project. I'm happy to cast an eye over configure stuff
considering a lot of the cross compile logic is in there anyway.

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>

---
v2
  - s/Odd Fixes/Maintained/
  - nominate more reviewers
---
 MAINTAINERS | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

Comments

Philippe Mathieu-Daudé Oct. 20, 2022, 4:01 p.m. UTC | #1
On 20/10/22 13:51, Alex Bennée wrote:
> Changes to the build files are a bit special in that they usually go
> through other maintainer trees. However considering the build system
> is the root of everything a developer is likely to do we should at
> least set it out in MAINTAINERS.
> 
> I'm going to nominate Paolo for meson stuff given the conversion was
> his passion project. I'm happy to cast an eye over configure stuff
> considering a lot of the cross compile logic is in there anyway.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> 
> ---
> v2
>    - s/Odd Fixes/Maintained/
>    - nominate more reviewers
> ---
>   MAINTAINERS | 24 ++++++++++++++++++++++++
>   1 file changed, 24 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e3d5b7e09c..6a6f4d62bd 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3764,6 +3764,30 @@ F: docs/about/deprecated.rst
>   
>   Build System
>   ------------
> +Meson
> +M: Paolo Bonzini <pbonzini@redhat.com>
> +R: Marc-André Lureau <marcandre.lureau@redhat.com>
> +R: Daniel P. Berrange <berrange@redhat.com>
> +R: Thomas Huth <thuth@redhat.com>
> +R: Philippe Mathieu-Daudé <philmd@linaro.org>

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

> +S: Maintained
> +F: meson.build
> +F: meson_options.txt
> +F: scripts/meson-buildoptions.*
> +F: scripts/check_sparse.py
> +F: scripts/entitlement.sh
> +F: scripts/symlink-install-tree.py
> +F: scripts/nsis.py
Thomas Huth Oct. 27, 2022, 4:02 p.m. UTC | #2
On 20/10/2022 13.51, Alex Bennée wrote:
> Changes to the build files are a bit special in that they usually go
> through other maintainer trees. However considering the build system
> is the root of everything a developer is likely to do we should at
> least set it out in MAINTAINERS.
> 
> I'm going to nominate Paolo for meson stuff given the conversion was
> his passion project. I'm happy to cast an eye over configure stuff
> considering a lot of the cross compile logic is in there anyway.
> 
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> 
> ---
> v2
>    - s/Odd Fixes/Maintained/
>    - nominate more reviewers
> ---
>   MAINTAINERS | 24 ++++++++++++++++++++++++
>   1 file changed, 24 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e3d5b7e09c..6a6f4d62bd 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3764,6 +3764,30 @@ F: docs/about/deprecated.rst
>   
>   Build System
>   ------------
> +Meson
> +M: Paolo Bonzini <pbonzini@redhat.com>
> +R: Marc-André Lureau <marcandre.lureau@redhat.com>
> +R: Daniel P. Berrange <berrange@redhat.com>
> +R: Thomas Huth <thuth@redhat.com>
> +R: Philippe Mathieu-Daudé <philmd@linaro.org>
> +S: Maintained
> +F: meson.build
> +F: meson_options.txt
> +F: scripts/meson-buildoptions.*
> +F: scripts/check_sparse.py
> +F: scripts/entitlement.sh

Shouldn't entitlement.sh rather be part of the Darwin/macOS section?

> +F: scripts/symlink-install-tree.py
> +F: scripts/nsis.py

Shouldn't nsis.py rather be part of the W32/W64 section?

> +
> +TL Makefile and configure

TL = Top Level? ... I'd maybe rather would not abbreviate it...

> +M: Paolo Bonzini <pbonzini@redhat.com>
> +R: Alex Bennée <alex.bennee@linaro.org>
> +S: Maintained
> +F: Makefile
> +F: configure
> +F: scripts/mtest2make.py
> +F: tests/Makefile.include

Feel free to add a R: line for me here, too.

Anyway,
Acked-by: Thomas Huth <thuth@redhat.com>
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index e3d5b7e09c..6a6f4d62bd 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3764,6 +3764,30 @@  F: docs/about/deprecated.rst
 
 Build System
 ------------
+Meson
+M: Paolo Bonzini <pbonzini@redhat.com>
+R: Marc-André Lureau <marcandre.lureau@redhat.com>
+R: Daniel P. Berrange <berrange@redhat.com>
+R: Thomas Huth <thuth@redhat.com>
+R: Philippe Mathieu-Daudé <philmd@linaro.org>
+S: Maintained
+F: meson.build
+F: meson_options.txt
+F: scripts/meson-buildoptions.*
+F: scripts/check_sparse.py
+F: scripts/entitlement.sh
+F: scripts/symlink-install-tree.py
+F: scripts/nsis.py
+
+TL Makefile and configure
+M: Paolo Bonzini <pbonzini@redhat.com>
+R: Alex Bennée <alex.bennee@linaro.org>
+S: Maintained
+F: Makefile
+F: configure
+F: scripts/mtest2make.py
+F: tests/Makefile.include
+
 GIT submodules
 M: Daniel P. Berrange <berrange@redhat.com>
 S: Odd Fixes