| Message ID | 20221022090530.16265-6-linux@fw-web.de |
|---|---|
| State | New |
| Headers | show |
| Series | Add mmc-support for mt7986 | expand |
On 22/10/2022 05:05, Frank Wunderlich wrote: > From: Frank Wunderlich <frank-w@public-files.de> > > Add SoC specific section for defining clock configuration. > > Add compatible in "not" section to avoid override the settings again. > > Signed-off-by: Frank Wunderlich <frank-w@public-files.de> > --- > .../devicetree/bindings/mmc/mtk-sd.yaml | 28 +++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > index c7bcf0c3dd5d..9df63c461f1f 100644 > --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml > @@ -229,6 +229,33 @@ allOf: > - const: hclk > - const: source_cg > - const: bus_clk Blank line > + - if: > + properties: > + compatible: > + contains: > + enum: > + - mediatek,mt7986-mmc > + then: > + properties: > + assigned-clock-parents: > + maxItems: 2 > + assigned-clocks: > + maxItems: 2 Define these two only if they are required for the hardware to operate and only such setup (two assigned parents) is allowed. Otherwise you put some constraints on board design. > + clocks: > + minItems: 3 Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml index c7bcf0c3dd5d..9df63c461f1f 100644 --- a/Documentation/devicetree/bindings/mmc/mtk-sd.yaml +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml @@ -229,6 +229,33 @@ allOf: - const: hclk - const: source_cg - const: bus_clk + - if: + properties: + compatible: + contains: + enum: + - mediatek,mt7986-mmc + then: + properties: + assigned-clock-parents: + maxItems: 2 + assigned-clocks: + maxItems: 2 + clocks: + minItems: 3 + items: + - description: source clock + - description: HCLK which used for host + - description: independent source clock gate + - description: bus clock used for internal register access + - description: msdc subsys clock gate + clock-names: + minItems: 3 + items: + - const: source + - const: hclk + - const: axi_cg + - const: ahb_cg - if: not: properties: @@ -237,6 +264,7 @@ allOf: enum: - mediatek,mt2712-mmc - mediatek,mt8192-mmc + - mediatek,mt7986-mmc then: properties: clocks: