| Message ID | 20221026190549.4005703-2-quic_molvera@quicinc.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add misc support for QDU1000/QRU1000 SoCs | expand |
On 26/10/2022 15:05, Melody Olvera wrote: > Add compatibles for scm driver for QDU1000 and QRU1000 platforms. > > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> > --- > .../devicetree/bindings/firmware/qcom,scm.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > index be1b5746eddb..5352181aa393 100644 > --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > @@ -38,6 +38,7 @@ properties: > - qcom,scm-msm8994 > - qcom,scm-msm8996 > - qcom,scm-msm8998 > + - qcom,scm-qdu1000 > - qcom,scm-sc7180 > - qcom,scm-sc7280 > - qcom,scm-sc8280xp > @@ -81,6 +82,20 @@ properties: > description: TCSR hardware block > > allOf: > + - if: > + properties: > + compatible: > + contains: > + const: qcom,scm-qdu1000 > + then: > + properties: > + '#reset-cells': > + maxItems: 1 This is wrong... how can you have here more items? > + clocks: false > + clock-names: false > + > + required: > + - '#reset-cells' Missing blank line. > - if: > properties: > compatible: Best regards, Krzysztof
On Wed, Oct 26, 2022 at 12:05:45PM -0700, Melody Olvera wrote: > Add compatibles for scm driver for QDU1000 and QRU1000 platforms. > > Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> > --- > .../devicetree/bindings/firmware/qcom,scm.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > index be1b5746eddb..5352181aa393 100644 > --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml > @@ -38,6 +38,7 @@ properties: > - qcom,scm-msm8994 > - qcom,scm-msm8996 > - qcom,scm-msm8998 > + - qcom,scm-qdu1000 > - qcom,scm-sc7180 > - qcom,scm-sc7280 > - qcom,scm-sc8280xp > @@ -81,6 +82,20 @@ properties: > description: TCSR hardware block > > allOf: > + - if: > + properties: > + compatible: > + contains: > + const: qcom,scm-qdu1000 > + then: > + properties: > + '#reset-cells': > + maxItems: 1 > + clocks: false > + clock-names: false > + > + required: > + - '#reset-cells' Please document what this reset is expected to be wired to, and write a sentence or two in the commit message how the QDU differs from existing platforms supported by the binding. Thanks, Bjorn > - if: > properties: > compatible: > -- > 2.25.1 >
On 11/7/2022 9:38 AM, Bjorn Andersson wrote: > On Wed, Oct 26, 2022 at 12:05:45PM -0700, Melody Olvera wrote: >> Add compatibles for scm driver for QDU1000 and QRU1000 platforms. >> >> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> >> --- >> .../devicetree/bindings/firmware/qcom,scm.yaml | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> index be1b5746eddb..5352181aa393 100644 >> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> @@ -38,6 +38,7 @@ properties: >> - qcom,scm-msm8994 >> - qcom,scm-msm8996 >> - qcom,scm-msm8998 >> + - qcom,scm-qdu1000 >> - qcom,scm-sc7180 >> - qcom,scm-sc7280 >> - qcom,scm-sc8280xp >> @@ -81,6 +82,20 @@ properties: >> description: TCSR hardware block >> >> allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: qcom,scm-qdu1000 >> + then: >> + properties: >> + '#reset-cells': >> + maxItems: 1 >> + clocks: false >> + clock-names: false >> + >> + required: >> + - '#reset-cells' > Please document what this reset is expected to be wired to, and write a > sentence or two in the commit message how the QDU differs from existing > platforms supported by the binding. > Honestly, I can't remember what this is here for. Will remove from here and DT. Will also add a quick blurb about not needing clocks. Thanks, Melody > >> - if: >> properties: >> compatible: >> -- >> 2.25.1 >>
On 10/27/2022 8:24 AM, Krzysztof Kozlowski wrote: > On 26/10/2022 15:05, Melody Olvera wrote: >> Add compatibles for scm driver for QDU1000 and QRU1000 platforms. >> >> Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> >> --- >> .../devicetree/bindings/firmware/qcom,scm.yaml | 15 +++++++++++++++ >> 1 file changed, 15 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> index be1b5746eddb..5352181aa393 100644 >> --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml >> @@ -38,6 +38,7 @@ properties: >> - qcom,scm-msm8994 >> - qcom,scm-msm8996 >> - qcom,scm-msm8998 >> + - qcom,scm-qdu1000 >> - qcom,scm-sc7180 >> - qcom,scm-sc7280 >> - qcom,scm-sc8280xp >> @@ -81,6 +82,20 @@ properties: >> description: TCSR hardware block >> >> allOf: >> + - if: >> + properties: >> + compatible: >> + contains: >> + const: qcom,scm-qdu1000 >> + then: >> + properties: >> + '#reset-cells': >> + maxItems: 1 > This is wrong... how can you have here more items? Being removed anyways. > >> + clocks: false >> + clock-names: false >> + >> + required: >> + - '#reset-cells' > Missing blank line. Ack. Thanks, Melody > >> - if: >> properties: >> compatible: > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml index be1b5746eddb..5352181aa393 100644 --- a/Documentation/devicetree/bindings/firmware/qcom,scm.yaml +++ b/Documentation/devicetree/bindings/firmware/qcom,scm.yaml @@ -38,6 +38,7 @@ properties: - qcom,scm-msm8994 - qcom,scm-msm8996 - qcom,scm-msm8998 + - qcom,scm-qdu1000 - qcom,scm-sc7180 - qcom,scm-sc7280 - qcom,scm-sc8280xp @@ -81,6 +82,20 @@ properties: description: TCSR hardware block allOf: + - if: + properties: + compatible: + contains: + const: qcom,scm-qdu1000 + then: + properties: + '#reset-cells': + maxItems: 1 + clocks: false + clock-names: false + + required: + - '#reset-cells' - if: properties: compatible:
Add compatibles for scm driver for QDU1000 and QRU1000 platforms. Signed-off-by: Melody Olvera <quic_molvera@quicinc.com> --- .../devicetree/bindings/firmware/qcom,scm.yaml | 15 +++++++++++++++ 1 file changed, 15 insertions(+)