| Message ID | 20221027-b4-spicc-burst-delay-fix-v1-0-5a6e9a88e54c@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | spi: meson-spicc: fix do_div build error on non-arm64 | expand |
On Thu, Oct 27, 2022 at 2:11 PM Neil Armstrong <neil.armstrong@linaro.org> wrote: > > This fixes : > error: passing argument 1 of '__div64_32' from incompatible pointer type > > By passing an uint64_t as first variable to do_div(). > > Fixes: 04694e50020b ("spi: meson-spicc: move wait completion in driver to take bursts delay in account") > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> and also: Reported-by: kernel test robot <lkp@intel.com>
On 01/11/2022 20:13, Martin Blumenstingl wrote: > On Thu, Oct 27, 2022 at 2:11 PM Neil Armstrong > <neil.armstrong@linaro.org> wrote: >> >> This fixes : >> error: passing argument 1 of '__div64_32' from incompatible pointer type >> >> By passing an uint64_t as first variable to do_div(). >> >> Fixes: 04694e50020b ("spi: meson-spicc: move wait completion in driver to take bursts delay in account") >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> > Acked-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > and also: > Reported-by: kernel test robot <lkp@intel.com> Thanks, Seems To: Mark is somehow missing, will resend with it. Neil
diff --git a/drivers/spi/spi-meson-spicc.c b/drivers/spi/spi-meson-spicc.c index 52bffab18329..1b4195c54ee2 100644 --- a/drivers/spi/spi-meson-spicc.c +++ b/drivers/spi/spi-meson-spicc.c @@ -387,7 +387,7 @@ static int meson_spicc_transfer_one(struct spi_master *master, struct spi_transfer *xfer) { struct meson_spicc_device *spicc = spi_master_get_devdata(master); - unsigned long timeout; + uint64_t timeout; /* Store current transfer */ spicc->xfer = xfer;
This fixes : error: passing argument 1 of '__div64_32' from incompatible pointer type By passing an uint64_t as first variable to do_div(). Fixes: 04694e50020b ("spi: meson-spicc: move wait completion in driver to take bursts delay in account") Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> --- To: Neil Armstrong <narmstrong@baylibre.com> To: Kevin Hilman <khilman@baylibre.com> To: Jerome Brunet <jbrunet@baylibre.com> To: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Cc: linux-spi@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org Cc: linux-amlogic@lists.infradead.org Cc: linux-kernel@vger.kernel.org --- drivers/spi/spi-meson-spicc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 574f97ab96d6b153407161746bc127564e998b4f change-id: 20221027-b4-spicc-burst-delay-fix-a03004454876 Best regards,