diff mbox series

[PULL,50/55] hw/isa/piix4: Add missing initialization

Message ID	20221030222841.42377-51-philmd@linaro.org
State	Accepted
Commit	a1c100d0fbdcee230341262c3874513ce70ff38f
Headers	show Delivered-To: patch@linaro.org Received-SPF: pass (google.com: domain of qemu-devel-bounces+patch=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; From: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org> To: qemu-devel@nongnu.org Cc: =?utf-8?q?Philippe_Mathieu-Daud=C3=A9?= <philmd@linaro.org>, Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>, Huacai Chen <chenhuacai@kernel.org>, Stefan Pejic <stefan.pejic@syrmia.com>, Jiaxun Yang <jiaxun.yang@flygoat.com>, Aurelien Jarno <aurelien@aurel32.net>, Paul Burton <paulburton@kernel.org>, Bernhard Beschow <shentey@gmail.com> Subject: [PULL 50/55] hw/isa/piix4: Add missing initialization Date: Sun, 30 Oct 2022 23:28:36 +0100 Message-Id: <20221030222841.42377-51-philmd@linaro.org> In-Reply-To: <20221030222841.42377-1-philmd@linaro.org> References: <20221030222841.42377-1-philmd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42f; envelope-from=philmd@linaro.org; helo=mail-wr1-x42f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action Precedence: list Sender: "Qemu-devel" <qemu-devel-bounces@nongnu.org> Errors-To: qemu-devel-bounces+patch=linaro.org@nongnu.org
Series	[PULL,01/55] hw/isa/vt82c686: Resolve chip-specific realize methods \| expand [PULL,01/55] hw/isa/vt82c686: Resolve chip-specific realize methods [PULL,02/55] hw/isa/vt82c686: Resolve unneeded attribute [PULL,03/55] hw/isa/vt82c686: Prefer pci_address_space() over get_system_memory() [PULL,04/55] hw/isa/vt82c686: Reuse errp [PULL,05/55] hw/isa/vt82c686: Introduce TYPE_VIA_IDE define [PULL,06/55] hw/isa/vt82c686: Instantiate IDE function in host device [PULL,07/55] hw/isa/vt82c686: Introduce TYPE_VT82C686B_USB_UHCI define [PULL,08/55] hw/isa/vt82c686: Instantiate USB functions in host device [PULL,09/55] hw/isa/vt82c686: Instantiate PM function in host device [PULL,10/55] hw/isa/vt82c686: Instantiate AC97 and MC97 functions in host device [PULL,11/55] hw/mips/fuloong2e: Inline vt82c686b_southbridge_init() and remove it [PULL,12/55] hw/isa/vt82c686: Embed RTCState in host device [PULL,13/55] hw/isa/vt82c686: Create rtc-time alias in boards instead [PULL,14/55] hw: Remove unused MAX_IDE_BUS define [PULL,15/55] disas/nanomips: Remove namespace img [PULL,16/55] disas/nanomips: Extract enums out of the NMD class [PULL,17/55] disas/nanomips: Delete NMD class field [PULL,18/55] disas/nanomips: Delete NMD class second field [PULL,19/55] disas/nanomips: Remove helper methods from class [PULL,20/55] disas/nanomips: Remove __cond methods from class [PULL,21/55] disas/nanomips: Remove disasm methods from class [PULL,22/55] disas/nanomips: Remove Pool tables from the class [PULL,23/55] disas/nanomips: Remove NMD class [PULL,24/55] disas/nanomips: Move typedefs etc to nanomips.cpp [PULL,25/55] disas/nanomips: Delete nanomips.h [PULL,26/55] disas/nanomips: Remove #include <sstream> [PULL,27/55] disas/nanomips: Delete copy functions [PULL,28/55] disas/nanomips: Delete wrapper functions [PULL,29/55] disas/nanomips: Replace std::string type [PULL,30/55] disas/nanomips: Remove IMMEDIATE functions [PULL,31/55] disas/nanomips: Remove CPR function [PULL,32/55] disas/nanomips: Prevent memory leaking [PULL,33/55] disas/nanomips: Remove function overloading [PULL,34/55] disas/nanomips: Expand Dis_info struct [PULL,35/55] disas/nanomips: Replace exception handling [PULL,36/55] disas/nanomips: Replace Cpp enums for C enums [PULL,37/55] disas/nanomips: Remove argument passing by ref [PULL,38/55] disas/nanomips: Rename nanomips.cpp to nanomips.c [PULL,39/55] disas/mips: Fix branch displacement for BEQZC and BNEZC [PULL,40/55] hw/i386/pc: Create DMA controllers in south bridges [PULL,41/55] hw/isa/piix3: Remove extra ';' outside of functions [PULL,42/55] hw/isa/piix3: Add size constraints to rcr_ops [PULL,43/55] hw/isa/piix3: Modernize reset handling [PULL,44/55] hw/isa/piix3: Prefer pci_address_space() over get_system_memory() [PULL,45/55] hw/isa/piix4: Rename wrongly named method [PULL,46/55] hw/ide/piix: Introduce TYPE_ macros for PIIX IDE controllers [PULL,47/55] hw/isa/piix3: Remove unused include [PULL,48/55] hw/mips/malta: Reuse dev variable [PULL,49/55] hw/isa/Kconfig: Fix dependencies of piix4 southbridge [PULL,50/55] hw/isa/piix4: Add missing initialization [PULL,51/55] hw/isa/piix4: Move pci_ide_create_devs() call to board code [PULL,52/55] hw/mips/boston: Don't set link_up for xilinx-pcie

Commit Message

Philippe Mathieu-Daudé Oct. 30, 2022, 10:28 p.m. UTC

From: Bernhard Beschow <shentey@gmail.com>

PIIX3 clears its reset control register, so do the same in PIIX4.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
Message-Id: <20221022150508.26830-28-shentey@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
 hw/isa/piix4.c | 2 ++
 1 file changed, 2 insertions(+)

diff mbox series

Patch

diff --git a/hw/isa/piix4.c b/hw/isa/piix4.c
index e05e65d3bc..9126eb9edf 100644
--- a/hw/isa/piix4.c
+++ b/hw/isa/piix4.c
@@ -140,6 +140,8 @@  static void piix4_isa_reset(DeviceState *dev)
     pci_conf[0xab] = 0x00;
     pci_conf[0xac] = 0x00;
     pci_conf[0xae] = 0x00;
+
+    d->rcr = 0;
 }
 
 static int piix4_post_load(void *opaque, int version_id)