| Message ID | 20221102152915.22995-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v1,1/2] pinctrl: intel: Use temporary variable for struct device | expand |
Hi, On Wed, Nov 02, 2022 at 05:29:14PM +0200, Andy Shevchenko wrote: > Use temporary variable for struct device to make code neater. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > --- > drivers/pinctrl/intel/pinctrl-intel.c | 23 ++++++++++++----------- > 1 file changed, 12 insertions(+), 11 deletions(-) > > diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c > index fe5bf2184cbf..e15629348cb5 100644 > --- a/drivers/pinctrl/intel/pinctrl-intel.c > +++ b/drivers/pinctrl/intel/pinctrl-intel.c > @@ -1522,14 +1522,15 @@ static int intel_pinctrl_probe_pwm(struct intel_pinctrl *pctrl, > int intel_pinctrl_probe(struct platform_device *pdev, > const struct intel_pinctrl_soc_data *soc_data) > { > + struct device *dev = &pdev->dev; > struct intel_pinctrl *pctrl; > int i, ret, irq; > > - pctrl = devm_kzalloc(&pdev->dev, sizeof(*pctrl), GFP_KERNEL); > + pctrl = devm_kzalloc(dev, sizeof(*pctrl), GFP_KERNEL); IMHO &pdev->dev is neater and saves an extra line. I would agree if this would be something like &foo->bar->baz->dev but it is not. Anyway, no feelings about this so feel free to add, Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> for both patches.
On Thu, Nov 3, 2022 at 9:26 AM Mika Westerberg <mika.westerberg@linux.intel.com> wrote: > On Wed, Nov 02, 2022 at 05:29:14PM +0200, Andy Shevchenko wrote: > > Use temporary variable for struct device to make code neater. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > --- > > drivers/pinctrl/intel/pinctrl-intel.c | 23 ++++++++++++----------- > > 1 file changed, 12 insertions(+), 11 deletions(-) > > > > diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c > > index fe5bf2184cbf..e15629348cb5 100644 > > --- a/drivers/pinctrl/intel/pinctrl-intel.c > > +++ b/drivers/pinctrl/intel/pinctrl-intel.c > > @@ -1522,14 +1522,15 @@ static int intel_pinctrl_probe_pwm(struct intel_pinctrl *pctrl, > > int intel_pinctrl_probe(struct platform_device *pdev, > > const struct intel_pinctrl_soc_data *soc_data) > > { > > + struct device *dev = &pdev->dev; > > struct intel_pinctrl *pctrl; > > int i, ret, irq; > > > > - pctrl = devm_kzalloc(&pdev->dev, sizeof(*pctrl), GFP_KERNEL); > > + pctrl = devm_kzalloc(dev, sizeof(*pctrl), GFP_KERNEL); > > IMHO &pdev->dev is neater and saves an extra line. I would agree if this > would be something like &foo->bar->baz->dev but it is not. I have no strong opinion, but one thing which may play in favour of the patches is that all other drivers, that have their custom ->probe() implemented, are using temporary variable. That said, let's consider this as unification among Intel pin control drivers. > Anyway, no feelings about this so feel free to add, > > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > for both patches. Thank you!
On Thu, Nov 03, 2022 at 12:54:23PM +0200, Andy Shevchenko wrote: > On Thu, Nov 3, 2022 at 9:26 AM Mika Westerberg > <mika.westerberg@linux.intel.com> wrote: > > On Wed, Nov 02, 2022 at 05:29:14PM +0200, Andy Shevchenko wrote: ... > > Anyway, no feelings about this so feel free to add, > > > > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> > > > > for both patches. > > Thank you! Pushed to my review and testing queue, thank you!
diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c index fe5bf2184cbf..e15629348cb5 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1522,14 +1522,15 @@ static int intel_pinctrl_probe_pwm(struct intel_pinctrl *pctrl, int intel_pinctrl_probe(struct platform_device *pdev, const struct intel_pinctrl_soc_data *soc_data) { + struct device *dev = &pdev->dev; struct intel_pinctrl *pctrl; int i, ret, irq; - pctrl = devm_kzalloc(&pdev->dev, sizeof(*pctrl), GFP_KERNEL); + pctrl = devm_kzalloc(dev, sizeof(*pctrl), GFP_KERNEL); if (!pctrl) return -ENOMEM; - pctrl->dev = &pdev->dev; + pctrl->dev = dev; pctrl->soc = soc_data; raw_spin_lock_init(&pctrl->lock); @@ -1538,8 +1539,8 @@ int intel_pinctrl_probe(struct platform_device *pdev, * to the registers. */ pctrl->ncommunities = pctrl->soc->ncommunities; - pctrl->communities = devm_kcalloc(&pdev->dev, pctrl->ncommunities, - sizeof(*pctrl->communities), GFP_KERNEL); + pctrl->communities = devm_kcalloc(dev, pctrl->ncommunities, + sizeof(*pctrl->communities), GFP_KERNEL); if (!pctrl->communities) return -ENOMEM; @@ -1603,7 +1604,7 @@ int intel_pinctrl_probe(struct platform_device *pdev, offset = (value & CAPLIST_NEXT_MASK) >> CAPLIST_NEXT_SHIFT; } while (offset); - dev_dbg(&pdev->dev, "Community%d features: %#08x\n", i, community->features); + dev_dbg(dev, "Community%d features: %#08x\n", i, community->features); /* Read offset of the pad configuration registers */ offset = readl(regs + PADBAR); @@ -1632,14 +1633,13 @@ int intel_pinctrl_probe(struct platform_device *pdev, return ret; pctrl->pctldesc = intel_pinctrl_desc; - pctrl->pctldesc.name = dev_name(&pdev->dev); + pctrl->pctldesc.name = dev_name(dev); pctrl->pctldesc.pins = pctrl->soc->pins; pctrl->pctldesc.npins = pctrl->soc->npins; - pctrl->pctldev = devm_pinctrl_register(&pdev->dev, &pctrl->pctldesc, - pctrl); + pctrl->pctldev = devm_pinctrl_register(dev, &pctrl->pctldesc, pctrl); if (IS_ERR(pctrl->pctldev)) { - dev_err(&pdev->dev, "failed to register pinctrl driver\n"); + dev_err(dev, "failed to register pinctrl driver\n"); return PTR_ERR(pctrl->pctldev); } @@ -1681,10 +1681,11 @@ const struct intel_pinctrl_soc_data *intel_pinctrl_get_soc_data(struct platform_ { const struct intel_pinctrl_soc_data * const *table; const struct intel_pinctrl_soc_data *data = NULL; + struct device *dev = &pdev->dev; - table = device_get_match_data(&pdev->dev); + table = device_get_match_data(dev); if (table) { - struct acpi_device *adev = ACPI_COMPANION(&pdev->dev); + struct acpi_device *adev = ACPI_COMPANION(dev); unsigned int i; for (i = 0; table[i]; i++) {
Use temporary variable for struct device to make code neater. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/pinctrl/intel/pinctrl-intel.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-)