diff mbox

[API-NEXT,1/4] api: crypto: add odp_crypto_capability() api

Message ID 1455737843-4588-1-git-send-email-bill.fischofer@linaro.org
State Superseded
Headers show

Commit Message

Bill Fischofer Feb. 17, 2016, 7:37 p.m. UTC
Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org>
---
 include/odp/api/spec/crypto.h | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Comments

Balasubramanian Manoharan Feb. 18, 2016, 5:10 a.m. UTC | #1
For the series:
Reviewed-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>


Regards,
Bala

On 18 February 2016 at 01:07, Bill Fischofer <bill.fischofer@linaro.org>
wrote:

> Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org>

> ---

>  include/odp/api/spec/crypto.h | 18 ++++++++++++++++++

>  1 file changed, 18 insertions(+)

>

> diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h

> index 41beedb..eaacff1 100644

> --- a/include/odp/api/spec/crypto.h

> +++ b/include/odp/api/spec/crypto.h

> @@ -254,6 +254,24 @@ typedef struct odp_crypto_op_result {

>  } odp_crypto_op_result_t;

>

>  /**

> + * Crypto capabilities

> + */

> +typedef struct odp_crypto_capability_t {

> +       /** Maximum number of sessions */

> +       unsigned max_sessions;

> +} odp_crypto_capability_t;

> +

> +/**

> + * Get crypto capabilities

> + *

> + * @param[out] capability Pointer to capability structrue for output

> + *

> + * @retval 0 on success

> + * @retval <0 on failure

> + */

> +int odp_crypto_capability(odp_crypto_capability_t *capability);

> +

> +/**

>   * Crypto session creation (synchronous)

>   *

>   * @param params            Session parameters

> --

> 2.5.0

>

> _______________________________________________

> lng-odp mailing list

> lng-odp@lists.linaro.org

> https://lists.linaro.org/mailman/listinfo/lng-odp

>
Bill Fischofer Feb. 18, 2016, 12:21 p.m. UTC | #2
Thanks, all.  v2 submitted to fix the typo Petri noted.

On Thu, Feb 18, 2016 at 5:23 AM, Savolainen, Petri (Nokia - FI/Espoo) <
petri.savolainen@nokia.com> wrote:

> Yes that’s the idea, but those can be added later on top of this initial

> definition.

>

>

>

> We’d need to decide, if capability struct lists algos supported OR algos

> supported on HW (and demand that everything is always implemented either in

> SW or HW). Maybe it makes sense to allow low end or domain targeted

> implementations (which would not implement all algos) – and thus list algos

> supported.

>

>

>

> -Petri

>

>

>

>

>

> *From:* lng-odp [mailto:lng-odp-bounces@lists.linaro.org] *On Behalf Of *EXT

> Nikhil Agarwal

> *Sent:* Thursday, February 18, 2016 12:09 PM

> *To:* Bala Manoharan <bala.manoharan@linaro.org>; Bill Fischofer <

> bill.fischofer@linaro.org>

>

> *Cc:* LNG ODP Mailman List <lng-odp@lists.linaro.org>

> *Subject:* Re: [lng-odp] [API-NEXT PATCH 1/4] api: crypto: add

> odp_crypto_capability() api

>

>

>

> Shall supported algos be add in crypto capabilities?

>

>

>

> Regards

>

> Nikhil

>

>

>

> *From:* lng-odp [mailto:lng-odp-bounces@lists.linaro.org

> <lng-odp-bounces@lists.linaro.org>] *On Behalf Of *Bala Manoharan

> *Sent:* Thursday, February 18, 2016 10:40 AM

> *To:* Bill Fischofer <bill.fischofer@linaro.org>

> *Cc:* LNG ODP Mailman List <lng-odp@lists.linaro.org>

> *Subject:* Re: [lng-odp] [API-NEXT PATCH 1/4] api: crypto: add

> odp_crypto_capability() api

>

>

>

> For the series:

>

> Reviewed-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>

>

>

> Regards,

> Bala

>

>

>

> On 18 February 2016 at 01:07, Bill Fischofer <bill.fischofer@linaro.org>

> wrote:

>

> Signed-off-by: Bill Fischofer <bill.fischofer@linaro.org>

> ---

>  include/odp/api/spec/crypto.h | 18 ++++++++++++++++++

>  1 file changed, 18 insertions(+)

>

> diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h

> index 41beedb..eaacff1 100644

> --- a/include/odp/api/spec/crypto.h

> +++ b/include/odp/api/spec/crypto.h

> @@ -254,6 +254,24 @@ typedef struct odp_crypto_op_result {

>  } odp_crypto_op_result_t;

>

>  /**

> + * Crypto capabilities

> + */

> +typedef struct odp_crypto_capability_t {

> +       /** Maximum number of sessions */

> +       unsigned max_sessions;

> +} odp_crypto_capability_t;

> +

> +/**

> + * Get crypto capabilities

> + *

> + * @param[out] capability Pointer to capability structrue for output

> + *

> + * @retval 0 on success

> + * @retval <0 on failure

> + */

> +int odp_crypto_capability(odp_crypto_capability_t *capability);

> +

> +/**

>   * Crypto session creation (synchronous)

>   *

>   * @param params            Session parameters

> --

> 2.5.0

>

> _______________________________________________

> lng-odp mailing list

> lng-odp@lists.linaro.org

> https://lists.linaro.org/mailman/listinfo/lng-odp

>

>

>
diff mbox

Patch

diff --git a/include/odp/api/spec/crypto.h b/include/odp/api/spec/crypto.h
index 41beedb..eaacff1 100644
--- a/include/odp/api/spec/crypto.h
+++ b/include/odp/api/spec/crypto.h
@@ -254,6 +254,24 @@  typedef struct odp_crypto_op_result {
 } odp_crypto_op_result_t;
 
 /**
+ * Crypto capabilities
+ */
+typedef struct odp_crypto_capability_t {
+	/** Maximum number of sessions */
+	unsigned max_sessions;
+} odp_crypto_capability_t;
+
+/**
+ * Get crypto capabilities
+ *
+ * @param[out] capability Pointer to capability structrue for output
+ *
+ * @retval 0 on success
+ * @retval <0 on failure
+ */
+int odp_crypto_capability(odp_crypto_capability_t *capability);
+
+/**
  * Crypto session creation (synchronous)
  *
  * @param params            Session parameters