| Message ID | 20221107235654.1769462-4-bryan.odonoghue@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | mdss-dsi-ctrl binding and dts fixes | expand |
On 08/11/2022 02:56, Bryan O'Donoghue wrote: > When converting from .txt to .yaml we didn't include descriptions for the > existing regulator supplies. > > - vdd > - vdda > - vddio > > Add those descriptions into the yaml now as they were prior to the > conversion. Mark the supplies as required as was previously the case in the > .txt implementation. > > Warnings about missing regulators can be resolved by updating the relevant > dtsi files to point to fixed always-on regulators where appropriate. Ugh. Are they missing or are they optional/not used on these platforms? Can you possibly list all regulator warnings? > > Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") > Cc: Rob Clark <robdclark@gmail.com> > Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Sean Paul <sean@poorly.run> > Cc: David Airlie <airlied@gmail.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../bindings/display/msm/dsi-controller-main.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > index cf782c5f5bdb0..0f7747e55b9be 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > @@ -124,6 +124,18 @@ properties: > - port@0 > - port@1 > > + vdd-supply: > + description: > + Phandle to vdd regulator device node > + > + vddio-supply: > + description: > + Phandle to vdd-io regulator device node > + > + vdda-supply: > + description: > + Phandle to vdda regulator device node > + > required: > - compatible > - reg > @@ -135,6 +147,9 @@ required: > - assigned-clocks > - assigned-clock-parents > - ports > + - vdd-supply > + - vddio-supply > + - vdda-supply > > additionalProperties: false >
On 08/11/2022 12:59, Dmitry Baryshkov wrote: >> >> Warnings about missing regulators can be resolved by updating the >> relevant >> dtsi files to point to fixed always-on regulators where appropriate. > > Ugh. Are they missing or are they optional/not used on these platforms? Some platforms either don't implement them or worse possibly do implement but don't model them when they should. > Can you possibly list all regulator warnings? Downstream we have arch/arm/boot/dts/qcom/msm8916-mdss.dtsi mdss_dsi0: qcom,mdss_dsi@1a98000 { vdda-supply = <&pm8916_l2>; vdd-supply = <&pm8916_l17>; vddio-supply = <&pm8916_l6>; }; Looking at something like arch/arm/boot/dts/qcom/msm8916-mtp.dtsi which references arch/arm/boot/dts/qcom/dsi-panel-jdi-1080p-video.dtsi it doesn't appear to delete andy of the vdd*-supply references apq8016-sbc.dtb: dsi@1a98000: 'vdd-supply' is a required property msm8916-samsung-a3u-eur.dtb: dsi@1a98000: 'vdd-supply' is a required property msm8916-samsung-a5u-eur.dtb: dsi@1a98000: 'vdd-supply' is a required property msm8916-samsung-e5.dtb: dsi@1a98000: 'vdd-supply' is a required property msm8916-samsung-e7.dtb: dsi@1a98000: 'vdd-supply' is a required property msm8916-samsung-grandmax.dtb: dsi@1a98000: 'vdd-supply' is a required property msm8996-xiaomi-natrium.dtb: dsi@994000: 'panel@0', 'vcca-supply' do not match any of the regexes: 'pinctrl-[0-9]+' msm8996-xiaomi-scorpio.dtb: dsi@994000: 'vdda-supply' is a required property qrb5165-rb5.dtb: dsi@ae94000: 'vdd-supply' is a required property qrb5165-rb5.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-idp.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-idp.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-coachz-r1.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-coachz-r1.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-coachz-r1-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-coachz-r1-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-coachz-r3.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-coachz-r3.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-coachz-r3-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-coachz-r3-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-homestar-r2.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-homestar-r2.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-homestar-r3.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-homestar-r3.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-homestar-r4.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-homestar-r4.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-kingoftown-r0.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-kingoftown-r0.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-kingoftown-r1.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-kingoftown-r1.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r0.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r0.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r1.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r1.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r1-kb.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r1-kb.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r1-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r1-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r3.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r3.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r3-kb.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r3-kb.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r3-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r3-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r9.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r9.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r9-kb.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r9-kb.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-r9-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-r9-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-limozeen-r4.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-limozeen-r4.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-limozeen-r9.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-limozeen-r9.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-limozeen-nots-r4.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-limozeen-nots-r4.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-limozeen-nots-r5.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-limozeen-nots-r5.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-lazor-limozeen-nots-r9.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-lazor-limozeen-nots-r9.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-mrbland-rev0-auo.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-mrbland-rev0-auo.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-mrbland-rev0-boe.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-mrbland-rev0-boe.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-mrbland-rev1-auo.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-mrbland-rev1-auo.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-mrbland-rev1-boe.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-mrbland-rev1-boe.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pazquel-lte-parade.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pazquel-lte-parade.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pazquel-lte-ti.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pazquel-lte-ti.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pazquel-parade.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pazquel-parade.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pazquel-ti.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pazquel-ti.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pompom-r1.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pompom-r1.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pompom-r1-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pompom-r1-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pompom-r2.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pompom-r2.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pompom-r2-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pompom-r2-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pompom-r3.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pompom-r3.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-pompom-r3-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-pompom-r3-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-quackingstick-r0.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-quackingstick-r0.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-quackingstick-r0-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-quackingstick-r0-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-wormdingler-rev0-boe.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-wormdingler-rev0-boe.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-wormdingler-rev0-inx.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-wormdingler-rev0-inx.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-wormdingler-rev1-boe.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-wormdingler-rev1-boe.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-wormdingler-rev1-inx.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-wormdingler-rev1-inx.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-wormdingler-rev1-inx-rt5682s.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-wormdingler-rev1-boe-rt5682s.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-r1.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-r1.dtb: dsi@ae94000: 'vddio-supply' is a required property sc7180-trogdor-r1-lte.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-r1-lte.dtb: dsi@ae94000: 'vddio-supply' is a required property sda660-inforce-ifc6560.dtb: dsi@c994000: 'vdd-supply' is a required property sda660-inforce-ifc6560.dtb: dsi@c994000: 'vddio-supply' is a required property sdm845-cheza-r1.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-cheza-r1.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm845-cheza-r2.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-cheza-r2.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm845-cheza-r3.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-cheza-r3.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm845-db845c.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-db845c.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm845-mtp.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-mtp.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm845-mtp.dtb: dsi@ae96000: 'vdd-supply' is a required property sdm845-mtp.dtb: dsi@ae96000: 'vddio-supply' is a required property sdm845-oneplus-enchilada.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-oneplus-enchilada.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm845-oneplus-fajita.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-oneplus-fajita.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm845-xiaomi-beryllium.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-xiaomi-beryllium.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm845-xiaomi-polaris.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-xiaomi-polaris.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm845-shift-axolotl.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm845-shift-axolotl.dtb: dsi@ae94000: 'vddio-supply' is a required property sdm850-lenovo-yoga-c630.dtb: dsi@ae94000: 'vdd-supply' is a required property sdm850-lenovo-yoga-c630.dtb: dsi@ae94000: 'vddio-supply' is a required property apq8016-sbc.dtb: dsi@1a98000: 'vdd-supply' is a required property msm8916-samsung-a5u-eur.dtb: dsi@1a98000: 'vdd-supply' is a required property sc7180-trogdor-homestar-r4.dtb: dsi@ae94000: 'vdd-supply' is a required property sc7180-trogdor-homestar-r4.dtb: dsi@ae94000: 'vddio-supply' is a required property
On Tue, 8 Nov 2022 at 17:42, Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote: > > On 08/11/2022 12:59, Dmitry Baryshkov wrote: > >> > >> Warnings about missing regulators can be resolved by updating the > >> relevant > >> dtsi files to point to fixed always-on regulators where appropriate. > > > > Ugh. Are they missing or are they optional/not used on these platforms? > > Some platforms either don't implement them or worse possibly do > implement but don't model them when they should. > > > Can you possibly list all regulator warnings? > > > Downstream we have > > arch/arm/boot/dts/qcom/msm8916-mdss.dtsi > > mdss_dsi0: qcom,mdss_dsi@1a98000 { > vdda-supply = <&pm8916_l2>; > vdd-supply = <&pm8916_l17>; > vddio-supply = <&pm8916_l6>; > }; > > Looking at something like > > arch/arm/boot/dts/qcom/msm8916-mtp.dtsi which references > arch/arm/boot/dts/qcom/dsi-panel-jdi-1080p-video.dtsi it doesn't appear > to delete andy of the vdd*-supply references Good example. We have vdda-supply and vddio-supply in msm8916-pm8916.dtsi (correct). And the mentioned vdd-supply is not applicable to this platform. It powers up the external DSI-to-HDMI bridge. I'd assume that the same regulator was destined to power up the panel. So, I'd suggest defining all supplies at the top level and then pushing all the required: parts into the per-SoC entries.
On 08/11/2022 00:56, Bryan O'Donoghue wrote: > When converting from .txt to .yaml we didn't include descriptions for the > existing regulator supplies. > > - vdd > - vdda > - vddio > > Add those descriptions into the yaml now as they were prior to the > conversion. Mark the supplies as required as was previously the case in the > .txt implementation. > > Warnings about missing regulators can be resolved by updating the relevant > dtsi files to point to fixed always-on regulators where appropriate. > > Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") > Cc: Rob Clark <robdclark@gmail.com> > Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> > Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Cc: Sean Paul <sean@poorly.run> > Cc: David Airlie <airlied@gmail.com> > Cc: Daniel Vetter <daniel@ffwll.ch> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: linux-arm-msm@vger.kernel.org > Cc: dri-devel@lists.freedesktop.org > Cc: freedreno@lists.freedesktop.org > Cc: devicetree@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > .../bindings/display/msm/dsi-controller-main.yaml | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > index cf782c5f5bdb0..0f7747e55b9be 100644 > --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > @@ -124,6 +124,18 @@ properties: > - port@0 > - port@1 > > + vdd-supply: > + description: > + Phandle to vdd regulator device node Drop "Phandle to" and "device node", so just "VDD regulator". You describe hardware rather (when applicable), not Devicetree syntax. The same in other places and with that: Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml index cf782c5f5bdb0..0f7747e55b9be 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml @@ -124,6 +124,18 @@ properties: - port@0 - port@1 + vdd-supply: + description: + Phandle to vdd regulator device node + + vddio-supply: + description: + Phandle to vdd-io regulator device node + + vdda-supply: + description: + Phandle to vdda regulator device node + required: - compatible - reg @@ -135,6 +147,9 @@ required: - assigned-clocks - assigned-clock-parents - ports + - vdd-supply + - vddio-supply + - vdda-supply additionalProperties: false
When converting from .txt to .yaml we didn't include descriptions for the existing regulator supplies. - vdd - vdda - vddio Add those descriptions into the yaml now as they were prior to the conversion. Mark the supplies as required as was previously the case in the .txt implementation. Warnings about missing regulators can be resolved by updating the relevant dtsi files to point to fixed always-on regulators where appropriate. Fixes: 4dbe55c97741 ("dt-bindings: msm: dsi: add yaml schemas for DSI bindings") Cc: Rob Clark <robdclark@gmail.com> Cc: Abhinav Kumar <quic_abhinavk@quicinc.com> Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> Cc: Sean Paul <sean@poorly.run> Cc: David Airlie <airlied@gmail.com> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Rob Herring <robh+dt@kernel.org> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Cc: linux-arm-msm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org Cc: devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- .../bindings/display/msm/dsi-controller-main.yaml | 15 +++++++++++++++ 1 file changed, 15 insertions(+)