[net-next,RFC,5/5] r8152: remove redundant code

Message ID	20221108153342.18979-6-albert.zhou.50@gmail.com
State	New
Headers	show Return-Path: <linux-usb-owner@kernel.org> From: Albert Zhou <albert.zhou.50@gmail.com> To: gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, nic_swsd@realtek.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org Subject: [PATCH net-next RFC 5/5] r8152: remove redundant code Date: Wed, 9 Nov 2022 02:33:42 +1100 Message-Id: <20221108153342.18979-6-albert.zhou.50@gmail.com> In-Reply-To: <20221108153342.18979-1-albert.zhou.50@gmail.com> References: <20221108153342.18979-1-albert.zhou.50@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Update r8152 to version two \| expand [net-next,RFC,0/5] Update r8152 to version two [net-next,RFC,1/5] net: move back netif_set_gso_max helpers [net-next,RFC,3/5] r8152: remove backwards compatibility [net-next,RFC,4/5] r8152: merge header into source [net-next,RFC,5/5] r8152: remove redundant code

Message ID

20221108153342.18979-6-albert.zhou.50@gmail.com

State

New

Headers

From: Albert Zhou <albert.zhou.50@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, nic_swsd@realtek.com,
        davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
        pabeni@redhat.com, netdev@vger.kernel.org
Subject: [PATCH net-next RFC 5/5] r8152: remove redundant code
Date: Wed,  9 Nov 2022 02:33:42 +1100
Message-Id: <20221108153342.18979-6-albert.zhou.50@gmail.com>
In-Reply-To: <20221108153342.18979-1-albert.zhou.50@gmail.com>
References: <20221108153342.18979-1-albert.zhou.50@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

Update r8152 to version two | expand

Commit Message

Albert Zhou Nov. 8, 2022, 3:33 p.m. UTC

Remove the unused but defined macros TRUE, FALSE.

Remove commented code, which refers to the non-existent functions
r8156_*_eee.

Signed-off-by: Albert Zhou <albert.zhou.50@gmail.com>
---
 drivers/net/usb/r8152.c | 9 ---------
 1 file changed, 9 deletions(-)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 10dff6a88093..6ffc89780c96 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -46,11 +46,6 @@ 
 #include <linux/mdio.h>
 #include <uapi/linux/mdio.h>
 
-#ifndef FALSE
-	#define TRUE	1
-	#define FALSE	0
-#endif
-
 enum rtl_cmd {
 	RTLTOOL_PLA_OCP_READ_DWORD = 0,
 	RTLTOOL_PLA_OCP_WRITE_DWORD,
@@ -19096,10 +19091,6 @@  static int rtl_ops_init(struct r8152 *tp)
 		ops->up			= rtl8156_up;
 		ops->down		= rtl8156_down;
 		ops->unload		= rtl8153_unload;
-//#if LINUX_VERSION_CODE >= KERNEL_VERSION(3,6,0)
-//		ops->eee_get		= r8156_get_eee;
-//		ops->eee_set		= r8156_set_eee;
-//#endif /* LINUX_VERSION_CODE >= KERNEL_VERSION(3,6,0) */
 		ops->in_nway		= rtl8153_in_nway;
 		ops->hw_phy_cfg		= r8156_hw_phy_cfg_test;
 		ops->autosuspend_en	= rtl8156_runtime_enable;

[net-next,RFC,5/5] r8152: remove redundant code

Commit Message

Patch