| Message ID | 20221109150706.38823-1-andriy.shevchenko@linux.intel.com |
|---|---|
| State | Accepted |
| Commit | a431803852de00d8d3c143b19f5690254225538f |
| Headers | show |
| Series | [v1,1/2] gpiolib: of: Drop redundant check in of_mm_gpiochip_remove() | expand |
On Wed, Nov 09, 2022 at 05:07:06PM +0200, Andy Shevchenko wrote: > All new drivers should use fwnode and / or parent to provide the > necessary information to the GPIO library. Please, ignore this series, it was wrong offset to send the patches from.
diff --git a/drivers/gpio/gpiolib-of.c b/drivers/gpio/gpiolib-of.c index feeb9e8e846d..83997434215e 100644 --- a/drivers/gpio/gpiolib-of.c +++ b/drivers/gpio/gpiolib-of.c @@ -963,9 +963,6 @@ void of_mm_gpiochip_remove(struct of_mm_gpio_chip *mm_gc) { struct gpio_chip *gc = &mm_gc->gc; - if (!mm_gc) - return; - gpiochip_remove(gc); iounmap(mm_gc->regs); kfree(gc->label);
The callers never call the function with invalid pointer. Moreover, compiler quite likely dropped that check anyway because we use that pointer before the check. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/gpio/gpiolib-of.c | 3 --- 1 file changed, 3 deletions(-)