| Message ID | 20221110150035.2824580-3-adeep@lexina.in |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: amlogic: mmc: meson-gx: Add core, tx, rx | expand |
Hi Vyacheslav, On Thu, Nov 10, 2022 at 4:02 PM Vyacheslav Bocharov <adeep@lexina.in> wrote: [...] > +/* > + * Cfg_rx_phase: RX clock phase > + * bits: 9:8 R/W Generally register values should not be part of the dt-bindings. If we need to make the phases configurable through device-tree then I suggest using the human readable values (0, 90, 180, 270) instead of these register bits. That said, if for whatever reason we need to have #defines for this then they should be added with the dt-bindings patch (and also carry the dt-bindings subject prefix) instead of a separate patch. Best regards, Martin
diff --git a/include/dt-bindings/mmc/meson-gx-mmc.h b/include/dt-bindings/mmc/meson-gx-mmc.h new file mode 100644 index 000000000000..cfc4a9d75b2b --- /dev/null +++ b/include/dt-bindings/mmc/meson-gx-mmc.h @@ -0,0 +1,35 @@ +/* SPDX-License-Identifier: (GPL-2.0+ or MIT) */ +/* + * Copyright (c) 2022 JetHome, Vyacheslav Bocharov + * Author: Vyacheslav Bocharov <adeep@lexina.in> + */ + +#ifndef _DT_BINDINGS_MESON_GX_MMC_H +#define _DT_BINDINGS_MESON_GX_MMC_H + +/* + * Cfg_rx_phase: RX clock phase + * bits: 9:8 R/W + * default: 0 + * Recommended value: 0 + * + * Cfg_tx_phase: TX clock phase + * bits: 9:8 R/W + * default: 0 + * Recommended value: 2 + * + * Cfg_co_phase: Core clock phase + * bits: 9:8 R/W + * default: 0 + * Recommended value: 2 + * + * values: 0: 0 phase, 1: 90 phase, 2: 180 phase, 3: 270 phase. + */ + +#define CLK_PHASE_0 0 +#define CLK_PHASE_90 1 +#define CLK_PHASE_180 2 +#define CLK_PHASE_270 3 + + +#endif
The mmc driver has the same phase values for all meson platforms. However, some platforms (and even some boards) require different values. This patch transfers the values from the set in the code to the variables in the device-tree file. Signed-off-by: Vyacheslav Bocharov <adeep@lexina.in> create mode 100644 include/dt-bindings/mmc/meson-gx-mmc.h