Message ID | 20221112172650.127280-4-bryan.odonoghue@linaro.org |
---|---|
State | New |
Headers | show |
Series | Switch on IMX577 on RB5 | expand |
Hi Bryan, Thank you for the patch. On Sat, Nov 12, 2022 at 05:26:47PM +0000, Bryan O'Donoghue wrote: > Use preferred status "disabled" instead of "disable". > > Reported-by: Konrad Dybcio <konrad.dybcio@linaro.org> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > index ce95b51f17fff..5da91c646c200 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > @@ -1262,7 +1262,7 @@ camera@60 { > vdddo-supply = <&vreg_lvs1a_1p8>; > vdda-supply = <&cam3_avdd_2v8>; > > - status = "disable"; > + status = "disabled"; > > port { > ov7251_ep: endpoint {
On 12/11/2022 18:26, Bryan O'Donoghue wrote: > Use preferred status "disabled" instead of "disable". > > Reported-by: Konrad Dybcio <konrad.dybcio@linaro.org> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Konrad > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > index ce95b51f17fff..5da91c646c200 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > @@ -1262,7 +1262,7 @@ camera@60 { > vdddo-supply = <&vreg_lvs1a_1p8>; > vdda-supply = <&cam3_avdd_2v8>; > > - status = "disable"; > + status = "disabled"; > > port { > ov7251_ep: endpoint {
On 12/11/2022 18:26, Bryan O'Donoghue wrote: > Use preferred status "disabled" instead of "disable". > > Reported-by: Konrad Dybcio <konrad.dybcio@linaro.org> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> > --- > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > index ce95b51f17fff..5da91c646c200 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts I propose to squash with previous. These are basically same issues, unless one has visible effect (e.g. wrong name) thus needs Fixes tag. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts index ce95b51f17fff..5da91c646c200 100644 --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts @@ -1262,7 +1262,7 @@ camera@60 { vdddo-supply = <&vreg_lvs1a_1p8>; vdda-supply = <&cam3_avdd_2v8>; - status = "disable"; + status = "disabled"; port { ov7251_ep: endpoint {
Use preferred status "disabled" instead of "disable". Reported-by: Konrad Dybcio <konrad.dybcio@linaro.org> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org> --- arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)