diff mbox series

Bluetooth: hci_conn: Use kzalloc for kmalloc+memset

Message ID Y253EjjM0yvRGl+M@qemulion
State Superseded
Headers show
Series Bluetooth: hci_conn: Use kzalloc for kmalloc+memset | expand

Commit Message

Deepak R Varma Nov. 11, 2022, 4:23 p.m. UTC 
Use of kzalloc preferred over combination of kmalloc & memset. Issue
identified using coccicheck.

Signed-off-by: Deepak R Varma <drv@mailo.com>
---
 net/bluetooth/hci_conn.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

--
2.34.1
diff mbox series

Patch

diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c
index 7a59c4487050..287d313aa312 100644
--- a/net/bluetooth/hci_conn.c
+++ b/net/bluetooth/hci_conn.c
@@ -824,11 +824,10 @@  static int hci_le_terminate_big(struct hci_dev *hdev, u8 big, u8 bis)

 	bt_dev_dbg(hdev, "big 0x%2.2x bis 0x%2.2x", big, bis);

-	d = kmalloc(sizeof(*d), GFP_KERNEL);
+	d = kzalloc(sizeof(*d), GFP_KERNEL);
 	if (!d)
 		return -ENOMEM;

-	memset(d, 0, sizeof(*d));
 	d->big = big;
 	d->bis = bis;

@@ -861,11 +860,10 @@  static int hci_le_big_terminate(struct hci_dev *hdev, u8 big, u16 sync_handle)

 	bt_dev_dbg(hdev, "big 0x%2.2x sync_handle 0x%4.4x", big, sync_handle);

-	d = kmalloc(sizeof(*d), GFP_KERNEL);
+	d = kzalloc(sizeof(*d), GFP_KERNEL);
 	if (!d)
 		return -ENOMEM;

-	memset(d, 0, sizeof(*d));
 	d->big = big;
 	d->sync_handle = sync_handle;