| Message ID | 20221115175415.650690-3-niyas.sait@linaro.org |
|---|---|
| State | Accepted |
| Commit | 196270c5d6f3cfabd609e6202858fbccec14691f |
| Headers | show |
| Series | pinctrl: add ACPI support to pin controller | expand |
On Thu, Nov 17, 2022 at 12:37:44PM +0200, Andy Shevchenko wrote: > On Thu, Nov 17, 2022 at 10:30:37AM +0100, Linus Walleij wrote: > > On Tue, Nov 15, 2022 at 6:54 PM Niyas Sait <niyas.sait@linaro.org> wrote: > > > > > PIN_CONFIG_BIAS_PULL_DOWN and PIN_CONFIG_BIAS_PULL_UP values can > > > be custom or an SI unit such as ohms > > > > > > Signed-off-by: Niyas Sait <niyas.sait@linaro.org> > > > > This patch is good as-is so I just applied it. No need to resend with > > the ACPI series. > > Is it? I think it's visible that it has TAB vs. space issue... To be more clear, the "such as ohms" have been indented with spaces, while everything else with TABs. On top of that I would use proper capitalization for unit, i.e. Ohms. But the latter is minor.
Sorry for the newbie issues. Somehow I missed the space vs tab issue on that patch. I will send a patch to fix the two issues. -- Niyas On 17/11/2022 10:39, Andy Shevchenko wrote: > On Thu, Nov 17, 2022 at 12:37:44PM +0200, Andy Shevchenko wrote: >> On Thu, Nov 17, 2022 at 10:30:37AM +0100, Linus Walleij wrote: >>> On Tue, Nov 15, 2022 at 6:54 PM Niyas Sait <niyas.sait@linaro.org> wrote: >>> >>>> PIN_CONFIG_BIAS_PULL_DOWN and PIN_CONFIG_BIAS_PULL_UP values can >>>> be custom or an SI unit such as ohms >>>> >>>> Signed-off-by: Niyas Sait <niyas.sait@linaro.org> >>> >>> This patch is good as-is so I just applied it. No need to resend with >>> the ACPI series. >> >> Is it? I think it's visible that it has TAB vs. space issue... > > To be more clear, the "such as ohms" have been indented with spaces, while > everything else with TABs. On top of that I would use proper capitalization > for unit, i.e. Ohms. But the latter is minor. >
diff --git a/include/linux/pinctrl/pinconf-generic.h b/include/linux/pinctrl/pinconf-generic.h index 2422211d6a5a..11e7394bcc70 100644 --- a/include/linux/pinctrl/pinconf-generic.h +++ b/include/linux/pinctrl/pinconf-generic.h @@ -35,7 +35,8 @@ struct pinctrl_map; * impedance. * @PIN_CONFIG_BIAS_PULL_DOWN: the pin will be pulled down (usually with high * impedance to GROUND). If the argument is != 0 pull-down is enabled, - * if it is 0, pull-down is total, i.e. the pin is connected to GROUND. + * the value is interpreted by the driver and can be custom or an SI unit + * such as ohms. * @PIN_CONFIG_BIAS_PULL_PIN_DEFAULT: the pin will be pulled up or down based * on embedded knowledge of the controller hardware, like current mux * function. The pull direction and possibly strength too will normally @@ -46,7 +47,8 @@ struct pinctrl_map; * @PIN_CONFIG_BIAS_DISABLE. * @PIN_CONFIG_BIAS_PULL_UP: the pin will be pulled up (usually with high * impedance to VDD). If the argument is != 0 pull-up is enabled, - * if it is 0, pull-up is total, i.e. the pin is connected to VDD. + * the value is interpreted by the driver and can be custom or an SI unit + * such as ohms. * @PIN_CONFIG_DRIVE_OPEN_DRAIN: the pin will be driven with open drain (open * collector) which means it is usually wired with other output ports * which are then pulled up with an external resistor. Setting this
PIN_CONFIG_BIAS_PULL_DOWN and PIN_CONFIG_BIAS_PULL_UP values can be custom or an SI unit such as ohms Signed-off-by: Niyas Sait <niyas.sait@linaro.org> --- include/linux/pinctrl/pinconf-generic.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)