| Message ID | 822b3823-f344-67d6-30f1-16e31cf68eed@scst.dev |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] qla2xxx: Remove duplicate of vha->iocb_work initialization | expand |
Gleb, > Commit 9b3e0f4d4147 ("scsi: qla2xxx: Move work element processing out > of DPC thread") introduced the initialization of vha->iocb_work in > qla2x00_create_host() function. Applied to 6.2/scsi-staging, thanks!
On Tue, 15 Nov 2022 12:38:05 +0300, Gleb Chesnokov wrote: > Commit 9b3e0f4d4147 ("scsi: qla2xxx: Move work element processing > out of DPC thread") introduced the initialization of vha->iocb_work in > qla2x00_create_host() function. > > This initialization is also called from qla2x00_probe_one() function, > just after qla2x00_create_host(). > > [...] Applied to 6.2/scsi-queue, thanks! [1/2] qla2xxx: Remove duplicate of vha->iocb_work initialization https://git.kernel.org/mkp/scsi/c/3620e174d260
diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index 2c85f3cce726..9d82921d94b8 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -3284,7 +3284,6 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct pci_device_id *id) host->max_cmd_len, host->max_channel, host->max_lun, host->transportt, sht->vendor_id); - INIT_WORK(&base_vha->iocb_work, qla2x00_iocb_work_fn); INIT_WORK(&ha->heartbeat_work, qla_heartbeat_work_fn);
Commit 9b3e0f4d4147 ("scsi: qla2xxx: Move work element processing out of DPC thread") introduced the initialization of vha->iocb_work in qla2x00_create_host() function. This initialization is also called from qla2x00_probe_one() function, just after qla2x00_create_host(). Hence remove this duplicate call since it has already been called before. Signed-off-by: Gleb Chesnokov <gleb.chesnokov@scst.dev> --- drivers/scsi/qla2xxx/qla_os.c | 1 - 1 file changed, 1 deletion(-) /* Set up the irqs */