| Message ID | 20221117172532.538149-13-alex.bennee@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | testing and doc updates (pre-PR) | expand |
On 17/11/22 18:25, Alex Bennée wrote: > From: Peter Maydell <peter.maydell@linaro.org> > > The two tests > tests/avocado/boot_linux.py:BootLinuxAarch64.test_virt_tcg_gicv2 > tests/avocado/boot_linux.py:BootLinuxAarch64.test_virt_tcg_gicv3 > > take quite a long time to run, and the current timeout of 240s > is not enough for the tests to complete on slow machines: > we've seen these tests time out in the gitlab CI in the > 'avocado-system-alpine' CI job, for instance. The timeout The previous patches removed these jobs from GitLab CI, so this shouldn't be a problem there anymore, but the next part is still relevant: > is also insufficient for running the test with a debug build > of QEMU: on my machine the tests take over 10 minutes to run > in that config. Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> > Push the timeout up to 720s so that the test definitely has > enough time to complete. > > Signed-off-by: Peter Maydell <peter.maydell@linaro.org> > Reviewed-by: Thomas Huth <thuth@redhat.com> > Message-Id: <20221117111628.911686-1-peter.maydell@linaro.org> > Signed-off-by: Alex Bennée <alex.bennee@linaro.org> > --- > tests/avocado/boot_linux.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-)
On Thu, 17 Nov 2022 at 17:25, Alex Bennée <alex.bennee@linaro.org> wrote: > > From: Peter Maydell <peter.maydell@linaro.org> > > The two tests > tests/avocado/boot_linux.py:BootLinuxAarch64.test_virt_tcg_gicv2 > tests/avocado/boot_linux.py:BootLinuxAarch64.test_virt_tcg_gicv3 > > take quite a long time to run, and the current timeout of 240s > is not enough for the tests to complete on slow machines: > we've seen these tests time out in the gitlab CI in the > 'avocado-system-alpine' CI job, for instance. The timeout > is also insufficient for running the test with a debug build > of QEMU: on my machine the tests take over 10 minutes to run > in that config. > > Push the timeout up to 720s so that the test definitely has > enough time to complete. Just to let you know, this patch is now upstream via target-arm.next, so you can drop it from your queue. thanks -- PMM
diff --git a/tests/avocado/boot_linux.py b/tests/avocado/boot_linux.py index 79810be942..b3e58fa309 100644 --- a/tests/avocado/boot_linux.py +++ b/tests/avocado/boot_linux.py @@ -67,7 +67,7 @@ class BootLinuxAarch64(LinuxTest): :avocado: tags=machine:virt :avocado: tags=machine:gic-version=2 """ - timeout = 240 + timeout = 720 def add_common_args(self): self.vm.add_args('-bios',