| Message ID | 20221118063219.2612473-3-bobo.shaobowang@huawei.com |
|---|---|
| State | Accepted |
| Commit | e335beed78ec82656dcb554f9fe560709f0dc408 |
| Headers | show |
| Series | change to use ACPI_FREE() to free the ACPI memory | expand |
On 2022-11-18 at 14:32:19 +0800, Wang ShaoBo wrote: > acpi_evaluate_dsm_typed()/acpi_evaluate_dsm() should be coupled with > ACPI_FREE() to free the ACPI memory, because we need to track the > allocation of acpi_object when ACPI_DBG_TRACK_ALLOCATIONS enabled, > so use ACPI_FREE() instead of kfree(). > > Fixes: 0db89fa243e5 ("ACPI: Introduce Platform Firmware Runtime Update device driver") > Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com> Reviewed-by: Chen Yu <yu.c.chen@intel.com> thanks, Chenyu
diff --git a/drivers/acpi/pfr_update.c b/drivers/acpi/pfr_update.c index 6bb0b778b5da..9d2bdc13253a 100644 --- a/drivers/acpi/pfr_update.c +++ b/drivers/acpi/pfr_update.c @@ -178,7 +178,7 @@ static int query_capability(struct pfru_update_cap_info *cap_hdr, ret = 0; free_acpi_buffer: - kfree(out_obj); + ACPI_FREE(out_obj); return ret; } @@ -224,7 +224,7 @@ static int query_buffer(struct pfru_com_buf_info *info, ret = 0; free_acpi_buffer: - kfree(out_obj); + ACPI_FREE(out_obj); return ret; } @@ -385,7 +385,7 @@ static int start_update(int action, struct pfru_device *pfru_dev) ret = 0; free_acpi_buffer: - kfree(out_obj); + ACPI_FREE(out_obj); return ret; }
acpi_evaluate_dsm_typed()/acpi_evaluate_dsm() should be coupled with ACPI_FREE() to free the ACPI memory, because we need to track the allocation of acpi_object when ACPI_DBG_TRACK_ALLOCATIONS enabled, so use ACPI_FREE() instead of kfree(). Fixes: 0db89fa243e5 ("ACPI: Introduce Platform Firmware Runtime Update device driver") Signed-off-by: Wang ShaoBo <bobo.shaobowang@huawei.com> --- drivers/acpi/pfr_update.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)