| Message ID | 20221118224540.619276-39-uwe@kleine-koenig.org |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
Hello Dave, hello Daniel, On Fri, Nov 18, 2022 at 11:36:12PM +0100, Uwe Kleine-König wrote: > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/gpu/drm/i2c/ch7006_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c > index 578b738859b9..e0476a5bf84c 100644 > --- a/drivers/gpu/drm/i2c/ch7006_drv.c > +++ b/drivers/gpu/drm/i2c/ch7006_drv.c > @@ -386,7 +386,7 @@ static const struct drm_encoder_slave_funcs ch7006_encoder_funcs = { > > /* I2C driver functions */ > > -static int ch7006_probe(struct i2c_client *client, const struct i2c_device_id *id) > +static int ch7006_probe(struct i2c_client *client) > { > uint8_t addr = CH7006_VERSION_ID; > uint8_t val; > @@ -495,7 +495,7 @@ static const struct dev_pm_ops ch7006_pm_ops = { > > static struct drm_i2c_encoder_driver ch7006_driver = { > .i2c_driver = { > - .probe = ch7006_probe, > + .probe_new = ch7006_probe, > .remove = ch7006_remove, > > .driver = { I didn't get any feedback for the four drm/i2c drivers in this series, (and they didn't appear in next). Who is responsible for this area? If you want to pick up just the drm/i2c patches, you can do: b4 am -l -P 38-41 20221118224540.619276-39-uwe@kleine-koenig.org All four patches don't depend on i2c_client_get_device_id(), so they can be applied to your tree as is. Best regards Uwe
Hello Uwe, On 11/18/22 23:36, Uwe Kleine-König wrote: > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- > drivers/gpu/drm/i2c/ch7006_drv.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c > index 578b738859b9..e0476a5bf84c 100644 > --- a/drivers/gpu/drm/i2c/ch7006_drv.c > +++ b/drivers/gpu/drm/i2c/ch7006_drv.c > @@ -386,7 +386,7 @@ static const struct drm_encoder_slave_funcs ch7006_encoder_funcs = { > > /* I2C driver functions */ > > -static int ch7006_probe(struct i2c_client *client, const struct i2c_device_id *id) > +static int ch7006_probe(struct i2c_client *client) > { > uint8_t addr = CH7006_VERSION_ID; > uint8_t val; > @@ -495,7 +495,7 @@ static const struct dev_pm_ops ch7006_pm_ops = { > > static struct drm_i2c_encoder_driver ch7006_driver = { > .i2c_driver = { > - .probe = ch7006_probe, > + .probe_new = ch7006_probe, > .remove = ch7006_remove, > > .driver = { Looks good to me. Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Hello, I fatfingered my git tooling and got the author of this patch wrong. My intention is that the author is Uwe Kleine-König <u.kleine-koenig@pengutronix.de> and not my other self with my private email address. Tell me if I should resend to simplify patch application. Best regards Uwe
Hello Uwe, On 1/10/23 10:06, Uwe Kleine-König wrote: > Hello, > > I fatfingered my git tooling and got the author of this patch wrong. My > intention is that the author is > > Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > That's what I thought but good to have a confirmation from you. > and not my other self with my private email address. Tell me if I should > resend to simplify patch application. > No need, I can amend that locally before pushing. Thanks! > Best regards > Uwe >
On 11/18/22 23:36, Uwe Kleine-König wrote: > The probe function doesn't make use of the i2c_device_id * parameter so it > can be trivially converted. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- I've pushed this to drm-misc (dri-misc-next) now. Thanks!
diff --git a/drivers/gpu/drm/i2c/ch7006_drv.c b/drivers/gpu/drm/i2c/ch7006_drv.c index 578b738859b9..e0476a5bf84c 100644 --- a/drivers/gpu/drm/i2c/ch7006_drv.c +++ b/drivers/gpu/drm/i2c/ch7006_drv.c @@ -386,7 +386,7 @@ static const struct drm_encoder_slave_funcs ch7006_encoder_funcs = { /* I2C driver functions */ -static int ch7006_probe(struct i2c_client *client, const struct i2c_device_id *id) +static int ch7006_probe(struct i2c_client *client) { uint8_t addr = CH7006_VERSION_ID; uint8_t val; @@ -495,7 +495,7 @@ static const struct dev_pm_ops ch7006_pm_ops = { static struct drm_i2c_encoder_driver ch7006_driver = { .i2c_driver = { - .probe = ch7006_probe, + .probe_new = ch7006_probe, .remove = ch7006_remove, .driver = {
The probe function doesn't make use of the i2c_device_id * parameter so it can be trivially converted. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- drivers/gpu/drm/i2c/ch7006_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)