diff mbox series

ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts'

Message ID 20221121202259.2415821-1-festevam@gmail.com
State New
Headers show
Series ARM: dts: imx6qdl-gw560x: Remove incorrect 'uart-has-rtscts' | expand

Commit Message

Fabio Estevam Nov. 21, 2022, 8:22 p.m. UTC
From: Fabio Estevam <festevam@denx.de>

The following build warning is seen when running:

make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml

arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
	From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml

The imx6qdl-gw560x board does not expose the UART RTS and CTS
as native UART pins, so 'uart-has-rtscts' should not be used.

Using 'uart-has-rtscts' with 'rts-gpios' is an invalid combination
detected by serial.yaml.

Fix the problem by removing the incorrect 'uart-has-rtscts' property.

Fixes: b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")
Signed-off-by: Fabio Estevam <festevam@denx.de>
---
 arch/arm/boot/dts/imx6qdl-gw560x.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Shawn Guo Dec. 31, 2022, 7:19 a.m. UTC | #1
On Mon, Nov 21, 2022 at 05:22:59PM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <festevam@denx.de>
> 
> The following build warning is seen when running:
> 
> make dtbs_check DT_SCHEMA_FILES=fsl-imx-uart.yaml
> 
> arch/arm/boot/dts/imx6dl-gw560x.dtb: serial@2020000: rts-gpios: False schema does not allow [[20, 1, 0]]
> 	From schema: Documentation/devicetree/bindings/serial/fsl-imx-uart.yaml
> 
> The imx6qdl-gw560x board does not expose the UART RTS and CTS
> as native UART pins, so 'uart-has-rtscts' should not be used.
> 
> Using 'uart-has-rtscts' with 'rts-gpios' is an invalid combination
> detected by serial.yaml.
> 
> Fix the problem by removing the incorrect 'uart-has-rtscts' property.
> 
> Fixes: b8a559feffb2 ("ARM: dts: imx: add Gateworks Ventana GW5600 support")
> Signed-off-by: Fabio Estevam <festevam@denx.de>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
index 4bc4371e6bae..4b81a975c979 100644
--- a/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw560x.dtsi
@@ -632,7 +632,6 @@  &ssi1 {
 &uart1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_uart1>;
-	uart-has-rtscts;
 	rts-gpios = <&gpio7 1 GPIO_ACTIVE_HIGH>;
 	status = "okay";
 };