diff mbox series

interconnect: qcom: Drop obsolete dependency on COMPILE_TEST

Message ID 20221121155946.3c985500@endymion.delvare
State Superseded
Headers show
Series interconnect: qcom: Drop obsolete dependency on COMPILE_TEST | expand

Commit Message

Jean Delvare Nov. 21, 2022, 2:59 p.m. UTC 
From: Jean Delvare <jdelvare@suse.de>
Subject: interconnect: qcom: Drop obsolete dependency on COMPILE_TEST

Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.

It is actually better to always build such drivers with OF enabled,
so that the test builds are closer to how each driver will actually be
built on its intended target. Building them without OF may not test
much as the compiler will optimize out potentially large parts of the
code. In the worst case, this could even pop false positive warnings.
Dropping COMPILE_TEST here improves the quality of our testing and
avoids wasting time on non-existent issues.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Andy Gross <agross@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: Georgi Djakov <djakov@kernel.org>
---
 drivers/interconnect/qcom/Kconfig |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series

Patch

--- linux-6.0.orig/drivers/interconnect/qcom/Kconfig
+++ linux-6.0/drivers/interconnect/qcom/Kconfig
@@ -74,7 +74,7 @@  config INTERCONNECT_QCOM_RPMH_POSSIBLE
 	default INTERCONNECT_QCOM
 	depends on QCOM_RPMH || (COMPILE_TEST && !QCOM_RPMH)
 	depends on QCOM_COMMAND_DB || (COMPILE_TEST && !QCOM_COMMAND_DB)
-	depends on OF || COMPILE_TEST
+	depends on OF
 	help
 	  Compile-testing RPMH drivers is possible on other platforms,
 	  but in order to avoid link failures, drivers must not be built-in