| Message ID | 3f75784c57dc0682b5e1758daddd93fee6bb4b27.1669585920.git.christophe.jaillet@wanadoo.fr |
|---|---|
| State | Accepted |
| Commit | 923d011febb4e2fb338036bb0ee6a0a7f9b10da1 |
| Headers | show |
| Series | gpio: Do not include <linux/kernel.h> when not really needed. | expand |
On Sun, Nov 27, 2022 at 10:52 PM Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > <linux/kernel.h> is included only for using container_of(). > Include <linux/container_of.h> instead, it is much lighter. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> This is fine. Reviewed-by: Linus Walleij <linus.walleij@linaro.org> As Andy split out the container_of header file a year ago or so he certainly want to ACK this too. Yours, Linus Walleij
On Sun, Nov 27, 2022 at 10:52:10PM +0100, Christophe JAILLET wrote: > <linux/kernel.h> is included only for using container_of(). > Include <linux/container_of.h> instead, it is much lighter. Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com> Thanks for doing this! We really don't want to see kernel.h to be included by other headers in the include/linux, include/asm, etc. > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > Not sure if the prefix should be gpio or gpiolib. I'm not sure either because this more for the consumers, I would leave gpio. > Let see if build-bots spot something which is inherit via kernel.h > --- > include/linux/of_gpio.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/of_gpio.h b/include/linux/of_gpio.h > index a5166eb93437..6db627257a7b 100644 > --- a/include/linux/of_gpio.h > +++ b/include/linux/of_gpio.h > @@ -34,7 +34,7 @@ enum of_gpio_flags { > > #ifdef CONFIG_OF_GPIO > > -#include <linux/kernel.h> > +#include <linux/container_of.h> > > /* > * OF GPIO chip for memory mapped banks > -- > 2.34.1 > >
On Sun, Nov 27, 2022 at 10:52 PM Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > > <linux/kernel.h> is included only for using container_of(). > Include <linux/container_of.h> instead, it is much lighter. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > Not sure if the prefix should be gpio or gpiolib. > > Let see if build-bots spot something which is inherit via kernel.h > --- > include/linux/of_gpio.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/of_gpio.h b/include/linux/of_gpio.h > index a5166eb93437..6db627257a7b 100644 > --- a/include/linux/of_gpio.h > +++ b/include/linux/of_gpio.h > @@ -34,7 +34,7 @@ enum of_gpio_flags { > > #ifdef CONFIG_OF_GPIO > > -#include <linux/kernel.h> > +#include <linux/container_of.h> > > /* > * OF GPIO chip for memory mapped banks > -- > 2.34.1 > Applied, thanks! Bartosz
diff --git a/include/linux/of_gpio.h b/include/linux/of_gpio.h index a5166eb93437..6db627257a7b 100644 --- a/include/linux/of_gpio.h +++ b/include/linux/of_gpio.h @@ -34,7 +34,7 @@ enum of_gpio_flags { #ifdef CONFIG_OF_GPIO -#include <linux/kernel.h> +#include <linux/container_of.h> /* * OF GPIO chip for memory mapped banks
<linux/kernel.h> is included only for using container_of(). Include <linux/container_of.h> instead, it is much lighter. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- Not sure if the prefix should be gpio or gpiolib. Let see if build-bots spot something which is inherit via kernel.h --- include/linux/of_gpio.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)