[PATCH/RFC,2/2] arm64: dts: renesas: ulcb-kf: Fix pcm3168a audio codec node

"make dtbs_check":

    arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb: audio-codec@44: ports: 'mclk-fs' does not match any of the regexes: '^port@[0-9a-f]+$', 'pinctrl-[0-9]+'
	    From schema: Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
    arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb: audio-codec@44: ports:port@0:endpoint: Unevaluated properties are not allowed ('clocks' was unexpected)
	    From schema: Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
    arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb: audio-codec@44: ports:port@1:endpoint: Unevaluated properties are not allowed ('clocks' was unexpected)
	    From schema: Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml

Fix this by:
  1. Moving the "mclk-fs" property to the endpoint nodes, where it
     belongs according to .../sound/audio-graph-port.yaml,
  2. Dropping the bogus "clocks" properties.

Fixes: 80c07701d5918928 ("arm64: dts: renesas: ulcb-kf: add pcm3168 sound codec")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
Compile-tested only.
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Hi Geert

Thank you for your patch

> diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> index 408871c2859d144d..8e46acbe3a203759 100644
> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -216,19 +216,18 @@ pcm3168a: audio-codec@44 {
>  				ports {
>  					#address-cells = <1>;
>  					#size-cells = <0>;
> -					mclk-fs = <512>;
>  					port@0 {
>  						reg = <0>;
>  						pcm3168a_endpoint_p: endpoint {
> +							mclk-fs = <512>;
>  							remote-endpoint = <&rsnd_for_pcm3168a_play>;
> -							clocks = <&clksndsel>;
>  						};
>  					};
>  					port@1 {
>  						reg = <1>;
>  						pcm3168a_endpoint_c: endpoint {
> +							mclk-fs = <512>;
>  							remote-endpoint = <&rsnd_for_pcm3168a_capture>;
> -							clocks = <&clksndsel>;
>  						};
>  					};
>  				};

I'm not tested, but in my quick check,
we can use "mclk-fs" under "ports", and we need "clocks" under "endpoint".
So the issue is not dtsi side, but yaml side.

I will check and fix it, but it will be next week or later.

Thank you for your help !!

Best regards
---
Kuninori Morimoto

Hi Geert

>    arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb: audio-codec@44: ports: 'mclk-fs' does not match any of the regexes: '^port@[0-9a-f]+$', 'pinctrl-[0-9]+'
>	    From schema: Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
>    arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb: audio-codec@44: ports:port@0:endpoint: Unevaluated properties are not allowed ('clocks' was unexpected)
>	    From schema: Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
>    arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb: audio-codec@44: ports:port@1:endpoint: Unevaluated properties are not allowed ('clocks' was unexpected)
>	    From schema: Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
(snip)
> I'm not tested, but in my quick check,
> we can use "mclk-fs" under "ports", and we need "clocks" under "endpoint".
> So the issue is not dtsi side, but yaml side.
> 
> I will check and fix it, but it will be next week or later.

I have investigated about this patch, and it needs extra patch
which I will post if -rc1 was released.
I can merge this patch (with small fixup) into my patch-set.
Of course I will keep your name. But is it OK for you ?

Thank you for your help !!

Best regards
---
Kuninori Morimoto

Hi Morimoto-san,

On Tue, Dec 13, 2022 at 12:49 AM Kuninori Morimoto
<kuninori.morimoto.gx@renesas.com> wrote:
> >    arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb: audio-codec@44: ports: 'mclk-fs' does not match any of the regexes: '^port@[0-9a-f]+$', 'pinctrl-[0-9]+'
> >           From schema: Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
> >    arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb: audio-codec@44: ports:port@0:endpoint: Unevaluated properties are not allowed ('clocks' was unexpected)
> >           From schema: Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
> >    arch/arm64/boot/dts/renesas/r8a77951-ulcb-kf.dtb: audio-codec@44: ports:port@1:endpoint: Unevaluated properties are not allowed ('clocks' was unexpected)
> >           From schema: Documentation/devicetree/bindings/sound/ti,pcm3168a.yaml
> (snip)
> > I'm not tested, but in my quick check,
> > we can use "mclk-fs" under "ports", and we need "clocks" under "endpoint".
> > So the issue is not dtsi side, but yaml side.
> >
> > I will check and fix it, but it will be next week or later.
>
> I have investigated about this patch, and it needs extra patch
> which I will post if -rc1 was released.
> I can merge this patch (with small fixup) into my patch-set.
> Of course I will keep your name. But is it OK for you ?

Thanks, fine for me!

♫ All I want for Christmas is ♫... an error-free "make dtbs_check" ;-)

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Hi Geert

> > I have investigated about this patch, and it needs extra patch
> > which I will post if -rc1 was released.
> > I can merge this patch (with small fixup) into my patch-set.
> > Of course I will keep your name. But is it OK for you ?
> 
> Thanks, fine for me!
> 
> ♫ All I want for Christmas is ♫... an error-free "make dtbs_check" ;-)

I will do my best ;)

	Merry Christmas

Thank you for your help !!

Best regards
---
Kuninori Morimoto