| Message ID | 20221203070639.15128-1-yuancan@huawei.com |
|---|---|
| State | Accepted |
| Commit | 38e7d9c19276832ebb0277f415b9214bf7baeb37 |
| Headers | show |
| Series | remoteproc: qcom_q6v5_pas: Fix missing of_node_put() in adsp_alloc_memory_region() | expand |
On Sat, 3 Dec 2022 07:06:39 +0000, Yuan Can wrote: > The pointer node is returned by of_parse_phandle() with refcount > incremented. We should use of_node_put() on it when done. > > Applied, thanks! [1/1] remoteproc: qcom_q6v5_pas: Fix missing of_node_put() in adsp_alloc_memory_region() commit: 38e7d9c19276832ebb0277f415b9214bf7baeb37 Best regards,
diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c index 6afd0941e552..24439a6396cc 100644 --- a/drivers/remoteproc/qcom_q6v5_pas.c +++ b/drivers/remoteproc/qcom_q6v5_pas.c @@ -449,6 +449,7 @@ static int adsp_alloc_memory_region(struct qcom_adsp *adsp) } ret = of_address_to_resource(node, 0, &r); + of_node_put(node); if (ret) return ret;
The pointer node is returned by of_parse_phandle() with refcount incremented. We should use of_node_put() on it when done. Fixes: b9e718e950c3 ("remoteproc: Introduce Qualcomm ADSP PIL") Signed-off-by: Yuan Can <yuancan@huawei.com> --- drivers/remoteproc/qcom_q6v5_pas.c | 1 + 1 file changed, 1 insertion(+)