| Message ID | 20221205183236.3460924-1-luiz.dentz@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2,1/3] Bluetooth: btusb: Fix new sparce warnings | expand |
This is automated email and please do not reply to this email! Dear submitter, Thank you for submitting the patches to the linux bluetooth mailing list. This is a CI test results with your patch series: PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=701910 ---Test result--- Test Summary: CheckPatch PASS 1.72 seconds GitLint PASS 0.85 seconds SubjectPrefix PASS 0.29 seconds BuildKernel PASS 34.88 seconds BuildKernel32 PASS 30.81 seconds TestRunnerSetup PASS 428.62 seconds TestRunner_l2cap-tester PASS 15.67 seconds TestRunner_iso-tester PASS 15.59 seconds TestRunner_bnep-tester PASS 5.42 seconds TestRunner_mgmt-tester PASS 104.21 seconds TestRunner_rfcomm-tester PASS 9.23 seconds TestRunner_sco-tester PASS 8.66 seconds TestRunner_ioctl-tester PASS 9.82 seconds TestRunner_mesh-tester PASS 6.64 seconds TestRunner_smp-tester PASS 8.36 seconds TestRunner_userchan-tester PASS 5.55 seconds IncrementalBuild PASS 42.68 seconds --- Regards, Linux Bluetooth
Hello: This series was applied to bluetooth/bluetooth-next.git (master) by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>: On Mon, 5 Dec 2022 10:32:34 -0800 you wrote: > From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com> > > This fix the following warnings detect with make W=1 C=1: > > drivers/bluetooth/btusb.c:2212:9: warning: cast to restricted __le16 > drivers/bluetooth/btusb.c:2212:9: warning: cast to restricted __le16 > drivers/bluetooth/btusb.c:2245:18: warning: cast to restricted __le16 > drivers/bluetooth/btusb.c:2249:18: warning: cast to restricted __le16 > drivers/bluetooth/btusb.c:2253:18: warning: cast to restricted __le16 > drivers/bluetooth/btusb.c:2257:18: warning: cast to restricted __le16 > drivers/bluetooth/btusb.c:2261:18: warning: cast to restricted __le16 > drivers/bluetooth/btusb.c:2267:18: warning: cast to restricted __le16 > > [...] Here is the summary with links: - [v2,1/3] Bluetooth: btusb: Fix new sparce warnings https://git.kernel.org/bluetooth/bluetooth-next/c/ee93fd98d900 - [v2,2/3] Bluetooth: btusb: Fix existing sparce warning https://git.kernel.org/bluetooth/bluetooth-next/c/e05ae902672a - [v2,3/3] Bluetooth: btintel: Fix existing sparce warnings https://git.kernel.org/bluetooth/bluetooth-next/c/b84a13ff4eda You are awesome, thank you!
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index d57571cc82d4..422c878a9500 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -2201,18 +2201,19 @@ static int btusb_setup_csr(struct hci_dev *hdev) return err; } - if (skb->len != sizeof(struct hci_rp_read_local_version)) { + rp = skb_pull_data(skb, sizeof(*rp)); + if (!rp) { bt_dev_err(hdev, "CSR: Local version length mismatch"); kfree_skb(skb); return -EIO; } - rp = (struct hci_rp_read_local_version *)skb->data; + bt_dev_info(hdev, "CSR: Setting up dongle with HCI ver=%u rev=%04x", + rp->hci_ver, le16_to_cpu(rp->hci_rev)); - bt_dev_info(hdev, "CSR: Setting up dongle with HCI ver=%u rev=%04x; LMP ver=%u subver=%04x; manufacturer=%u", - le16_to_cpu(rp->hci_ver), le16_to_cpu(rp->hci_rev), - le16_to_cpu(rp->lmp_ver), le16_to_cpu(rp->lmp_subver), - le16_to_cpu(rp->manufacturer)); + bt_dev_info(hdev, "LMP ver=%u subver=%04x; manufacturer=%u", + rp->lmp_ver, le16_to_cpu(rp->lmp_subver), + le16_to_cpu(rp->manufacturer)); /* Detect a wide host of Chinese controllers that aren't CSR. * @@ -2242,29 +2243,29 @@ static int btusb_setup_csr(struct hci_dev *hdev) * third-party BT 4.0 dongle reuses it. */ else if (le16_to_cpu(rp->lmp_subver) <= 0x034e && - le16_to_cpu(rp->hci_ver) > BLUETOOTH_VER_1_1) + rp->hci_ver > BLUETOOTH_VER_1_1) is_fake = true; else if (le16_to_cpu(rp->lmp_subver) <= 0x0529 && - le16_to_cpu(rp->hci_ver) > BLUETOOTH_VER_1_2) + rp->hci_ver > BLUETOOTH_VER_1_2) is_fake = true; else if (le16_to_cpu(rp->lmp_subver) <= 0x0c5c && - le16_to_cpu(rp->hci_ver) > BLUETOOTH_VER_2_0) + rp->hci_ver > BLUETOOTH_VER_2_0) is_fake = true; else if (le16_to_cpu(rp->lmp_subver) <= 0x1899 && - le16_to_cpu(rp->hci_ver) > BLUETOOTH_VER_2_1) + rp->hci_ver > BLUETOOTH_VER_2_1) is_fake = true; else if (le16_to_cpu(rp->lmp_subver) <= 0x22bb && - le16_to_cpu(rp->hci_ver) > BLUETOOTH_VER_4_0) + rp->hci_ver > BLUETOOTH_VER_4_0) is_fake = true; /* Other clones which beat all the above checks */ else if (bcdDevice == 0x0134 && le16_to_cpu(rp->lmp_subver) == 0x0c5c && - le16_to_cpu(rp->hci_ver) == BLUETOOTH_VER_2_0) + rp->hci_ver == BLUETOOTH_VER_2_0) is_fake = true; if (is_fake) {