| Message ID | 20221207204327.2810001-1-robh@kernel.org |
|---|---|
| State | Accepted |
| Commit | 121164481b79d93824eed464117d331a002f5d75 |
| Headers | show |
| Series | [1/2] dt-bindings: leds: intel,lgm: Add missing 'led-gpios' property | expand |
On Wed, Dec 7, 2022 at 9:43 PM Rob Herring <robh@kernel.org> wrote: > > 'led' nodes should have a reference to LED common.yaml schema. Add it where > missing and drop any duplicate properties. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/leds/leds-max77650.yaml | 9 ++------- > diff --git a/Documentation/devicetree/bindings/leds/leds-max77650.yaml b/Documentation/devicetree/bindings/leds/leds-max77650.yaml > index c6f96cabd4d1..fdb08f44a45d 100644 > --- a/Documentation/devicetree/bindings/leds/leds-max77650.yaml > +++ b/Documentation/devicetree/bindings/leds/leds-max77650.yaml > @@ -30,9 +30,8 @@ properties: > > patternProperties: > "^led@[0-2]$": > - type: object > - description: | > - Properties for a single LED. > + $ref: common.yaml# > + unevaluatedProperties: false > > properties: > reg: > @@ -41,10 +40,6 @@ patternProperties: > minimum: 0 > maximum: 2 > > - label: true > - > - linux,default-trigger: true > - > required: > - compatible > - "#address-cells" Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
On 07/12/2022 21:43, Rob Herring wrote: > The example has 'led-gpio' properties, but that's not documented. As the > 'gpio' form is deprecated, add 'led-gpios' to the schema and update the > example. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 07/12/2022 21:43, Rob Herring wrote: > 'led' nodes should have a reference to LED common.yaml schema. Add it where > missing and drop any duplicate properties. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/leds/leds-lgm.yaml | 3 ++- > .../devicetree/bindings/leds/leds-max77650.yaml | 9 ++------- > .../bindings/leds/rohm,bd71828-leds.yaml | 16 +++------------- > 3 files changed, 7 insertions(+), 21 deletions(-) > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Wed, 07 Dec 2022, Rob Herring wrote: > The example has 'led-gpio' properties, but that's not documented. As the > 'gpio' form is deprecated, add 'led-gpios' to the schema and update the > example. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/leds/leds-lgm.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) Looks good. Who usually takes these? Acked-by: Lee Jones <lee@kernel.org>
On Wed, 07 Dec 2022, Rob Herring wrote: > 'led' nodes should have a reference to LED common.yaml schema. Add it where > missing and drop any duplicate properties. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > .../devicetree/bindings/leds/leds-lgm.yaml | 3 ++- > .../devicetree/bindings/leds/leds-max77650.yaml | 9 ++------- > .../bindings/leds/rohm,bd71828-leds.yaml | 16 +++------------- > 3 files changed, 7 insertions(+), 21 deletions(-) Acked-by: Lee Jones <lee@kernel.org>
On Wed, 07 Dec 2022 14:43:26 -0600, Rob Herring wrote: > The example has 'led-gpio' properties, but that's not documented. As the > 'gpio' form is deprecated, add 'led-gpios' to the schema and update the > example. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Documentation/devicetree/bindings/leds/leds-lgm.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > Applied, thanks!
diff --git a/Documentation/devicetree/bindings/leds/leds-lgm.yaml b/Documentation/devicetree/bindings/leds/leds-lgm.yaml index f8d7963c3a13..3f13db0dc915 100644 --- a/Documentation/devicetree/bindings/leds/leds-lgm.yaml +++ b/Documentation/devicetree/bindings/leds/leds-lgm.yaml @@ -64,6 +64,9 @@ properties: minimum: 0 maximum: 2 + led-gpios: + maxItems: 1 + intel,sso-hw-trigger: type: boolean description: This property indicates Hardware driven/control LED. @@ -118,14 +121,14 @@ examples: reg = <0>; function = "gphy"; color = <LED_COLOR_ID_GREEN>; - led-gpio = <&ssogpio 0 0>; + led-gpios = <&ssogpio 0 0>; }; led@2 { reg = <2>; function = LED_FUNCTION_POWER; color = <LED_COLOR_ID_GREEN>; - led-gpio = <&ssogpio 23 0>; + led-gpios = <&ssogpio 23 0>; }; }; };
The example has 'led-gpio' properties, but that's not documented. As the 'gpio' form is deprecated, add 'led-gpios' to the schema and update the example. Signed-off-by: Rob Herring <robh@kernel.org> --- Documentation/devicetree/bindings/leds/leds-lgm.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)