diff mbox series

[1/2] dts: synquacer: Drop unused and undocumented SPI properties

Message ID 20221209024509.1920944-1-robh@kernel.org
State Accepted
Commit 36ee37632c5c61ce5cd67b9b0f0ea3cd2280e5d2
Headers show
Series [1/2] dts: synquacer: Drop unused and undocumented SPI properties | expand

Commit Message

Rob Herring Dec. 9, 2022, 2:45 a.m. UTC
'active_clk_edges' and 'chipselect_num' SPI controller properties are
unused in u-boot and Linux. They are also not documented in the binding.
So drop them.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi | 2 --
 1 file changed, 2 deletions(-)

Comments

Masahisa Kojima Dec. 9, 2022, 5:09 a.m. UTC | #1
+ Jassi

On Fri, 9 Dec 2022 at 11:45, Rob Herring <robh@kernel.org> wrote:
>
> 'active_clk_edges' and 'chipselect_num' SPI controller properties are
> unused in u-boot and Linux. They are also not documented in the binding.
> So drop them.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi b/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi
> index 6b85c05458d4..9f9837b33bef 100644
> --- a/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi
> +++ b/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi
> @@ -20,8 +20,6 @@
>                 #address-cells = <1>;
>                 #size-cells = <0>;
>                 status = "okay";
> -               active_clk_edges;
> -               chipselect_num = <1>;

Reviewed-by: Masahisa Kojima <masahisa.kojima@linaro.org>

Thank you for cleaning up the unused properties.

Regards,
Masahisa Kojima


>
>                 flash@0 {
>                         #address-cells = <1>;
> --
> 2.35.1
>
Ilias Apalodimas Dec. 9, 2022, 7:40 a.m. UTC | #2
On Thu, Dec 08, 2022 at 08:45:08PM -0600, Rob Herring wrote:
> 'active_clk_edges' and 'chipselect_num' SPI controller properties are
> unused in u-boot and Linux. They are also not documented in the binding.
> So drop them.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi b/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi
> index 6b85c05458d4..9f9837b33bef 100644
> --- a/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi
> +++ b/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi
> @@ -20,8 +20,6 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> -		active_clk_edges;
> -		chipselect_num = <1>;
>  
>  		flash@0 {
>  			#address-cells = <1>;
> -- 
> 2.35.1
> 

Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Jassi Brar Dec. 9, 2022, 7:38 p.m. UTC | #3
On Thu, 8 Dec 2022 at 23:09, Masahisa Kojima <masahisa.kojima@linaro.org> wrote:
>
> + Jassi
>
> On Fri, 9 Dec 2022 at 11:45, Rob Herring <robh@kernel.org> wrote:
> >
> > 'active_clk_edges' and 'chipselect_num' SPI controller properties are
> > unused in u-boot and Linux. They are also not documented in the binding.
> > So drop them.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> >  arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi b/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi
> > index 6b85c05458d4..9f9837b33bef 100644
> > --- a/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi
> > +++ b/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi
> > @@ -20,8 +20,6 @@
> >                 #address-cells = <1>;
> >                 #size-cells = <0>;
> >                 status = "okay";
> > -               active_clk_edges;
> > -               chipselect_num = <1>;
>
> Reviewed-by: Masahisa Kojima <masahisa.kojima@linaro.org>
>
Acked-by: Jassi Brar <jaswinder.singh@linaro.org>
Tom Rini Jan. 3, 2023, 3:41 p.m. UTC | #4
On Thu, Dec 08, 2022 at 08:45:08PM -0600, Rob Herring wrote:

> 'active_clk_edges' and 'chipselect_num' SPI controller properties are
> unused in u-boot and Linux. They are also not documented in the binding.
> So drop them.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Masahisa Kojima <masahisa.kojima@linaro.org>
> Acked-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
> Acked-by: Jassi Brar <jaswinder.singh@linaro.org>

Applied to u-boot/next, thanks!
diff mbox series

Patch

diff --git a/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi b/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi
index 6b85c05458d4..9f9837b33bef 100644
--- a/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi
+++ b/arch/arm/dts/synquacer-sc2a11-developerbox-u-boot.dtsi
@@ -20,8 +20,6 @@ 
 		#address-cells = <1>;
 		#size-cells = <0>;
 		status = "okay";
-		active_clk_edges;
-		chipselect_num = <1>;
 
 		flash@0 {
 			#address-cells = <1>;