| Message ID | 20221210134059.342423-1-dominikkobinski314@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | arm64: dts: bullhead: add memory hole region | expand |
On 10.12.2022 14:40, Dominik Kobinski wrote: > Add region for memory hole present on bullhead in order to > fix a reboot issue on recent kernels > > Reported-by: Petr Vorel <petr.vorel@gmail.com> > Signed-off-by: Dominik Kobinski <dominikkobinski314@gmail.com> > --- It'd be better if the commit title said msm8992-bullhead instead of just -bullhead. > arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi > index 71e373b11de9d8..3cf40d8cfdf6eb 100644 > --- a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi > @@ -2,6 +2,7 @@ > /* Copyright (c) 2015, LGE Inc. All rights reserved. > * Copyright (c) 2016, The Linux Foundation. All rights reserved. > * Copyright (c) 2021, Petr Vorel <petr.vorel@gmail.com> > + * Copyright (c) 2022, Dominik Kobinski <dominikkobinski314@gmail.com> > */ > > /dts-v1/; > @@ -50,6 +51,11 @@ > reg = <0 0x03400000 0 0x1200000>; > no-map; > }; > + > + removed_region: memory@5000000 { The memory node should not be named "memory", but something more specific, "reserved" would fit this case. I know most DTs have them as "memory", but that turned out to be just what we *aren't* supposed to do :P Konrad > + reg = <0 0x05000000 0 0x2200000>; > + no-map; > + }; > }; > };
On Sat, 10 Dec 2022 at 20:36, Konrad Dybcio <konrad.dybcio@linaro.org> wrote: > > > > On 10.12.2022 14:40, Dominik Kobinski wrote: > > Add region for memory hole present on bullhead in order to > > fix a reboot issue on recent kernels > > > > Reported-by: Petr Vorel <petr.vorel@gmail.com> > > Signed-off-by: Dominik Kobinski <dominikkobinski314@gmail.com> > > --- > It'd be better if the commit title said msm8992-bullhead instead of > just -bullhead. > > > arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi > > index 71e373b11de9d8..3cf40d8cfdf6eb 100644 > > --- a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi > > +++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi > > @@ -2,6 +2,7 @@ > > /* Copyright (c) 2015, LGE Inc. All rights reserved. > > * Copyright (c) 2016, The Linux Foundation. All rights reserved. > > * Copyright (c) 2021, Petr Vorel <petr.vorel@gmail.com> > > + * Copyright (c) 2022, Dominik Kobinski <dominikkobinski314@gmail.com> > > */ > > > > /dts-v1/; > > @@ -50,6 +51,11 @@ > > reg = <0 0x03400000 0 0x1200000>; > > no-map; > > }; > > + > > + removed_region: memory@5000000 { > The memory node should not be named "memory", but something more > specific, "reserved" would fit this case. I know most DTs have > them as "memory", but that turned out to be just what we *aren't* > supposed to do :P Hi Dominik, Konrad, Konrad, thanks a lot for correcting us. I guess Dominik will send v2, LGTM otherwise. Kind regards, Petr > > Konrad > > + reg = <0 0x05000000 0 0x2200000>; > > + no-map; > > + }; > > }; > > };
diff --git a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi index 71e373b11de9d8..3cf40d8cfdf6eb 100644 --- a/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi @@ -2,6 +2,7 @@ /* Copyright (c) 2015, LGE Inc. All rights reserved. * Copyright (c) 2016, The Linux Foundation. All rights reserved. * Copyright (c) 2021, Petr Vorel <petr.vorel@gmail.com> + * Copyright (c) 2022, Dominik Kobinski <dominikkobinski314@gmail.com> */ /dts-v1/; @@ -50,6 +51,11 @@ reg = <0 0x03400000 0 0x1200000>; no-map; }; + + removed_region: memory@5000000 { + reg = <0 0x05000000 0 0x2200000>; + no-map; + }; }; };
Add region for memory hole present on bullhead in order to fix a reboot issue on recent kernels Reported-by: Petr Vorel <petr.vorel@gmail.com> Signed-off-by: Dominik Kobinski <dominikkobinski314@gmail.com> --- arch/arm64/boot/dts/qcom/msm8992-lg-bullhead.dtsi | 6 ++++++ 1 file changed, 6 insertions(+)