[edk2,2/6] ArmPlatformPkg/ArmVExpressPkg: sync log level comments to DebugLib.h

Message ID 1456826312-11997-3-git-send-email-lersek@redhat.com
State New
Headers show

Commit Message

Laszlo Ersek March 1, 2016, 9:58 a.m.
Suggested-by: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>

---

Notes:
    not build tested

 ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

-- 
1.8.3.1


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm March 1, 2016, 10:10 a.m. | #1
On Tue, Mar 01, 2016 at 10:58:28AM +0100, Laszlo Ersek wrote:
> Suggested-by: Leif Lindholm <leif.lindholm@linaro.org>

> Cc: Leif Lindholm <leif.lindholm@linaro.org>

> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> Contributed-under: TianoCore Contribution Agreement 1.0

> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

> ---

> 

> Notes:

>     not build tested


*Twitch*

This file shouldn't even be here anymore - it now lives in
OpenPlatformPkg with the platforms, and we don't want accidental loss
of synchronization. I'll submit a separate patch condemining it to the
fate I thought it had already met.

(grep returns nothing in current tree)

Apologies for the inconvenience.

> 

>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 14 ++++++++------

>  1 file changed, 8 insertions(+), 6 deletions(-)

> 

> diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc

> index 1b8127d2eb69..27015644ba2f 100644

> --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc

> +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc

> @@ -343,19 +343,21 @@ [PcdsFixedAtBuild.common]

>    #  DEBUG_WARN      0x00000002  // Warnings

>    #  DEBUG_LOAD      0x00000004  // Load events

>    #  DEBUG_FS        0x00000008  // EFI File system

> -  #  DEBUG_POOL      0x00000010  // Alloc & Free's

> -  #  DEBUG_PAGE      0x00000020  // Alloc & Free's

> -  #  DEBUG_INFO      0x00000040  // Verbose

> -  #  DEBUG_DISPATCH  0x00000080  // PEI/DXE Dispatchers

> +  #  DEBUG_POOL      0x00000010  // Alloc & Free (pool)

> +  #  DEBUG_PAGE      0x00000020  // Alloc & Free (page)

> +  #  DEBUG_INFO      0x00000040  // Informational debug messages

> +  #  DEBUG_DISPATCH  0x00000080  // PEI/DXE/SMM Dispatchers

>    #  DEBUG_VARIABLE  0x00000100  // Variable

>    #  DEBUG_BM        0x00000400  // Boot Manager

>    #  DEBUG_BLKIO     0x00001000  // BlkIo Driver

> -  #  DEBUG_NET       0x00004000  // SNI Driver

> +  #  DEBUG_NET       0x00004000  // SNP Driver

>    #  DEBUG_UNDI      0x00010000  // UNDI Driver

> -  #  DEBUG_LOADFILE  0x00020000  // UNDI Driver

> +  #  DEBUG_LOADFILE  0x00020000  // LoadFile

>    #  DEBUG_EVENT     0x00080000  // Event messages

>    #  DEBUG_GCD       0x00100000  // Global Coherency Database changes

>    #  DEBUG_CACHE     0x00200000  // Memory range cachability changes

> +  #  DEBUG_VERBOSE   0x00400000  // Detailed debug messages that may

> +  #                              // significantly impact boot performance

>    #  DEBUG_ERROR     0x80000000  // Error

>    gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F

>  

> -- 

> 1.8.3.1

> 

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Ryan Harkin March 1, 2016, 2:07 p.m. | #2
On 1 March 2016 at 10:10, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> On Tue, Mar 01, 2016 at 10:58:28AM +0100, Laszlo Ersek wrote:

>> Suggested-by: Leif Lindholm <leif.lindholm@linaro.org>

>> Cc: Leif Lindholm <leif.lindholm@linaro.org>

>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>

>> Contributed-under: TianoCore Contribution Agreement 1.0

>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

>> ---

>>

>> Notes:

>>     not build tested

>

> *Twitch*

>

> This file shouldn't even be here anymore - it now lives in

> OpenPlatformPkg with the platforms, and we don't want accidental loss

> of synchronization. I'll submit a separate patch condemining it to the

> fate I thought it had already met.

>

> (grep returns nothing in current tree)

>


You've send a patch to remove it from the tree to the list, Ard,
Laszlo and me have Reviewed/Acked it (I gave a Reviewed-by today), so
it hasn't been merged yet, although it's probably in your tree :)


> Apologies for the inconvenience.

>

>>

>>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 14 ++++++++------

>>  1 file changed, 8 insertions(+), 6 deletions(-)

>>

>> diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc

>> index 1b8127d2eb69..27015644ba2f 100644

>> --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc

>> +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc

>> @@ -343,19 +343,21 @@ [PcdsFixedAtBuild.common]

>>    #  DEBUG_WARN      0x00000002  // Warnings

>>    #  DEBUG_LOAD      0x00000004  // Load events

>>    #  DEBUG_FS        0x00000008  // EFI File system

>> -  #  DEBUG_POOL      0x00000010  // Alloc & Free's

>> -  #  DEBUG_PAGE      0x00000020  // Alloc & Free's

>> -  #  DEBUG_INFO      0x00000040  // Verbose

>> -  #  DEBUG_DISPATCH  0x00000080  // PEI/DXE Dispatchers

>> +  #  DEBUG_POOL      0x00000010  // Alloc & Free (pool)

>> +  #  DEBUG_PAGE      0x00000020  // Alloc & Free (page)

>> +  #  DEBUG_INFO      0x00000040  // Informational debug messages

>> +  #  DEBUG_DISPATCH  0x00000080  // PEI/DXE/SMM Dispatchers

>>    #  DEBUG_VARIABLE  0x00000100  // Variable

>>    #  DEBUG_BM        0x00000400  // Boot Manager

>>    #  DEBUG_BLKIO     0x00001000  // BlkIo Driver

>> -  #  DEBUG_NET       0x00004000  // SNI Driver

>> +  #  DEBUG_NET       0x00004000  // SNP Driver

>>    #  DEBUG_UNDI      0x00010000  // UNDI Driver

>> -  #  DEBUG_LOADFILE  0x00020000  // UNDI Driver

>> +  #  DEBUG_LOADFILE  0x00020000  // LoadFile

>>    #  DEBUG_EVENT     0x00080000  // Event messages

>>    #  DEBUG_GCD       0x00100000  // Global Coherency Database changes

>>    #  DEBUG_CACHE     0x00200000  // Memory range cachability changes

>> +  #  DEBUG_VERBOSE   0x00400000  // Detailed debug messages that may

>> +  #                              // significantly impact boot performance

>>    #  DEBUG_ERROR     0x80000000  // Error

>>    gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F

>>

>> --

>> 1.8.3.1

>>

>>

> _______________________________________________

> edk2-devel mailing list

> edk2-devel@lists.01.org

> https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Leif Lindholm March 1, 2016, 2:14 p.m. | #3
On Tue, Mar 01, 2016 at 02:07:42PM +0000, Ryan Harkin wrote:
> On 1 March 2016 at 10:10, Leif Lindholm <leif.lindholm@linaro.org> wrote:

> > On Tue, Mar 01, 2016 at 10:58:28AM +0100, Laszlo Ersek wrote:

> >> Suggested-by: Leif Lindholm <leif.lindholm@linaro.org>

> >> Cc: Leif Lindholm <leif.lindholm@linaro.org>

> >> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> >> Contributed-under: TianoCore Contribution Agreement 1.0

> >> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

> >> ---

> >>

> >> Notes:

> >>     not build tested

> >

> > *Twitch*

> >

> > This file shouldn't even be here anymore - it now lives in

> > OpenPlatformPkg with the platforms, and we don't want accidental loss

> > of synchronization. I'll submit a separate patch condemining it to the

> > fate I thought it had already met.

> >

> > (grep returns nothing in current tree)

> >

> 

> You've send a patch to remove it from the tree to the list, Ard,

> Laszlo and me have Reviewed/Acked it (I gave a Reviewed-by today), so

> it hasn't been merged yet, although it's probably in your tree :)


https://github.com/tianocore/edk2/commit/5f67844615baa56fd9e67597a00adcc6b7387ef9
*cough* I might have pushed it before waiting for all ACKs *cough*

> > Apologies for the inconvenience.

> >

> >>

> >>  ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 14 ++++++++------

> >>  1 file changed, 8 insertions(+), 6 deletions(-)

> >>

> >> diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc

> >> index 1b8127d2eb69..27015644ba2f 100644

> >> --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc

> >> +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc

> >> @@ -343,19 +343,21 @@ [PcdsFixedAtBuild.common]

> >>    #  DEBUG_WARN      0x00000002  // Warnings

> >>    #  DEBUG_LOAD      0x00000004  // Load events

> >>    #  DEBUG_FS        0x00000008  // EFI File system

> >> -  #  DEBUG_POOL      0x00000010  // Alloc & Free's

> >> -  #  DEBUG_PAGE      0x00000020  // Alloc & Free's

> >> -  #  DEBUG_INFO      0x00000040  // Verbose

> >> -  #  DEBUG_DISPATCH  0x00000080  // PEI/DXE Dispatchers

> >> +  #  DEBUG_POOL      0x00000010  // Alloc & Free (pool)

> >> +  #  DEBUG_PAGE      0x00000020  // Alloc & Free (page)

> >> +  #  DEBUG_INFO      0x00000040  // Informational debug messages

> >> +  #  DEBUG_DISPATCH  0x00000080  // PEI/DXE/SMM Dispatchers

> >>    #  DEBUG_VARIABLE  0x00000100  // Variable

> >>    #  DEBUG_BM        0x00000400  // Boot Manager

> >>    #  DEBUG_BLKIO     0x00001000  // BlkIo Driver

> >> -  #  DEBUG_NET       0x00004000  // SNI Driver

> >> +  #  DEBUG_NET       0x00004000  // SNP Driver

> >>    #  DEBUG_UNDI      0x00010000  // UNDI Driver

> >> -  #  DEBUG_LOADFILE  0x00020000  // UNDI Driver

> >> +  #  DEBUG_LOADFILE  0x00020000  // LoadFile

> >>    #  DEBUG_EVENT     0x00080000  // Event messages

> >>    #  DEBUG_GCD       0x00100000  // Global Coherency Database changes

> >>    #  DEBUG_CACHE     0x00200000  // Memory range cachability changes

> >> +  #  DEBUG_VERBOSE   0x00400000  // Detailed debug messages that may

> >> +  #                              // significantly impact boot performance

> >>    #  DEBUG_ERROR     0x80000000  // Error

> >>    gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F

> >>

> >> --

> >> 1.8.3.1

> >>

> >>

> > _______________________________________________

> > edk2-devel mailing list

> > edk2-devel@lists.01.org

> > https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Leif Lindholm March 2, 2016, 10:06 a.m. | #4
On Tue, Mar 01, 2016 at 11:30:44PM -0800, Jordan Justen wrote:
> (Adding Mike)

> On 2016-03-01 02:10:14, Leif Lindholm wrote:

> > On Tue, Mar 01, 2016 at 10:58:28AM +0100, Laszlo Ersek wrote:

> > > Suggested-by: Leif Lindholm <leif.lindholm@linaro.org>

> > > Cc: Leif Lindholm <leif.lindholm@linaro.org>

> > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> > > Contributed-under: TianoCore Contribution Agreement 1.0

> > > Signed-off-by: Laszlo Ersek <lersek@redhat.com>

> > > ---

> > > 

> > > Notes:

> > >     not build tested

> > 

> > *Twitch*

> > 

> > This file shouldn't even be here anymore - it now lives in

> > OpenPlatformPkg with the platforms, and we don't want accidental loss

> > of synchronization.

> 

> I guess you mean this?

> 

> https://github.com/96boards/OpenPlatformPkg


No, I most spectacularly do not.
The existance of any UEFI-related code whatsoever hosted under
96boards is a sad mistake I've been working for some time to rectify,
and Haojian is now working hard on. </rant>

https://git.linaro.org/uefi/OpenPlatformPkg.git is my repository,
which the above originated as a clone of.

> This is related to a lack of a DriversPkg in EDK II?


Yes, until there is a Plan, I'm staging things in my own tree.

This also lets me defer a proper solution to the problem of certain
binary-only modules that some platform/component vendors still insist
on.

Regards,

Leif

> > I'll submit a separate patch condemining it to the

> > fate I thought it had already met.

> > 

> > (grep returns nothing in current tree)

> > 

> > Apologies for the inconvenience.

> > 

> > > 

> > >  ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc | 14 ++++++++------

> > >  1 file changed, 8 insertions(+), 6 deletions(-)

> > > 

> > > diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc

> > > index 1b8127d2eb69..27015644ba2f 100644

> > > --- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc

> > > +++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc

> > > @@ -343,19 +343,21 @@ [PcdsFixedAtBuild.common]

> > >    #  DEBUG_WARN      0x00000002  // Warnings

> > >    #  DEBUG_LOAD      0x00000004  // Load events

> > >    #  DEBUG_FS        0x00000008  // EFI File system

> > > -  #  DEBUG_POOL      0x00000010  // Alloc & Free's

> > > -  #  DEBUG_PAGE      0x00000020  // Alloc & Free's

> > > -  #  DEBUG_INFO      0x00000040  // Verbose

> > > -  #  DEBUG_DISPATCH  0x00000080  // PEI/DXE Dispatchers

> > > +  #  DEBUG_POOL      0x00000010  // Alloc & Free (pool)

> > > +  #  DEBUG_PAGE      0x00000020  // Alloc & Free (page)

> > > +  #  DEBUG_INFO      0x00000040  // Informational debug messages

> > > +  #  DEBUG_DISPATCH  0x00000080  // PEI/DXE/SMM Dispatchers

> > >    #  DEBUG_VARIABLE  0x00000100  // Variable

> > >    #  DEBUG_BM        0x00000400  // Boot Manager

> > >    #  DEBUG_BLKIO     0x00001000  // BlkIo Driver

> > > -  #  DEBUG_NET       0x00004000  // SNI Driver

> > > +  #  DEBUG_NET       0x00004000  // SNP Driver

> > >    #  DEBUG_UNDI      0x00010000  // UNDI Driver

> > > -  #  DEBUG_LOADFILE  0x00020000  // UNDI Driver

> > > +  #  DEBUG_LOADFILE  0x00020000  // LoadFile

> > >    #  DEBUG_EVENT     0x00080000  // Event messages

> > >    #  DEBUG_GCD       0x00100000  // Global Coherency Database changes

> > >    #  DEBUG_CACHE     0x00200000  // Memory range cachability changes

> > > +  #  DEBUG_VERBOSE   0x00400000  // Detailed debug messages that may

> > > +  #                              // significantly impact boot performance

> > >    #  DEBUG_ERROR     0x80000000  // Error

> > >    gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F

> > >  

> > > -- 

> > > 1.8.3.1

> > > 

> > > 

> > _______________________________________________

> > edk2-devel mailing list

> > edk2-devel@lists.01.org

> > https://lists.01.org/mailman/listinfo/edk2-devel

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Patch

diff --git a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc
index 1b8127d2eb69..27015644ba2f 100644
--- a/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc
+++ b/ArmPlatformPkg/ArmVExpressPkg/ArmVExpress.dsc.inc
@@ -343,19 +343,21 @@  [PcdsFixedAtBuild.common]
   #  DEBUG_WARN      0x00000002  // Warnings
   #  DEBUG_LOAD      0x00000004  // Load events
   #  DEBUG_FS        0x00000008  // EFI File system
-  #  DEBUG_POOL      0x00000010  // Alloc & Free's
-  #  DEBUG_PAGE      0x00000020  // Alloc & Free's
-  #  DEBUG_INFO      0x00000040  // Verbose
-  #  DEBUG_DISPATCH  0x00000080  // PEI/DXE Dispatchers
+  #  DEBUG_POOL      0x00000010  // Alloc & Free (pool)
+  #  DEBUG_PAGE      0x00000020  // Alloc & Free (page)
+  #  DEBUG_INFO      0x00000040  // Informational debug messages
+  #  DEBUG_DISPATCH  0x00000080  // PEI/DXE/SMM Dispatchers
   #  DEBUG_VARIABLE  0x00000100  // Variable
   #  DEBUG_BM        0x00000400  // Boot Manager
   #  DEBUG_BLKIO     0x00001000  // BlkIo Driver
-  #  DEBUG_NET       0x00004000  // SNI Driver
+  #  DEBUG_NET       0x00004000  // SNP Driver
   #  DEBUG_UNDI      0x00010000  // UNDI Driver
-  #  DEBUG_LOADFILE  0x00020000  // UNDI Driver
+  #  DEBUG_LOADFILE  0x00020000  // LoadFile
   #  DEBUG_EVENT     0x00080000  // Event messages
   #  DEBUG_GCD       0x00100000  // Global Coherency Database changes
   #  DEBUG_CACHE     0x00200000  // Memory range cachability changes
+  #  DEBUG_VERBOSE   0x00400000  // Detailed debug messages that may
+  #                              // significantly impact boot performance
   #  DEBUG_ERROR     0x80000000  // Error
   gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0x8000000F