diff mbox series

[libgpiod] tools: tests: remove leftover echo

Message ID 20221212093510.146129-1-brgl@bgdev.pl
State New
Headers show
Series [libgpiod] tools: tests: remove leftover echo | expand

Commit Message

Bartosz Golaszewski Dec. 12, 2022, 9:35 a.m. UTC
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

This looks like some unneeded leftover from the development that was
missed because bats intercepts all echo output.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
 tools/gpio-tools-test.bats | 1 -
 1 file changed, 1 deletion(-)

Comments

Kent Gibson Dec. 12, 2022, 9:48 a.m. UTC | #1
On Mon, Dec 12, 2022 at 10:35:10AM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> 
> This looks like some unneeded leftover from the development that was
> missed because bats intercepts all echo output.
> 

Indeed - you only see it when a test fails, and I obviously missed
removing it after getting the offending test to pass.

Reviewed-by: Kent Gibson <warthog618@gmail.com>

> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>  tools/gpio-tools-test.bats | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/tools/gpio-tools-test.bats b/tools/gpio-tools-test.bats
> index bf7f3d6..adbce94 100755
> --- a/tools/gpio-tools-test.bats
> +++ b/tools/gpio-tools-test.bats
> @@ -392,7 +392,6 @@ request_release_line() {
>  
>  	run_tool gpioinfo
>  
> -    echo "$output"
>  	output_contains_line "${GPIOSIM_CHIP_NAME[sim0]} - 4 lines:"
>  	output_contains_line "${GPIOSIM_CHIP_NAME[sim1]} - 8 lines:"
>  	output_regex_match "\\s+line\\s+0:\\s+unnamed\\s+input"
> -- 
> 2.37.2
>
diff mbox series

Patch

diff --git a/tools/gpio-tools-test.bats b/tools/gpio-tools-test.bats
index bf7f3d6..adbce94 100755
--- a/tools/gpio-tools-test.bats
+++ b/tools/gpio-tools-test.bats
@@ -392,7 +392,6 @@  request_release_line() {
 
 	run_tool gpioinfo
 
-    echo "$output"
 	output_contains_line "${GPIOSIM_CHIP_NAME[sim0]} - 4 lines:"
 	output_contains_line "${GPIOSIM_CHIP_NAME[sim1]} - 8 lines:"
 	output_regex_match "\\s+line\\s+0:\\s+unnamed\\s+input"