[v1,4/4] pinctrl: intel: Add ~4k bias support

Message ID	20221219123208.5505-4-andriy.shevchenko@linux.intel.com
State	Accepted
Commit	346c8364613a9862323386d75f511785696fbe52
Headers	show Return-Path: <linux-gpio-owner@kernel.org> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Mika Westerberg <mika.westerberg@linux.intel.com>, Andy Shevchenko <andy@kernel.org>, Linus Walleij <linus.walleij@linaro.org> Subject: [PATCH v1 4/4] pinctrl: intel: Add ~4k bias support Date: Mon, 19 Dec 2022 14:32:08 +0200 Message-Id: <20221219123208.5505-4-andriy.shevchenko@linux.intel.com> In-Reply-To: <20221219123208.5505-1-andriy.shevchenko@linux.intel.com> References: <20221219123208.5505-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	[v1,1/4] pinctrl: intel: Add default case to intel_config_set_pull() \| expand [v1,1/4] pinctrl: intel: Add default case to intel_config_set_pull() [v1,2/4] pinctrl: intel: Deduplicate some code in intel_config_set_pull() [v1,3/4] pinctrl: intel: Add definitions to all possible biases [v1,4/4] pinctrl: intel: Add ~4k bias support

Message ID

20221219123208.5505-4-andriy.shevchenko@linux.intel.com

State

Accepted

Commit

346c8364613a9862323386d75f511785696fbe52

Headers

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
        Andy Shevchenko <andy@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>
Subject: [PATCH v1 4/4] pinctrl: intel: Add ~4k bias support
Date: Mon, 19 Dec 2022 14:32:08 +0200
Message-Id: <20221219123208.5505-4-andriy.shevchenko@linux.intel.com>
In-Reply-To: <20221219123208.5505-1-andriy.shevchenko@linux.intel.com>
References: <20221219123208.5505-1-andriy.shevchenko@linux.intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

[v1,1/4] pinctrl: intel: Add default case to intel_config_set_pull() | expand

Commit Message

Andy Shevchenko Dec. 19, 2022, 12:32 p.m. UTC

All versions that have 20k and 5k resistance, i.e. all that
the driver supports, may support ~4k when the above mentioned
are connected in parallel. Add such a support.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/pinctrl/intel/pinctrl-intel.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/pinctrl-intel.c
index 8ecb7ca7fbac..5e21b0a96efe 100644
--- a/drivers/pinctrl/intel/pinctrl-intel.c
+++ b/drivers/pinctrl/intel/pinctrl-intel.c
@@ -577,6 +577,9 @@  static int intel_config_get_pull(struct intel_pinctrl *pctrl, unsigned int pin,
 		case PADCFG1_TERM_1K:
 			*arg = 1000;
 			break;
+		case PADCFG1_TERM_4K:
+			*arg = 4000;
+			break;
 		case PADCFG1_TERM_5K:
 			*arg = 5000;
 			break;
@@ -602,6 +605,9 @@  static int intel_config_get_pull(struct intel_pinctrl *pctrl, unsigned int pin,
 				return -EINVAL;
 			*arg = 1000;
 			break;
+		case PADCFG1_TERM_4K:
+			*arg = 4000;
+			break;
 		case PADCFG1_TERM_5K:
 			*arg = 5000;
 			break;
@@ -709,6 +715,9 @@  static int intel_config_set_pull(struct intel_pinctrl *pctrl, unsigned int pin,
 		case 5000:
 			value |= PADCFG1_TERM_5K << PADCFG1_TERM_SHIFT;
 			break;
+		case 4000:
+			value |= PADCFG1_TERM_4K << PADCFG1_TERM_SHIFT;
+			break;
 		case 1000:
 			value |= PADCFG1_TERM_1K << PADCFG1_TERM_SHIFT;
 			break;
@@ -731,6 +740,9 @@  static int intel_config_set_pull(struct intel_pinctrl *pctrl, unsigned int pin,
 		case 5000:
 			value |= PADCFG1_TERM_5K << PADCFG1_TERM_SHIFT;
 			break;
+		case 4000:
+			value |= PADCFG1_TERM_4K << PADCFG1_TERM_SHIFT;
+			break;
 		case 1000:
 			if (!(community->features & PINCTRL_FEATURE_1K_PD)) {
 				ret = -EINVAL;

[v1,4/4] pinctrl: intel: Add ~4k bias support

Commit Message

Patch