mbox

[PULL,v2,0/6] testing updates

Message ID 20221223172135.3450109-1-alex.bennee@linaro.org
State New
Headers show

Pull-request

https://gitlab.com/stsquad/qemu.git tags/pull-testing-next-231222-1

Message

Alex Bennée Dec. 23, 2022, 5:21 p.m. UTC
The following changes since commit 222059a0fccf4af3be776fe35a5ea2d6a68f9a0b:

  Merge tag 'pull-ppc-20221221' of https://gitlab.com/danielhb/qemu into staging (2022-12-21 18:08:09 +0000)

are available in the Git repository at:

  https://gitlab.com/stsquad/qemu.git tags/pull-testing-next-231222-1

for you to fetch changes up to 3b4f911921e4233df0ba78d4acd2077da0b144ef:

  gitlab-ci: Disable docs and GUIs for the build-tci and build-tcg-disabled jobs (2022-12-23 15:17:13 +0000)

----------------------------------------------------------------
testing updates:

  - fix minor shell-ism that can break check-tcg
  - turn off verbose logging on custom runners
  - make configure echo call in CI
  - fix unused variable in linux-test
  - add binary compiler docker image for hexagon
  - disable doc and gui builds for tci and disable-tcg builds

----------------------------------------------------------------
Alex Bennée (3):
      gitlab: turn off verbose logging for make check on custom runners
      configure: repeat ourselves for the benefit of CI
      tests/tcg: fix unused variable in linux-test

Mukilan Thiyagarajan (2):
      configure: Fix check-tcg not executing any tests
      tests/docker: use prebuilt toolchain for debian-hexagon-cross

Thomas Huth (1):
      gitlab-ci: Disable docs and GUIs for the build-tci and build-tcg-disabled jobs

 configure                                          |  11 +-
 tests/tcg/multiarch/linux/linux-test.c             |   6 +-
 .gitlab-ci.d/buildtest.yml                         |  10 +-
 .gitlab-ci.d/container-cross.yml                   |  22 +---
 .gitlab-ci.d/custom-runners/ubuntu-20.04-s390x.yml |  12 +-
 .../custom-runners/ubuntu-22.04-aarch32.yml        |   2 +-
 .../custom-runners/ubuntu-22.04-aarch64.yml        |  12 +-
 MAINTAINERS                                        |   1 -
 tests/docker/Makefile.include                      |   4 -
 .../debian-hexagon-cross.d/build-toolchain.sh      | 141 ---------------------
 .../docker/dockerfiles/debian-hexagon-cross.docker |  53 +++-----
 11 files changed, 47 insertions(+), 227 deletions(-)
 delete mode 100755 tests/docker/dockerfiles/debian-hexagon-cross.d/build-toolchain.sh

Comments

Peter Maydell Jan. 3, 2023, 4:10 p.m. UTC | #1
On Fri, 23 Dec 2022 at 17:21, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> The following changes since commit 222059a0fccf4af3be776fe35a5ea2d6a68f9a0b:
>
>   Merge tag 'pull-ppc-20221221' of https://gitlab.com/danielhb/qemu into staging (2022-12-21 18:08:09 +0000)
>
> are available in the Git repository at:
>
>   https://gitlab.com/stsquad/qemu.git tags/pull-testing-next-231222-1
>
> for you to fetch changes up to 3b4f911921e4233df0ba78d4acd2077da0b144ef:
>
>   gitlab-ci: Disable docs and GUIs for the build-tci and build-tcg-disabled jobs (2022-12-23 15:17:13 +0000)
>
> ----------------------------------------------------------------
> testing updates:
>
>   - fix minor shell-ism that can break check-tcg
>   - turn off verbose logging on custom runners
>   - make configure echo call in CI
>   - fix unused variable in linux-test
>   - add binary compiler docker image for hexagon
>   - disable doc and gui builds for tci and disable-tcg builds
>
> ----------------------------------------------------------------

The msys2-64bit job failed with a weird 'missing terminating "'
compiler error on ui/shader/texture-blit-vert.h:

https://gitlab.com/qemu-project/qemu/-/jobs/3547023328

as did msys2-32-bit:

https://gitlab.com/qemu-project/qemu/-/jobs/3547023329

Any idea? Is this just an existing error that's been masked
by the msys2 jobs consistently timing out before they get
to it ?

thanks
-- PMM
Alex Bennée Jan. 3, 2023, 5:47 p.m. UTC | #2
Peter Maydell <peter.maydell@linaro.org> writes:

> On Fri, 23 Dec 2022 at 17:21, Alex Bennée <alex.bennee@linaro.org> wrote:
>>
>> The following changes since commit 222059a0fccf4af3be776fe35a5ea2d6a68f9a0b:
>>
>>   Merge tag 'pull-ppc-20221221' of https://gitlab.com/danielhb/qemu
>> into staging (2022-12-21 18:08:09 +0000)
>>
>> are available in the Git repository at:
>>
>>   https://gitlab.com/stsquad/qemu.git tags/pull-testing-next-231222-1
>>
>> for you to fetch changes up to 3b4f911921e4233df0ba78d4acd2077da0b144ef:
>>
>>   gitlab-ci: Disable docs and GUIs for the build-tci and
>> build-tcg-disabled jobs (2022-12-23 15:17:13 +0000)
>>
>> ----------------------------------------------------------------
>> testing updates:
>>
>>   - fix minor shell-ism that can break check-tcg
>>   - turn off verbose logging on custom runners
>>   - make configure echo call in CI
>>   - fix unused variable in linux-test
>>   - add binary compiler docker image for hexagon
>>   - disable doc and gui builds for tci and disable-tcg builds
>>
>> ----------------------------------------------------------------
>
> The msys2-64bit job failed with a weird 'missing terminating "'
> compiler error on ui/shader/texture-blit-vert.h:
>
> https://gitlab.com/qemu-project/qemu/-/jobs/3547023328
>
> as did msys2-32-bit:
>
> https://gitlab.com/qemu-project/qemu/-/jobs/3547023329
>
> Any idea? Is this just an existing error that's been masked
> by the msys2 jobs consistently timing out before they get
> to it ?

It ran fine when I pushed the branch:

  https://gitlab.com/stsquad/qemu/-/jobs/3519255299

but I can't see it building the object file ui_shader.c.obj in my build
so I wonder if the builder has updated its development libraries since?
I think it is a generated file.

>
> thanks
> -- PMM
Thomas Huth Jan. 4, 2023, 8:26 a.m. UTC | #3
On 03/01/2023 18.47, Alex Bennée wrote:
> 
> Peter Maydell <peter.maydell@linaro.org> writes:
> 
>> On Fri, 23 Dec 2022 at 17:21, Alex Bennée <alex.bennee@linaro.org> wrote:
>>>
>>> The following changes since commit 222059a0fccf4af3be776fe35a5ea2d6a68f9a0b:
>>>
>>>    Merge tag 'pull-ppc-20221221' of https://gitlab.com/danielhb/qemu
>>> into staging (2022-12-21 18:08:09 +0000)
>>>
>>> are available in the Git repository at:
>>>
>>>    https://gitlab.com/stsquad/qemu.git tags/pull-testing-next-231222-1
>>>
>>> for you to fetch changes up to 3b4f911921e4233df0ba78d4acd2077da0b144ef:
>>>
>>>    gitlab-ci: Disable docs and GUIs for the build-tci and
>>> build-tcg-disabled jobs (2022-12-23 15:17:13 +0000)
>>>
>>> ----------------------------------------------------------------
>>> testing updates:
>>>
>>>    - fix minor shell-ism that can break check-tcg
>>>    - turn off verbose logging on custom runners
>>>    - make configure echo call in CI
>>>    - fix unused variable in linux-test
>>>    - add binary compiler docker image for hexagon
>>>    - disable doc and gui builds for tci and disable-tcg builds
>>>
>>> ----------------------------------------------------------------
>>
>> The msys2-64bit job failed with a weird 'missing terminating "'
>> compiler error on ui/shader/texture-blit-vert.h:
>>
>> https://gitlab.com/qemu-project/qemu/-/jobs/3547023328
>>
>> as did msys2-32-bit:
>>
>> https://gitlab.com/qemu-project/qemu/-/jobs/3547023329
>>
>> Any idea? Is this just an existing error that's been masked
>> by the msys2 jobs consistently timing out before they get
>> to it ?
> 
> It ran fine when I pushed the branch:
> 
>    https://gitlab.com/stsquad/qemu/-/jobs/3519255299
> 
> but I can't see it building the object file ui_shader.c.obj in my build
> so I wonder if the builder has updated its development libraries since?
> I think it is a generated file.

FWIW, I also ran into this problem independently from this pull request 
while trying to increase the timeout of the jobs to 80 minutes:

  https://gitlab.com/thuth/qemu/-/jobs/3546685202
  https://gitlab.com/thuth/qemu/-/jobs/3546685203

So I don't think it is related to this pull request but something different.

Diff'ing the output between Alex' and my run, I can see that Alex log has:

  Has header "epoxy/egl.h" with dependency epoxy: NO
  ...
  OpenGL support (epoxy)       : NO

While my broken run has:

  Has header "epoxy/egl.h" with dependency epoxy: YES
  ...
  OpenGL support (epoxy)       : YES 1.5.10

So seems like something changed in the build environment, so that epoxy is 
now enabled there.

I guess we should disable it manually there again for the time being, until 
someone has figured out the real fix?

  Thomas
Peter Maydell Jan. 4, 2023, 6:56 p.m. UTC | #4
On Fri, 23 Dec 2022 at 17:21, Alex Bennée <alex.bennee@linaro.org> wrote:
>
> The following changes since commit 222059a0fccf4af3be776fe35a5ea2d6a68f9a0b:
>
>   Merge tag 'pull-ppc-20221221' of https://gitlab.com/danielhb/qemu into staging (2022-12-21 18:08:09 +0000)
>
> are available in the Git repository at:
>
>   https://gitlab.com/stsquad/qemu.git tags/pull-testing-next-231222-1
>
> for you to fetch changes up to 3b4f911921e4233df0ba78d4acd2077da0b144ef:
>
>   gitlab-ci: Disable docs and GUIs for the build-tci and build-tcg-disabled jobs (2022-12-23 15:17:13 +0000)
>
> ----------------------------------------------------------------
> testing updates:
>
>   - fix minor shell-ism that can break check-tcg
>   - turn off verbose logging on custom runners
>   - make configure echo call in CI
>   - fix unused variable in linux-test
>   - add binary compiler docker image for hexagon
>   - disable doc and gui builds for tci and disable-tcg builds
>

Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/8.0
for any user-visible changes.

-- PMM