diff mbox series

[v2] serial: linflexuart: remove redundant uart type _assignment_

Message ID 20230103170948.3777-1-sensor1010@163.com
State Superseded
Headers show
Series [v2] serial: linflexuart: remove redundant uart type _assignment_ | expand

Commit Message

Lizhe Jan. 3, 2023, 5:09 p.m. UTC 
in linflex_config_port() the member variable type will be
assigned again. see linflex_connfig_port()

Signed-off-by: lizhe <sensor1010@163.com>
Acked-by: Jiri Slaby <jslaby@suse.com>
---
 drivers/tty/serial/fsl_linflexuart.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Ilpo Järvinen Jan. 3, 2023, 6:56 p.m. UTC | #1 
On Tue, 3 Jan 2023, lizhe wrote:

> 	in linflex_config_port() the member variable type will be

Rmoeve these extra spaces and start right from the leftmost column. 

And don't include the underscores (_) into the shortlog around assignment. 
Jiri just used the underscores to highlight for you what he considered 
important part to be corrected.


> assigned again. see linflex_connfig_port()
> 
> Signed-off-by: lizhe <sensor1010@163.com>
> Acked-by: Jiri Slaby <jslaby@suse.com>
> ---

When sending version xx, please remember to include the list of changes 
made per version (they go here below the first --- marker, see mailinglist 
archives for format examples if you don't know that alread).
diff mbox series

Patch

diff --git a/drivers/tty/serial/fsl_linflexuart.c b/drivers/tty/serial/fsl_linflexuart.c
index 6fc21b6684e6..34400cc6ac7f 100644
--- a/drivers/tty/serial/fsl_linflexuart.c
+++ b/drivers/tty/serial/fsl_linflexuart.c
@@ -837,7 +837,6 @@  static int linflex_probe(struct platform_device *pdev)
 		return PTR_ERR(sport->membase);
 
 	sport->dev = &pdev->dev;
-	sport->type = PORT_LINFLEXUART;
 	sport->iotype = UPIO_MEM;
 	sport->irq = platform_get_irq(pdev, 0);
 	sport->ops = &linflex_pops;