| Message ID | 20230107144149.5743-2-klaus.kudielka@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/2] Revert "ARM: dts: armada-38x: Fix compatible string for gpios" | expand |
On Sat, Jan 07, 2023 at 03:41:49PM +0100, Klaus Kudielka wrote: > This reverts commit d10886a4e6f85ee18d47a1066a52168461370ded. > > If compatible = "marvell,armadaxp-gpio", the reg property requires a > second (address, size) pair, which points to the per-CPU interrupt > registers <0x18800 0x30> / <0x18840 0x30>. > > Furthermore: > Commit 5f79c651e81e explains very well, why the gpio-mvebu driver does not > work reliably with per-CPU interrupts. > Commit 988c8c0cd04d deprecates compatible = marvell,armadaxp-gpio for this > reason. > > Signed-off-by: Klaus Kudielka <klaus.kudielka@gmail.com> Reviewed-by: Andrew Lunn <andrew@lunn.ch> Andrew
Andrew Lunn <andrew@lunn.ch> writes: > On Sat, Jan 07, 2023 at 03:41:49PM +0100, Klaus Kudielka wrote: >> This reverts commit d10886a4e6f85ee18d47a1066a52168461370ded. >> >> If compatible = "marvell,armadaxp-gpio", the reg property requires a >> second (address, size) pair, which points to the per-CPU interrupt >> registers <0x18800 0x30> / <0x18840 0x30>. >> >> Furthermore: >> Commit 5f79c651e81e explains very well, why the gpio-mvebu driver does not >> work reliably with per-CPU interrupts. >> Commit 988c8c0cd04d deprecates compatible = marvell,armadaxp-gpio for this >> reason. >> >> Signed-off-by: Klaus Kudielka <klaus.kudielka@gmail.com> > > Reviewed-by: Andrew Lunn <andrew@lunn.ch> Applied on mvebu/fixes Thanks, Gregory > > Andrew
diff --git a/arch/arm/boot/dts/armada-39x.dtsi b/arch/arm/boot/dts/armada-39x.dtsi index 1e05208d9f..9d1cac49c0 100644 --- a/arch/arm/boot/dts/armada-39x.dtsi +++ b/arch/arm/boot/dts/armada-39x.dtsi @@ -213,7 +213,7 @@ nand_pins: nand-pins { }; gpio0: gpio@18100 { - compatible = "marvell,armadaxp-gpio", "marvell,orion-gpio"; + compatible = "marvell,orion-gpio"; reg = <0x18100 0x40>; ngpios = <32>; gpio-controller; @@ -227,7 +227,7 @@ gpio0: gpio@18100 { }; gpio1: gpio@18140 { - compatible = "marvell,armadaxp-gpio", "marvell,orion-gpio"; + compatible = "marvell,orion-gpio"; reg = <0x18140 0x40>; ngpios = <28>; gpio-controller;
This reverts commit d10886a4e6f85ee18d47a1066a52168461370ded. If compatible = "marvell,armadaxp-gpio", the reg property requires a second (address, size) pair, which points to the per-CPU interrupt registers <0x18800 0x30> / <0x18840 0x30>. Furthermore: Commit 5f79c651e81e explains very well, why the gpio-mvebu driver does not work reliably with per-CPU interrupts. Commit 988c8c0cd04d deprecates compatible = marvell,armadaxp-gpio for this reason. Signed-off-by: Klaus Kudielka <klaus.kudielka@gmail.com> --- v1->v2: Be more explicit about the reg property. arch/arm/boot/dts/armada-39x.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)