| Message ID | 1458590679-31835-1-git-send-email-anders.roxell@linaro.org |
|---|---|
| State | Accepted |
| Commit | 182298b57c3d67ffecbf676a88220e3716a4e112 |
| Headers | show |
On Mon, Mar 21, 2016 at 5:04 PM, Anders Roxell <anders.roxell@linaro.org> wrote: > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > --- > pkg/debian/rules | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/pkg/debian/rules b/pkg/debian/rules > index 663bcdd..c155a5e 100755 > --- a/pkg/debian/rules > +++ b/pkg/debian/rules > @@ -13,6 +13,13 @@ include /usr/share/dpkg/default.mk > override_dh_autoreconf: > dh_autoreconf ./bootstrap > > +override_dh_auto_test: > +ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) > + dh_auto_configure -- --enable-static --enable-test-vald \ > + --enable-test-cpp --enable-test-helper > + $(MAKE) check > +endif > + > override_dh_auto_configure: > dh_auto_configure -- --enable-static > > -- > 2.1.4 The change itself is good, but I got one failure which might just be a side effect of using trunk: FAIL: ../../../test/validation/traffic_mngr/traffic_mngr_main Test: traffic_mngr_test_shaper ...FAILED 1. traffic_mngr.c:1630 - pkts_rcvd_in_order == pkts_sent Did you get that as well? Thanks,
On 22 March 2016 at 22:53, Ricardo Salveti <ricardo.salveti@linaro.org> wrote: > On Mon, Mar 21, 2016 at 5:04 PM, Anders Roxell <anders.roxell@linaro.org> wrote: >> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >> --- >> pkg/debian/rules | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/pkg/debian/rules b/pkg/debian/rules >> index 663bcdd..c155a5e 100755 >> --- a/pkg/debian/rules >> +++ b/pkg/debian/rules >> @@ -13,6 +13,13 @@ include /usr/share/dpkg/default.mk >> override_dh_autoreconf: >> dh_autoreconf ./bootstrap >> >> +override_dh_auto_test: >> +ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) >> + dh_auto_configure -- --enable-static --enable-test-vald \ >> + --enable-test-cpp --enable-test-helper >> + $(MAKE) check >> +endif >> + >> override_dh_auto_configure: >> dh_auto_configure -- --enable-static >> >> -- >> 2.1.4 > > The change itself is good, but I got one failure which might just be a > side effect of using trunk: > > FAIL: ../../../test/validation/traffic_mngr/traffic_mngr_main > > Test: traffic_mngr_test_shaper ...FAILED > 1. traffic_mngr.c:1630 - pkts_rcvd_in_order == pkts_sent > > Did you get that as well? No I didn't get that, strange. Did you try to run "./bootstrap && ./configure --enable-test-vald && make check"? Cheers, Anders
On Mon, Mar 21, 2016 at 5:04 PM, Anders Roxell <anders.roxell@linaro.org> wrote: > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > --- > pkg/debian/rules | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/pkg/debian/rules b/pkg/debian/rules > index 663bcdd..c155a5e 100755 > --- a/pkg/debian/rules > +++ b/pkg/debian/rules > @@ -13,6 +13,13 @@ include /usr/share/dpkg/default.mk > override_dh_autoreconf: > dh_autoreconf ./bootstrap > > +override_dh_auto_test: > +ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) > + dh_auto_configure -- --enable-static --enable-test-vald \ > + --enable-test-cpp --enable-test-helper > + $(MAKE) check > +endif > + > override_dh_auto_configure: > dh_auto_configure -- --enable-static > > -- > 2.1.4 Reviewed-by: Ricardo Salveti <ricardo.salveti@linaro.org>
On Wed, Mar 23, 2016 at 1:50 PM, Anders Roxell <anders.roxell@linaro.org> wrote: > On 22 March 2016 at 22:53, Ricardo Salveti <ricardo.salveti@linaro.org> wrote: >> On Mon, Mar 21, 2016 at 5:04 PM, Anders Roxell <anders.roxell@linaro.org> wrote: >>> Signed-off-by: Anders Roxell <anders.roxell@linaro.org> >>> --- >>> pkg/debian/rules | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/pkg/debian/rules b/pkg/debian/rules >>> index 663bcdd..c155a5e 100755 >>> --- a/pkg/debian/rules >>> +++ b/pkg/debian/rules >>> @@ -13,6 +13,13 @@ include /usr/share/dpkg/default.mk >>> override_dh_autoreconf: >>> dh_autoreconf ./bootstrap >>> >>> +override_dh_auto_test: >>> +ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) >>> + dh_auto_configure -- --enable-static --enable-test-vald \ >>> + --enable-test-cpp --enable-test-helper >>> + $(MAKE) check >>> +endif >>> + >>> override_dh_auto_configure: >>> dh_auto_configure -- --enable-static >>> >>> -- >>> 2.1.4 >> >> The change itself is good, but I got one failure which might just be a >> side effect of using trunk: >> >> FAIL: ../../../test/validation/traffic_mngr/traffic_mngr_main >> >> Test: traffic_mngr_test_shaper ...FAILED >> 1. traffic_mngr.c:1630 - pkts_rcvd_in_order == pkts_sent >> >> Did you get that as well? > > No I didn't get that, strange. > Did you try to run "./bootstrap && ./configure --enable-test-vald && > make check"? Fails as well, so approving the packaging change, and will track this separately. Thanks,
diff --git a/pkg/debian/rules b/pkg/debian/rules index 663bcdd..c155a5e 100755 --- a/pkg/debian/rules +++ b/pkg/debian/rules @@ -13,6 +13,13 @@ include /usr/share/dpkg/default.mk override_dh_autoreconf: dh_autoreconf ./bootstrap +override_dh_auto_test: +ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS))) + dh_auto_configure -- --enable-static --enable-test-vald \ + --enable-test-cpp --enable-test-helper + $(MAKE) check +endif + override_dh_auto_configure: dh_auto_configure -- --enable-static
Signed-off-by: Anders Roxell <anders.roxell@linaro.org> --- pkg/debian/rules | 7 +++++++ 1 file changed, 7 insertions(+)