| Message ID | 20230118153821.3853412-1-ilias.apalodimas@linaro.org |
|---|---|
| State | Accepted |
| Commit | 218a9917d6f0b11c41189ceb649cf04201325daf |
| Headers | show |
| Series | tee: optee: fix a print error on rng probing | expand |
Hi On 1/18/23 16:38, Ilias Apalodimas wrote: > If we fail to probe the optee-rng device, we print a wrong message > referring to the firmware tpm. > > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > --- > drivers/tee/optee/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c > index a813a84a4f16..88e23d252bcd 100644 > --- a/drivers/tee/optee/core.c > +++ b/drivers/tee/optee/core.c > @@ -850,7 +850,7 @@ static int optee_probe(struct udevice *dev) > ret = device_bind_driver_to_node(dev, "optee-rng", "optee-rng", > dev_ofnode(dev), NULL); > if (ret) > - dev_warn(dev, "ftpm_tee failed to bind: %d\n", ret); > + dev_warn(dev, "optee-rng failed to bind: %d\n", ret); > } > > return 0; I think you can add: Fixes: 476a3d58dfeb ("tee: optee: don't fail probe because of optee-rng") Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> Thanks Patrick
Thanks Patrick, On Wed, 18 Jan 2023 at 18:53, Patrick DELAUNAY <patrick.delaunay@foss.st.com> wrote: > > Hi > > On 1/18/23 16:38, Ilias Apalodimas wrote: > > If we fail to probe the optee-rng device, we print a wrong message > > referring to the firmware tpm. > > > > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > > --- > > drivers/tee/optee/core.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c > > index a813a84a4f16..88e23d252bcd 100644 > > --- a/drivers/tee/optee/core.c > > +++ b/drivers/tee/optee/core.c > > @@ -850,7 +850,7 @@ static int optee_probe(struct udevice *dev) > > ret = device_bind_driver_to_node(dev, "optee-rng", "optee-rng", > > dev_ofnode(dev), NULL); > > if (ret) > > - dev_warn(dev, "ftpm_tee failed to bind: %d\n", ret); > > + dev_warn(dev, "optee-rng failed to bind: %d\n", ret); > > } > > > > return 0; > > > I think you can add: > > Fixes: 476a3d58dfeb ("tee: optee: don't fail probe because of optee-rng") > > > Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> Sure I'll wait for additional reviews etc and respin Cheers /Ilias > > Thanks > Patrick > >
On Wed, 18 Jan 2023 at 19:54, Ilias Apalodimas <ilias.apalodimas@linaro.org> wrote: > > Thanks Patrick, > > On Wed, 18 Jan 2023 at 18:53, Patrick DELAUNAY > <patrick.delaunay@foss.st.com> wrote: > > > > Hi > > > > On 1/18/23 16:38, Ilias Apalodimas wrote: > > > If we fail to probe the optee-rng device, we print a wrong message > > > referring to the firmware tpm. > > > > > > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > > > --- > > > drivers/tee/optee/core.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c > > > index a813a84a4f16..88e23d252bcd 100644 > > > --- a/drivers/tee/optee/core.c > > > +++ b/drivers/tee/optee/core.c > > > @@ -850,7 +850,7 @@ static int optee_probe(struct udevice *dev) > > > ret = device_bind_driver_to_node(dev, "optee-rng", "optee-rng", > > > dev_ofnode(dev), NULL); > > > if (ret) > > > - dev_warn(dev, "ftpm_tee failed to bind: %d\n", ret); > > > + dev_warn(dev, "optee-rng failed to bind: %d\n", ret); > > > } > > > > > > return 0; > > > > > > I think you can add: > > > > Fixes: 476a3d58dfeb ("tee: optee: don't fail probe because of optee-rng") > > > > > > Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > > Sure I'll wait for additional reviews etc and respin Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org> Sorry for that :| etienne > > Cheers > /Ilias > > > > Thanks > > Patrick > > > >
On Wed, Jan 18, 2023 at 11:51 PM Etienne Carriere <etienne.carriere@linaro.org> wrote: > > On Wed, 18 Jan 2023 at 19:54, Ilias Apalodimas > <ilias.apalodimas@linaro.org> wrote: > > > > Thanks Patrick, > > > > On Wed, 18 Jan 2023 at 18:53, Patrick DELAUNAY > > <patrick.delaunay@foss.st.com> wrote: > > > > > > Hi > > > > > > On 1/18/23 16:38, Ilias Apalodimas wrote: > > > > If we fail to probe the optee-rng device, we print a wrong message > > > > referring to the firmware tpm. > > > > > > > > Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> > > > > --- > > > > drivers/tee/optee/core.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c > > > > index a813a84a4f16..88e23d252bcd 100644 > > > > --- a/drivers/tee/optee/core.c > > > > +++ b/drivers/tee/optee/core.c > > > > @@ -850,7 +850,7 @@ static int optee_probe(struct udevice *dev) > > > > ret = device_bind_driver_to_node(dev, "optee-rng", "optee-rng", > > > > dev_ofnode(dev), NULL); > > > > if (ret) > > > > - dev_warn(dev, "ftpm_tee failed to bind: %d\n", ret); > > > > + dev_warn(dev, "optee-rng failed to bind: %d\n", ret); > > > > } > > > > > > > > return 0; > > > > > > > > > I think you can add: > > > > > > Fixes: 476a3d58dfeb ("tee: optee: don't fail probe because of optee-rng") > > > > > > > > > Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com> > > > > Sure I'll wait for additional reviews etc and respin > > Reviewed-by: Etienne Carriere <etienne.carriere@linaro.org> Reviewed-by: Jens Wiklander <jens.wiklander@linaro.org> Cheers, Jens > Sorry for that :| > > etienne > > > > > Cheers > > /Ilias > > > > > > Thanks > > > Patrick > > > > > >
diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c index a813a84a4f16..88e23d252bcd 100644 --- a/drivers/tee/optee/core.c +++ b/drivers/tee/optee/core.c @@ -850,7 +850,7 @@ static int optee_probe(struct udevice *dev) ret = device_bind_driver_to_node(dev, "optee-rng", "optee-rng", dev_ofnode(dev), NULL); if (ret) - dev_warn(dev, "ftpm_tee failed to bind: %d\n", ret); + dev_warn(dev, "optee-rng failed to bind: %d\n", ret); } return 0;
If we fail to probe the optee-rng device, we print a wrong message referring to the firmware tpm. Signed-off-by: Ilias Apalodimas <ilias.apalodimas@linaro.org> --- drivers/tee/optee/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)