| Message ID | 20230118193015.911074-9-markyacoub@google.com |
|---|---|
| State | New |
| Headers | show |
| Series | drm/hdcp: Pull HDCP auth/exchange/check into helpers | expand |
On Wed, Jan 18, 2023 at 07:30:13PM +0000, Mark Yacoub wrote: > From: Sean Paul <seanpaul@chromium.org> > > This patch adds the bindings for the MSM DisplayPort HDCP registers > which are required to write the HDCP key into the display controller as > well as the registers to enable HDCP authentication/key > exchange/encryption. > > We'll use a new compatible string for this since the fields are optional. > > Cc: Rob Herring <robh@kernel.org> > Cc: Stephen Boyd <swboyd@chromium.org> > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Sean Paul <seanpaul@chromium.org> > Signed-off-by: Mark Yacoub <markyacoub@chromiu.org> Just a drive-by comment: Your mail address is missing an 'm' here. Perhaps check the rest of the series as well (checkpatch should catch this). Johan
On Wed, 18 Jan 2023 at 21:30, Mark Yacoub <markyacoub@chromium.org> wrote: > > From: Sean Paul <seanpaul@chromium.org> > > This patch adds the bindings for the MSM DisplayPort HDCP registers > which are required to write the HDCP key into the display controller as > well as the registers to enable HDCP authentication/key > exchange/encryption. > > We'll use a new compatible string for this since the fields are optional. This doesn't correspond to patch contents. > > Cc: Rob Herring <robh@kernel.org> This should be a > Cc: Stephen Boyd <swboyd@chromium.org> > Reviewed-by: Rob Herring <robh@kernel.org> > Signed-off-by: Sean Paul <seanpaul@chromium.org> > Signed-off-by: Mark Yacoub <markyacoub@chromiu.org> > Link: https://patchwork.freedesktop.org/patch/msgid/20210913175747.47456-13-sean@poorly.run #v1 > Link: https://patchwork.freedesktop.org/patch/msgid/20210915203834.1439-13-sean@poorly.run #v2 > Link: https://patchwork.freedesktop.org/patch/msgid/20211001151145.55916-13-sean@poorly.run #v3 > Link: https://patchwork.freedesktop.org/patch/msgid/20211105030434.2828845-13-sean@poorly.run #v4 > Link: https://patchwork.freedesktop.org/patch/msgid/20211115202153.117244-1-sean@poorly.run #v4.5 > Link: https://patchwork.freedesktop.org/patch/msgid/20220411204741.1074308-9-sean@poorly.run #v5 Please, clean this up. I suspect that the long list of previous iterations might belong to the cover letter, but not to the series themselves. > > Changes in v2: > -Drop register range names (Stephen) > -Fix yaml errors (Rob) > Changes in v3: > -Add new compatible string for dp-hdcp > -Add descriptions to reg > -Add minItems/maxItems to reg > -Make reg depend on the new hdcp compatible string > Changes in v4: > -Rebase on Bjorn's multi-dp patchset > Changes in v4.5: > -Remove maxItems from reg (Rob) > -Remove leading zeros in example (Rob) > Changes in v5: > -None > Changes in v6: > -Rebased: modify minItems instead of adding it as new line. > > --- > .../devicetree/bindings/display/msm/dp-controller.yaml | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > index f2515af8256f..17d741f9af86 100644 > --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml > @@ -24,13 +24,15 @@ properties: > - qcom,sm8350-dp > > reg: > - minItems: 4 > + minItems: 5 No. eDP uses 4 register blocks. > items: > - description: ahb register block > - description: aux register block > - description: link register block > - description: p0 register block > - description: p1 register block > + - description: (Optional) Registers for HDCP device key injection > + - description: (Optional) Registers for HDCP TrustZone interaction > > interrupts: > maxItems: 1 > @@ -154,7 +156,9 @@ examples: > <0xae90200 0x200>, > <0xae90400 0xc00>, > <0xae91000 0x400>, > - <0xae91400 0x400>; > + <0xae91400 0x400>, > + <0xaed1000 0x174>, > + <0xaee1000 0x2c>; > interrupt-parent = <&mdss>; > interrupts = <12>; > clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>, > -- > 2.39.0.246.g2a6d74b583-goog >
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml index f2515af8256f..17d741f9af86 100644 --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml @@ -24,13 +24,15 @@ properties: - qcom,sm8350-dp reg: - minItems: 4 + minItems: 5 items: - description: ahb register block - description: aux register block - description: link register block - description: p0 register block - description: p1 register block + - description: (Optional) Registers for HDCP device key injection + - description: (Optional) Registers for HDCP TrustZone interaction interrupts: maxItems: 1 @@ -154,7 +156,9 @@ examples: <0xae90200 0x200>, <0xae90400 0xc00>, <0xae91000 0x400>, - <0xae91400 0x400>; + <0xae91400 0x400>, + <0xaed1000 0x174>, + <0xaee1000 0x2c>; interrupt-parent = <&mdss>; interrupts = <12>; clocks = <&dispcc DISP_CC_MDSS_AHB_CLK>,