diff mbox

[edk2] OvmfPkg: remove PcdMaxHardwareErrorVariableSize from the DSC files

Message ID 1458903745-19768-1-git-send-email-lersek@redhat.com
State Accepted
Commit 29d0259e06ee0d0772d1068e02fb2242542fad2a
Headers show

Commit Message

Laszlo Ersek March 25, 2016, 11:02 a.m. UTC 
PcdMaxHardwareErrorVariableSize sets the size limit for individual
Hardware Error Record Variables (see "7.2.3 Hardware Error Record
Persistence" and "Appendix P, Hardware Error Record Persistence Usage" in
the UEFI-2.6 spec).

Since Hardware Error Record Persistence is an optional firmware feature,
according to the spec, and OVMF does not enable it -- it inherits
PcdHwErrStorageSize and PcdHardwareErrorRecordLevel with zero values --,
the PcdMaxHardwareErrorVariableSize setting in our DSC files has no
effect. Remove it in order to eliminate future confusion.

Cc: Jordan Justen <jordan.l.justen@intel.com>
Cc: Star Zeng <star.zeng@intel.com>
Suggested-by: Star Zeng <star.zeng@intel.com>
Ref: http://thread.gmane.org/gmane.comp.bios.edk2.devel/9743/focus=9780
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Laszlo Ersek <lersek@redhat.com>

Reviewed-by: Star Zeng <star.zeng@intel.com>

---
 OvmfPkg/OvmfPkgIa32.dsc    | 1 -
 OvmfPkg/OvmfPkgIa32X64.dsc | 1 -
 OvmfPkg/OvmfPkgX64.dsc     | 1 -
 3 files changed, 3 deletions(-)

-- 
1.8.3.1

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Laszlo Ersek April 6, 2016, 5:43 p.m. UTC | #1 
On 04/06/16 19:34, Jordan Justen wrote:
> Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>


Commit 29d0259e06ee0d0772d1068e02fb2242542fad2a.

Thanks!
Laszlo

> On 2016-03-25 04:02:25, Laszlo Ersek wrote:

>> PcdMaxHardwareErrorVariableSize sets the size limit for individual

>> Hardware Error Record Variables (see "7.2.3 Hardware Error Record

>> Persistence" and "Appendix P, Hardware Error Record Persistence Usage" in

>> the UEFI-2.6 spec).

>>

>> Since Hardware Error Record Persistence is an optional firmware feature,

>> according to the spec, and OVMF does not enable it -- it inherits

>> PcdHwErrStorageSize and PcdHardwareErrorRecordLevel with zero values --,

>> the PcdMaxHardwareErrorVariableSize setting in our DSC files has no

>> effect. Remove it in order to eliminate future confusion.

>>

>> Cc: Jordan Justen <jordan.l.justen@intel.com>

>> Cc: Star Zeng <star.zeng@intel.com>

>> Suggested-by: Star Zeng <star.zeng@intel.com>

>> Ref: http://thread.gmane.org/gmane.comp.bios.edk2.devel/9743/focus=9780

>> Contributed-under: TianoCore Contribution Agreement 1.0

>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>

>> Reviewed-by: Star Zeng <star.zeng@intel.com>

>> ---

>>  OvmfPkg/OvmfPkgIa32.dsc    | 1 -

>>  OvmfPkg/OvmfPkgIa32X64.dsc | 1 -

>>  OvmfPkg/OvmfPkgX64.dsc     | 1 -

>>  3 files changed, 3 deletions(-)

>>

>> diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc

>> index 5b56fe9d3911..1e25eb2718a1 100644

>> --- a/OvmfPkg/OvmfPkgIa32.dsc

>> +++ b/OvmfPkg/OvmfPkgIa32.dsc

>> @@ -382,7 +382,6 @@ [PcdsFixedAtBuild]

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeimPerFv|32

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800

>> -  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x8000

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0xe000

>>  

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0

>> diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc

>> index f81b2b81006f..98f0dc4439a6 100644

>> --- a/OvmfPkg/OvmfPkgIa32X64.dsc

>> +++ b/OvmfPkg/OvmfPkgIa32X64.dsc

>> @@ -387,7 +387,6 @@ [PcdsFixedAtBuild]

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeimPerFv|32

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800

>> -  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x8000

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0xe000

>>  

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0

>> diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc

>> index f5d84282866e..b70f81502db7 100644

>> --- a/OvmfPkg/OvmfPkgX64.dsc

>> +++ b/OvmfPkg/OvmfPkgX64.dsc

>> @@ -387,7 +387,6 @@ [PcdsFixedAtBuild]

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeimPerFv|32

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800

>> -  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x8000

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0xe000

>>  

>>    gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0

>> -- 

>> 1.8.3.1

>>


_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
diff mbox

Patch

diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc
index 5b56fe9d3911..1e25eb2718a1 100644
--- a/OvmfPkg/OvmfPkgIa32.dsc
+++ b/OvmfPkg/OvmfPkgIa32.dsc
@@ -382,7 +382,6 @@  [PcdsFixedAtBuild]
   gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeimPerFv|32
   gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
   gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800
-  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x8000
   gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0xe000
 
   gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0
diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc
index f81b2b81006f..98f0dc4439a6 100644
--- a/OvmfPkg/OvmfPkgIa32X64.dsc
+++ b/OvmfPkg/OvmfPkgIa32X64.dsc
@@ -387,7 +387,6 @@  [PcdsFixedAtBuild]
   gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeimPerFv|32
   gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
   gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800
-  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x8000
   gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0xe000
 
   gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0
diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
index f5d84282866e..b70f81502db7 100644
--- a/OvmfPkg/OvmfPkgX64.dsc
+++ b/OvmfPkg/OvmfPkgX64.dsc
@@ -387,7 +387,6 @@  [PcdsFixedAtBuild]
   gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeimPerFv|32
   gEfiMdeModulePkgTokenSpaceGuid.PcdMaxVariableSize|0x2000
   gEfiMdeModulePkgTokenSpaceGuid.PcdMaxAuthVariableSize|0x2800
-  gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x8000
   gEfiMdeModulePkgTokenSpaceGuid.PcdVariableStoreSize|0xe000
 
   gEfiMdeModulePkgTokenSpaceGuid.PcdVpdBaseAddress|0x0