| Message ID | 20230119231856.52014-1-joel@jms.id.au |
|---|---|
| State | Accepted |
| Commit | 287a344a11f1ebd31055cf9b22c88d7005f108d7 |
| Headers | show |
| Series | pinctrl: aspeed: Fix confusing types in return value | expand |
On Fri, Jan 20, 2023 at 12:19 AM Joel Stanley <joel@jms.id.au> wrote: > The function signature is int, but we return a bool. Instead return a > negative errno as the kerneldoc suggests. > > Fixes: 4d3d0e4272d8 ("pinctrl: Add core support for Aspeed SoCs") > Signed-off-by: Joel Stanley <joel@jms.id.au> Patch applied for fixes! Yours, Linus Walleij
diff --git a/drivers/pinctrl/aspeed/pinctrl-aspeed.c b/drivers/pinctrl/aspeed/pinctrl-aspeed.c index a30912a92f05..f93d6959cee9 100644 --- a/drivers/pinctrl/aspeed/pinctrl-aspeed.c +++ b/drivers/pinctrl/aspeed/pinctrl-aspeed.c @@ -113,7 +113,7 @@ static int aspeed_disable_sig(struct aspeed_pinmux_data *ctx, int ret = 0; if (!exprs) - return true; + return -EINVAL; while (*exprs && !ret) { ret = aspeed_sig_expr_disable(ctx, *exprs);
The function signature is int, but we return a bool. Instead return a negative errno as the kerneldoc suggests. Fixes: 4d3d0e4272d8 ("pinctrl: Add core support for Aspeed SoCs") Signed-off-by: Joel Stanley <joel@jms.id.au> --- drivers/pinctrl/aspeed/pinctrl-aspeed.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)