diff mbox series

[RESEND,v10,4/5] dt-bindings: media: i2c: imx334 add new link_freq

Message ID 20230121033713.3535351-5-shravan.chippa@microchip.com
State Superseded
Headers show
Series media: i2c: imx334: support lower bandwidth mode | expand

Commit Message

shravan chippa Jan. 21, 2023, 3:37 a.m. UTC 
From: Shravan Chippa <shravan.chippa@microchip.com>

Add new supported link frequency in dt example.

Suggested-by: Sakari Ailus <sakari.ailus@iki.fi>
Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com>
---
 Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Jan. 22, 2023, 2:07 p.m. UTC | #1 
On 21/01/2023 04:37, shravan kumar wrote:
> From: Shravan Chippa <shravan.chippa@microchip.com>
> 
> Add new supported link frequency in dt example.

You got comment to fix you CC list. Why not following my feedback?

Best regards,
Krzysztof
shravan chippa Jan. 23, 2023, 6:28 a.m. UTC | #2 
Hi,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: 22 January 2023 07:37 PM
> To: shravan Chippa - I35088 <Shravan.Chippa@microchip.com>;
> paul.j.murphy@intel.com; daniele.alessandrelli@intel.com;
> mchehab@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> shawnguo@kernel.org; s.hauer@pengutronix.de
> Cc: festevam@gmail.com; kernel@pengutronix.de; linux-imx@nxp.com;
> linux-media@vger.kernel.org; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Sakari
> Ailus <sakari.ailus@iki.fi>
> Subject: Re: [PATCH RESEND v10 4/5] dt-bindings: media: i2c: imx334 add
> new link_freq
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> content is safe
> 
> On 21/01/2023 04:37, shravan kumar wrote:
> > From: Shravan Chippa <shravan.chippa@microchip.com>
> >
> > Add new supported link frequency in dt example.
> 
> You got a comment to fix you CC list. Why not follow my feedback?

Based on your previous comment I ran the below script, rebased to the latest code and based on that output I have added a CC list
But I missed adding one name to the to-list which is  "Rob Herring <robh+dt@kernel.org>", I will add it.
Did I miss any other entry in the CC list?

*************************************
./scripts/get_maintainer.pl Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
"Paul J. Murphy" <paul.j.murphy@intel.com> (maintainer:SONY IMX334 SENSOR DRIVER,in file)
Daniele Alessandrelli <daniele.alessandrelli@intel.com> (maintainer:SONY IMX334 SENSOR DRIVER,in file)
Mauro Carvalho Chehab <mchehab@kernel.org> (maintainer:MEDIA INPUT INFRASTRUCTURE (V4L/DVB))
Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Shawn Guo <shawnguo@kernel.org> (maintainer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
Sascha Hauer <s.hauer@pengutronix.de> (maintainer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
Pengutronix Kernel Team <kernel@pengutronix.de> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
Fabio Estevam <festevam@gmail.com> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
NXP Linux Team <linux-imx@nxp.com> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
linux-media@vger.kernel.org (open list:SONY IMX334 SENSOR DRIVER)
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-arm-kernel@lists.infradead.org (moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
linux-kernel@vger.kernel.org (open list)

./scripts/get_maintainer.pl drivers/media/i2c/imx334.c
"Paul J. Murphy" <paul.j.murphy@intel.com> (maintainer:SONY IMX334 SENSOR DRIVER)
Daniele Alessandrelli <daniele.alessandrelli@intel.com> (maintainer:SONY IMX334 SENSOR DRIVER)
Mauro Carvalho Chehab <mchehab@kernel.org> (maintainer:MEDIA INPUT INFRASTRUCTURE (V4L/DVB))
linux-media@vger.kernel.org (open list:SONY IMX334 SENSOR DRIVER)
linux-kernel@vger.kernel.org (open list)
**************************
> 
> Best regards,
> Krzysztof
Krzysztof Kozlowski Jan. 23, 2023, 8 a.m. UTC | #3 
On 23/01/2023 07:28, Shravan.Chippa@microchip.com wrote:
> Hi,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Sent: 22 January 2023 07:37 PM
>> To: shravan Chippa - I35088 <Shravan.Chippa@microchip.com>;
>> paul.j.murphy@intel.com; daniele.alessandrelli@intel.com;
>> mchehab@kernel.org; krzysztof.kozlowski+dt@linaro.org;
>> shawnguo@kernel.org; s.hauer@pengutronix.de
>> Cc: festevam@gmail.com; kernel@pengutronix.de; linux-imx@nxp.com;
>> linux-media@vger.kernel.org; linux-kernel@vger.kernel.org;
>> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Sakari
>> Ailus <sakari.ailus@iki.fi>
>> Subject: Re: [PATCH RESEND v10 4/5] dt-bindings: media: i2c: imx334 add
>> new link_freq
>>
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
>> content is safe
>>
>> On 21/01/2023 04:37, shravan kumar wrote:
>>> From: Shravan Chippa <shravan.chippa@microchip.com>
>>>
>>> Add new supported link frequency in dt example.
>>
>> You got a comment to fix you CC list. Why not follow my feedback?
> 
> Based on your previous comment I ran the below script, rebased to the latest code and based on that output I have added a CC list
> But I missed adding one name to the to-list which is  "Rob Herring <robh+dt@kernel.org>", I will add it.

Which is quite important...

Best regards,
Krzysztof
Rob Herring (Arm) Jan. 23, 2023, 10:48 p.m. UTC | #4 
On Mon, Jan 23, 2023 at 09:00:30AM +0100, Krzysztof Kozlowski wrote:
> On 23/01/2023 07:28, Shravan.Chippa@microchip.com wrote:
> > Hi,
> > 
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> >> Sent: 22 January 2023 07:37 PM
> >> To: shravan Chippa - I35088 <Shravan.Chippa@microchip.com>;
> >> paul.j.murphy@intel.com; daniele.alessandrelli@intel.com;
> >> mchehab@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> >> shawnguo@kernel.org; s.hauer@pengutronix.de
> >> Cc: festevam@gmail.com; kernel@pengutronix.de; linux-imx@nxp.com;
> >> linux-media@vger.kernel.org; linux-kernel@vger.kernel.org;
> >> devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; Sakari
> >> Ailus <sakari.ailus@iki.fi>
> >> Subject: Re: [PATCH RESEND v10 4/5] dt-bindings: media: i2c: imx334 add
> >> new link_freq
> >>
> >> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
> >> content is safe
> >>
> >> On 21/01/2023 04:37, shravan kumar wrote:
> >>> From: Shravan Chippa <shravan.chippa@microchip.com>
> >>>
> >>> Add new supported link frequency in dt example.
> >>
> >> You got a comment to fix you CC list. Why not follow my feedback?
> > 
> > Based on your previous comment I ran the below script, rebased to the latest code and based on that output I have added a CC list
> > But I missed adding one name to the to-list which is  "Rob Herring <robh+dt@kernel.org>", I will add it.
> 
> Which is quite important...

Not really. I've long since given up trying to filter based on that. The 
DT list vs. to me is about the same firehose. Expecting senders to get 
it right or figure out what's important to you or not will never happen. 
With lore now, there's little need as I control what I get or not.

Rob
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
index f5055b9db693..09533496b20c 100644
--- a/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx334.yaml
@@ -82,7 +82,7 @@  examples:
                 imx334: endpoint {
                     remote-endpoint = <&cam>;
                     data-lanes = <1 2 3 4>;
-                    link-frequencies = /bits/ 64 <891000000>;
+                    link-frequencies = /bits/ 64 <891000000 445500000>;
                 };
             };
         };