diff mbox

[Xen-devel,v2] xen/arm: use XENLOG_G_ERR instead

Message ID 1459417309-17896-1-git-send-email-zhaoshenglong@huawei.com
State New
Headers show

Commit Message

Shannon Zhao March 31, 2016, 9:41 a.m. UTC 
From: Shannon Zhao <shannon.zhao@linaro.org>

To distinguish the error logs in function map_dev_mmio_region, use
XENLOG_G_ERR instead of XENLOG_ERR.

Signed-off-by: Shannon Zhao <shannon.zhao@linaro.org>
---
 xen/arch/arm/p2m.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Julien Grall April 1, 2016, 2:36 p.m. UTC | #1 
Hi,

On 01/04/16 15:26, Jan Beulich wrote:
>>>> On 31.03.16 at 11:41, <zhaoshenglong@huawei.com> wrote:
>> From: Shannon Zhao <shannon.zhao@linaro.org>
>>
>> To distinguish the error logs in function map_dev_mmio_region, use
>> XENLOG_G_ERR instead of XENLOG_ERR.
>
> Both title and description are pretty strange.

You are right. Shannon, I would say:

"xen/arm: map_dev_mmio_region: printk should be ratelimited

The function map_dev_mmio_region is used in a hypercall. Therefore all 
printks should be ratelimited to avoid a malicious guest flooding the 
console."

Regards,
diff mbox

Patch

diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
index 0011708..db21433 100644
--- a/xen/arch/arm/p2m.c
+++ b/xen/arch/arm/p2m.c
@@ -1284,7 +1284,7 @@  int map_dev_mmio_region(struct domain *d,
     res = map_mmio_regions(d, start_gfn, nr, mfn);
     if ( res < 0 )
     {
-        printk(XENLOG_ERR "Unable to map [%#lx - %#lx] in Dom%d\n",
+        printk(XENLOG_G_ERR "Unable to map [%#lx - %#lx] in Dom%d\n",
                start_gfn, start_gfn + nr - 1, d->domain_id);
         return res;
     }