| Message ID | 20230127160134.2658-2-mario.limonciello@amd.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Fix default DMIC gain on AMD PDM drivers | expand |
On Fri, Jan 27, 2023 at 10:01:28AM -0600, Mario Limonciello wrote: > A number of users for Lenovo Rembrandt based laptops are > reporting that the microphone is too quiet relative to > Windows with a dual boot. > > Increase the PDM gain to overcome this problem. Why not just make this a regular control that can be adjusted as users see fit?
[AMD Official Use Only - General] > -----Original Message----- > From: Mark Brown <broonie@kernel.org> > Sent: Friday, January 27, 2023 10:53 > To: Limonciello, Mario <Mario.Limonciello@amd.com> > Cc: Jaroslav Kysela <jkysela@redhat.com>; Mukunda, Vijendar > <Vijendar.Mukunda@amd.com>; Saba Kareem, Syed > <Syed.SabaKareem@amd.com>; linux-kernel@vger.kernel.org; > Pananchikkal, Renjith <Renjith.Pananchikkal@amd.com>; Mark Pearson > <mpearson@lenovo.com>; Liam Girdwood <lgirdwood@gmail.com>; > Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; alsa- > devel@alsa-project.org > Subject: Re: [PATCH 1/6] ASoC: amd: yc: Adjust the gain for PDM DMIC > > On Fri, Jan 27, 2023 at 10:01:28AM -0600, Mario Limonciello wrote: > > A number of users for Lenovo Rembrandt based laptops are > > reporting that the microphone is too quiet relative to > > Windows with a dual boot. > > > > Increase the PDM gain to overcome this problem. > > Why not just make this a regular control that can be adjusted as > users see fit? Maximum HW gain is what we probably should have been setting from the beginning. The module parameter stuff was in case we need to debug it. My thought is if we find some reported problems with the series we ask users to try the module parameters. If we're finding that certain parameters make sense for different systems then we tear out the module parameter and instead export a control and set policy from ucm. If nothing is reported, we can probably drop the parameters at some time in the future.
diff --git a/sound/soc/amd/yc/acp6x.h b/sound/soc/amd/yc/acp6x.h index 74b596e6807ad..846ca10e24d3f 100644 --- a/sound/soc/amd/yc/acp6x.h +++ b/sound/soc/amd/yc/acp6x.h @@ -31,7 +31,7 @@ #define ACP_ERROR_STAT 29 #define PDM_DECIMATION_FACTOR 2 #define ACP_PDM_CLK_FREQ_MASK 7 -#define ACP_WOV_MISC_CTRL_MASK 0x10 +#define ACP_WOV_MISC_CTRL_MASK 0x18 #define ACP_PDM_ENABLE 1 #define ACP_PDM_DISABLE 0 #define ACP_PDM_DMA_EN_STATUS 2
A number of users for Lenovo Rembrandt based laptops are reporting that the microphone is too quiet relative to Windows with a dual boot. Increase the PDM gain to overcome this problem. Signed-off-by: Mario Limonciello <mario.limonciello@amd.com> --- sound/soc/amd/yc/acp6x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)