diff mbox series

[RFT,v3,1/4] ARM: dts: exynos: add unit address to DWC3 node wrapper in Exynos5250

Message ID 20230127212713.267014-1-krzysztof.kozlowski@linaro.org
State New
Headers show
Series [RFT,v3,1/4] ARM: dts: exynos: add unit address to DWC3 node wrapper in Exynos5250 | expand

Commit Message

Krzysztof Kozlowski Jan. 27, 2023, 9:27 p.m. UTC
Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node
which do not have unit address.  Therefore usethe address space
of child device (actual DWC3 Controller) as the wrapper's address to
fix:

  exynos5250-smdk5250.dtb: soc: usb3: {'compatible': ['samsung,exynos5250-dwusb3'],
    ... } should not be valid under {'type': 'object'}

  exynos5250.dtsi:638.16-653.5: Warning (simple_bus_reg): /soc/usb3: missing or empty reg/ranges property

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

---

Changes since v1:
1. Use ranges with values and drop reg from usb-wrapper node.
2. Keep "usb" as wrapper's node name.
---
 arch/arm/boot/dts/exynos5250.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Krzysztof Kozlowski Jan. 29, 2023, 10:40 a.m. UTC | #1
On Fri, 27 Jan 2023 22:27:10 +0100, Krzysztof Kozlowski wrote:
> Neither simple-bus bindings nor dtc W=1 accept device nodes in soc@ node
> which do not have unit address.  Therefore usethe address space
> of child device (actual DWC3 Controller) as the wrapper's address to
> fix:
> 
>   exynos5250-smdk5250.dtb: soc: usb3: {'compatible': ['samsung,exynos5250-dwusb3'],
>     ... } should not be valid under {'type': 'object'}
> 
> [...]

Applied, thanks!

[1/4] ARM: dts: exynos: add unit address to DWC3 node wrapper in Exynos5250
      https://git.kernel.org/krzk/linux/c/47fea512b4bd18b0a69142f85bf1863c221539ef
[2/4] ARM: dts: exynos: add unit address to DWC3 node wrapper in Exynos54xx
      https://git.kernel.org/krzk/linux/c/27be20e3b9d125f2c1b066d1d238c67bf5b89dc3
[3/4] arm64: dts: exynos: add unit address to DWC3 node wrapper in Exynos5433
      https://git.kernel.org/krzk/linux/c/becad83e0f2a54c8a43ece3f0437b72842278a42
[4/4] arm64: dts: exynos: add unit address to DWC3 node wrapper in Exynos7
      https://git.kernel.org/krzk/linux/c/28dd277e54ebb499bc59c166078596767bbbbdd7

Best regards,
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 97e89859ba3d..a5db4ac213d5 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -635,17 +635,17 @@  i2s2: i2s@12d70000 {
 			#sound-dai-cells = <1>;
 		};
 
-		usbdrd: usb3 {
+		usbdrd: usb@12000000 {
 			compatible = "samsung,exynos5250-dwusb3";
 			clocks = <&clock CLK_USB3>;
 			clock-names = "usbdrd30";
 			#address-cells = <1>;
 			#size-cells = <1>;
-			ranges;
+			ranges = <0x0 0x12000000 0x10000>;
 
-			usbdrd_dwc3: usb@12000000 {
+			usbdrd_dwc3: usb@0 {
 				compatible = "snps,dwc3";
-				reg = <0x12000000 0x10000>;
+				reg = <0x0 0x10000>;
 				interrupts = <GIC_SPI 72 IRQ_TYPE_LEVEL_HIGH>;
 				phys = <&usbdrd_phy 0>, <&usbdrd_phy 1>;
 				phy-names = "usb2-phy", "usb3-phy";