diff mbox series

[1/2] ASoC: SOF: topology: Add missed "else" in sof_connect_dai_widget

Message ID 20230201112846.27707-2-peter.ujfalusi@linux.intel.com
State Accepted
Commit afd7c141c750f3f043c755bd8d01a2ffee7e95b2
Headers show
Series ASoC: (SOF) topology: Regression fixes for next | expand

Commit Message

Peter Ujfalusi Feb. 1, 2023, 11:28 a.m. UTC 
The conversion to use generic helpers missed the else for the dai
direction check which leads to failure when loading playback widgets

Fixes: 323f09a61d43 ("ASoC: sof: use helper function")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
---
 sound/soc/sof/topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Kuninori Morimoto Feb. 1, 2023, 11:59 p.m. UTC | #1 
Hi Peter

> The conversion to use generic helpers missed the else for the dai
> direction check which leads to failure when loading playback widgets
> 
> Fixes: 323f09a61d43 ("ASoC: sof: use helper function")
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
> ---

Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thank you for your help !!

Best regards
---
Kuninori Morimoto
diff mbox series

Patch

diff --git a/sound/soc/sof/topology.c b/sound/soc/sof/topology.c
index 3cfdf782afca..4a62ccc71fcb 100644
--- a/sound/soc/sof/topology.c
+++ b/sound/soc/sof/topology.c
@@ -1065,7 +1065,7 @@  static int sof_connect_dai_widget(struct snd_soc_component *scomp,
 
 	if (w->id == snd_soc_dapm_dai_out)
 		stream = SNDRV_PCM_STREAM_CAPTURE;
-	if (w->id == snd_soc_dapm_dai_in)
+	else if (w->id == snd_soc_dapm_dai_in)
 		stream = SNDRV_PCM_STREAM_PLAYBACK;
 	else
 		goto end;